Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v11]

2020-11-10 Thread Jonathan Gibbons
On Fri, 6 Nov 2020 18:41:15 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview APIs

Re: RFR: 8255822: Zero: improve build-time JVMTI handling [v3]

2020-11-10 Thread Aleksey Shipilev
On Tue, 10 Nov 2020 12:33:34 GMT, David Holmes wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains six commits: >> >> - Simplify a few JVMTI_ENABLED blocks >> - Merge branch 'master' into JDK-8255822-zero-

Integrated: 8255822: Zero: improve build-time JVMTI handling

2020-11-10 Thread Aleksey Shipilev
On Wed, 4 Nov 2020 16:29:27 GMT, Aleksey Shipilev wrote: > Current Zero interpreter has the optimization for JVMTI support. It > recognizes that JVMTI is disabled most of the time, and that JVMTI checks in > the interpreter code slows it down considerably. (I measured it myself when > working

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth wrote: >> Change looks ok from a build point of view, but I can't comment on the >> validity and implications of using this key. > > I ran a 3D lighting test that is designed to be a GPU stress test. It's a > worst case, to be sure, but it take

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Kevin Rushforth
On Tue, 10 Nov 2020 13:24:21 GMT, Erik Joelsson wrote: >> This is a review request for the bug particularly fixed some time ago: >> https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html >> >> In that review request it was found that the old fix does not work well in >> all cases,

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Erik Joelsson
On Tue, 10 Nov 2020 08:19:13 GMT, Sergey Bylokhov wrote: > This is a review request for the bug particularly fixed some time ago: > https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html > > In that review request it was found that the old fix does not work well in > all cases, see

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Kevin Rushforth
On Tue, 10 Nov 2020 08:19:13 GMT, Sergey Bylokhov wrote: > This is a review request for the bug particularly fixed some time ago: > https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html > > In that review request it was found that the old fix does not work well in > all cases, see

Re: RFR: 8255822: Zero: improve build-time JVMTI handling [v3]

2020-11-10 Thread David Holmes
On Tue, 10 Nov 2020 07:22:07 GMT, Aleksey Shipilev wrote: >> Current Zero interpreter has the optimization for JVMTI support. It >> recognizes that JVMTI is disabled most of the time, and that JVMTI checks in >> the interpreter code slows it down considerably. (I measured it myself when >> wor

Integrated: 8256048: Incomplete gitignore setting for netbeans project

2020-11-10 Thread Jie Fu
On Mon, 9 Nov 2020 12:07:37 GMT, Jie Fu wrote: > Hi all, > > The gitignore setting for netbeans project seems to be incomplete. > Only nbproject/private/ [1] is ignored. > > But there are also other files under nbproject/, which should be ignored too. > > $ tree -L

Re: Preliminary review for new WINENV support

2020-11-10 Thread Magnus Ihse Bursie
Hi Bernhard, Thank you for you efforts in keeping this patch viable and getting it closer to integration! I have no intention of letting this bitrot. The patch is, still, blocked by major simplifications I made:  * There is no support for the javac server  * There is no support for building

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v26]

2020-11-10 Thread Alan Bateman
On Mon, 9 Nov 2020 16:07:13 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation (see JEP 393 [1]). This >> iteration focus on improving the usability of the API in 3 main ways: >> >> * fi

Re: Preliminary review for new WINENV support

2020-11-10 Thread Bernhard Urban-Forster
Hello Magnus, Sorry for the late reply! This is awesome work and I don't want to see that to bit rot :-) I rebased your changes on top of current master: https://github.com/openjdk/jdk/compare/master...lewurm:winenv-testing This branch is by no means ready to be reviewed, it's just whatever I'

RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-11-10 Thread Sergey Bylokhov
This is a review request for the bug particularly fixed some time ago: https://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005425.html In that review request it was found that the old fix does not work well in all cases, see: https://mail.openjdk.java.net/pipermail/2d-dev/2015-August/005611.h