Re: RFR: 8256354: Github Action build on Windows should define OS and MSVC versions

2020-11-13 Thread Aleksey Shipilev
On Fri, 13 Nov 2020 17:26:28 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and MSVC versions used from latest > (currently 2

Re: RFR: 8256354: Github Action build on Windows should define OS and MSVC versions

2020-11-13 Thread Erik Joelsson
On Fri, 13 Nov 2020 17:26:28 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and MSVC versions used from latest > (currently 2

RFR: 8256354: Github Action build on Windows should define OS and MSVC versions

2020-11-13 Thread Robin Westberg
We should be more explicit about OS and compiler versions used in the GitHub Actions builds, to avoid problems caused by unexpected changes to the defaults. This patch changes the OS and MSVC versions used from latest (currently 2019) / default (currently 14.28) to 2019 / 14.27. -

Re: RFR: 8256308: Send arguments to javac server in a config file

2020-11-13 Thread Erik Joelsson
On Thu, 12 Nov 2020 22:13:37 GMT, Magnus Ihse Bursie wrote: > Currently, to use the javac server, a horrendously long command line option > is created, looking like this: `--server:portfile= portfile>:sjavac=`, where the sjavac command has > had all spaces replaced by %20. Since Project Jigsaw,

Re: RFR: 8256308: Send arguments to javac server in a config file [v5]

2020-11-13 Thread Erik Joelsson
On Fri, 13 Nov 2020 01:08:09 GMT, Magnus Ihse Bursie wrote: >> Currently, to use the javac server, a horrendously long command line option >> is created, looking like this: `--server:portfile=> portfile>:sjavac=`, where the sjavac command has >> had all spaces replaced by %20. Since Project Jig

Re: RFR: 8256277: Github Action build on macOS should define OS and Xcode versions

2020-11-13 Thread Erik Joelsson
On Fri, 13 Nov 2020 11:48:31 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and Xcode versions used from latest > (currently

Integrated: 8256127: Add cross-compiled foreign architectures builds to submit workflow

2020-11-13 Thread Aleksey Shipilev
On Tue, 10 Nov 2020 19:05:31 GMT, Aleksey Shipilev wrote: > It is > [possible](https://github.com/openjdk/jdk/blob/master/doc/building.md#creating-and-using-sysroots-with-qemu-deboostrap) > to efficiently cross-compile to foreign architectures on current GH actions > that are driven by Ubuntu.

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Aleksey Shipilev
On Fri, 13 Nov 2020 11:14:42 GMT, Aleksey Shipilev wrote: >> Yeah, it would certainly need a bit of adaptation to capture the differences >> properly, so perfectly fine to look into later! > > Thanks folks! I'll merge the master and see if it is still green, and if it > is, I'll integrate. Cro

Re: RFR: 8256277: Github Action build on macOS should define OS and Xcode versions

2020-11-13 Thread Robin Westberg
On Fri, 13 Nov 2020 11:58:19 GMT, Aleksey Shipilev wrote: >> We should be more explicit about OS and compiler versions used in the GitHub >> Actions builds, to avoid problems caused by unexpected changes to the >> defaults. This patch changes the OS and Xcode versions used from latest >> (curr

Re: RFR: 8256277: Github Action build on macOS should define OS and Xcode versions

2020-11-13 Thread Erik Helin
On Fri, 13 Nov 2020 11:48:31 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and Xcode versions used from latest > (currently

Re: RFR: 8256277: Github Action build on macOS should define OS and Xcode versions

2020-11-13 Thread Aleksey Shipilev
On Fri, 13 Nov 2020 11:48:31 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and Xcode versions used from latest > (currently

RFR: 8256277: Github Action build on macOS should define OS and Xcode versions

2020-11-13 Thread Robin Westberg
We should be more explicit about OS and compiler versions used in the GitHub Actions builds, to avoid problems caused by unexpected changes to the defaults. This patch changes the OS and Xcode versions used from latest (currently 10.15) / default (currently 12.0) to 10.15 / 11.3.1.

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v7]

2020-11-13 Thread Aleksey Shipilev
> It is > [possible](https://github.com/openjdk/jdk/blob/master/doc/building.md#creating-and-using-sysroots-with-qemu-deboostrap) > to efficiently cross-compile to foreign architectures on current GH actions > that are driven by Ubuntu. I have been using this method for years to produce > binar

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Aleksey Shipilev
On Fri, 13 Nov 2020 11:04:38 GMT, Robin Westberg wrote: >>> Looks good! I did a similar attempt at cross building a while ago, but >>> never got around to finishing it, so it's nice to see it materializing! I >>> do have a general comment on reducing the amount of duplicated content >>> though

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Robin Westberg
On Fri, 13 Nov 2020 10:54:01 GMT, Aleksey Shipilev wrote: >> Looks good! I did a similar attempt at cross building a while ago, but never >> got around to finishing it, so it's nice to see it materializing! I do have >> a general comment on reducing the amount of duplicated content though. Sinc

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Aleksey Shipilev
On Fri, 13 Nov 2020 10:07:26 GMT, Robin Westberg wrote: > Looks good! I did a similar attempt at cross building a while ago, but never > got around to finishing it, so it's nice to see it materializing! I do have a > general comment on reducing the amount of duplicated content though. Since >

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Robin Westberg
On Thu, 12 Nov 2020 06:50:08 GMT, Aleksey Shipilev wrote: >> It is >> [possible](https://github.com/openjdk/jdk/blob/master/doc/building.md#creating-and-using-sysroots-with-qemu-deboostrap) >> to efficiently cross-compile to foreign architectures on current GH actions >> that are driven by Ubu

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v5]

2020-11-13 Thread Magnus Ihse Bursie
On Thu, 12 Nov 2020 10:08:39 GMT, Volker Simonis wrote: >>> I'm not at all sure I want to accept these changes. I understand that you >>> care about these exotic platforms, and so do I, but adding them to the >>> submit workflow for _all_ changes seem like the wrong way to proceed. >> >> I und

Re: RFR: 8256127: Add cross-compiled foreign architectures builds to submit workflow [v6]

2020-11-13 Thread Magnus Ihse Bursie
On Thu, 12 Nov 2020 06:50:08 GMT, Aleksey Shipilev wrote: >> It is >> [possible](https://github.com/openjdk/jdk/blob/master/doc/building.md#creating-and-using-sysroots-with-qemu-deboostrap) >> to efficiently cross-compile to foreign architectures on current GH actions >> that are driven by Ubu