On Mon, 16 Nov 2020 23:30:25 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> t
On Tue, 17 Nov 2020 00:31:24 GMT, Igor Ignatyev wrote:
> Hi all,
>
>
> [8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
> similar profile to submit workflow, this patch defines `linux-x64-optimized`
> profile in jib-profile so it can be used by mach5 and added to tie
On Tue, 17 Nov 2020 00:31:24 GMT, Igor Ignatyev wrote:
> Hi all,
>
>
> [8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
> similar profile to submit workflow, this patch defines `linux-x64-optimized`
> profile in jib-profile so it can be used by mach5 and added to tie
Hi all,
[8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
similar profile to submit workflow, this patch defines `linux-x64-optimized`
profile in jib-profile so it can be used by mach5 and added to tier1?
Thanks
-- Igor
cc-ing @dcubed-ojdk
-
Commit mess
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table poin
On Thu, 5 Nov 2020 14:36:44 GMT, Erik Österlund wrote:
>> Ok, so there were many test failures with other approaches. Having GC
>> trigger the posting was the most reliable way to post the events when the
>> tests (and presumably the jvmti customers) expected the events to be posted.
>> We c
On Mon, 9 Nov 2020 20:39:40 GMT, Coleen Phillimore wrote:
>> Thanks @sspitsyn . I'm going to leave the gc_notification code because
>> structurally the two sides of the if statement are different and it's not a
>> long function. Thank you for reviewing the change.
>
> This change also passes
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table poin
Hi Igor, thanks for the update and the reference. Yes, makes sense to test
it automatically as long as it’s still there.
Cheers, Thomas
On Mon 16. Nov 2020 at 21:55, wrote:
> Hi Thomas,
>
> There is indeed was a discussion about the future of optimized flavor, and
> the consensus was to remove
Hi Thomas,
There is indeed was a discussion about the future of optimized flavor, and the
consensus was to remove it. We, however, haven’t done that yet (8183287[*] is
filed for that work). meanwhile, people still use optimized builds from time to
time so we need to ensure they are at least bui
Hi,
just curious, was the optimized build not earmarked for removal? I dimly
remember reading discussions about this.
Thanks, Thomas
On Mon, Nov 16, 2020 at 9:35 PM Daniel D.Daugherty
wrote:
> On Mon, 16 Nov 2020 19:29:59 GMT, Igor Ignatyev
> wrote:
>
> >> Marked as reviewed by shade (Reviewe
On Mon, 16 Nov 2020 19:29:59 GMT, Igor Ignatyev wrote:
>> Marked as reviewed by shade (Reviewer).
>
> Thanks for the reviews, folks. the build looks green, integrating.
> @iignatev - did you also change Mach5? I don't have workflow builds enabled
> by default since I typically do Mach5 builds...
On Mon, 16 Nov 2020 19:29:59 GMT, Igor Ignatyev wrote:
>> Marked as reviewed by shade (Reviewer).
>
> Thanks for the reviews, folks. the build looks green, integrating.
@iignatev - did you also change Mach5? I don't have workflow builds enabled
by default since I typically do Mach5 builds...
--
On Mon, 16 Nov 2020 18:58:37 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added --disable-precompiled-headers
>
> Marked as reviewed by shade (Reviewer).
Thanks for the reviews, folks. th
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
This pull request has now b
On Mon, 16 Nov 2020 18:53:20 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> Could you please review this small and trivial patch which adds
>> `linux-x64-optimized` build to submit workflow so breakages of this build
>> flavor would be easier to spot?
>>
>> Thanks,
>> -- Igor
>
> Igor Ignatyev ha
On Mon, 16 Nov 2020 18:40:27 GMT, Aleksey Shipilev wrote:
> Looks fine, but wouldn't you like to add `--disable-precompiled-headers` as
> well?
sure, make sense.
-
PR: https://git.openjdk.java.net/jdk/pull/1233
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with one additional
commit
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
Marked as reviewed by kvn (
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
Looks fine, but wouldn't yo
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
Thanks a lot, Igor! Looks g
Hi all,
Could you please review this small and trivial patch which adds
`linux-x64-optimized` build to submit workflow so breakages of this build
flavor would be easier to spot?
Thanks,
-- Igor
-
Commit messages:
- add linux-x64-optimized build
Changes: https://git.openjdk.java.
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table poin
Hi,
> >> 89:
> >> 90: - name: Build jtreg
> >> 91: run: sh make/build-all.sh ${JAVA_HOME_8_X64}
> >
> > What is this change?
>
> On ubuntu-20.04 the default Java installation is now set to 11, but jtreg
> still requires Java 8 for building.
Why does jtreg need OpenJDK-8 for buildi
On Mon, 16 Nov 2020 14:27:39 GMT, Magnus Ihse Bursie wrote:
>> We should be more explicit about OS and compiler versions used in the GitHub
>> Actions builds, to avoid problems caused by unexpected changes to the
>> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
>
On Mon, 16 Nov 2020 12:51:25 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
> (curre
On Mon, 16 Nov 2020 12:51:25 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
> (curre
On Mon, 16 Nov 2020 12:44:08 GMT, Magnus Ihse Bursie wrote:
>> Currently, to use the javac server, a horrendously long command line option
>> is created, looking like this: `--server:portfile=> portfile>:sjavac=`, where the sjavac command has
>> had all spaces replaced by %20. Since Project Jig
On Mon, 16 Nov 2020 13:34:58 GMT, Robin Westberg wrote:
>> .github/workflows/submit.yml line 91:
>>
>>> 89:
>>> 90: - name: Build jtreg
>>> 91: run: sh make/build-all.sh ${JAVA_HOME_8_X64}
>>
>> What is this change?
>
> On ubuntu-20.04 the default Java installation is now set to
On Mon, 16 Nov 2020 13:13:52 GMT, Aleksey Shipilev wrote:
>> We should be more explicit about OS and compiler versions used in the GitHub
>> Actions builds, to avoid problems caused by unexpected changes to the
>> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
>>
On Mon, 16 Nov 2020 13:36:57 GMT, Aleksey Shipilev wrote:
>> We should be more explicit about OS and compiler versions used in the GitHub
>> Actions builds, to avoid problems caused by unexpected changes to the
>> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
>>
On Mon, 16 Nov 2020 12:51:25 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
> (curre
On Mon, 16 Nov 2020 12:51:25 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and GCC versions used from ubuntu-latest
> (curre
We should be more explicit about OS and compiler versions used in the GitHub
Actions builds, to avoid problems caused by unexpected changes to the defaults.
This patch changes the OS and GCC versions used from ubuntu-latest (currently
18.04, but will change to 20.04 sometime soon) / default (cur
> Currently, to use the javac server, a horrendously long command line option
> is created, looking like this: `--server:portfile= portfile>:sjavac=`, where the sjavac command has
> had all spaces replaced by %20. Since Project Jigsaw, the set of module
> arguments needed is huge to begin with,
On Fri, 13 Nov 2020 17:26:28 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and MSVC versions used from latest
> (currently 2
On Fri, 13 Nov 2020 11:48:31 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and Xcode versions used from latest
> (currently
37 matches
Mail list logo
