Integrated: JDK-8256810: Incremental rebuild broken on Macosx

2020-11-30 Thread Erik Joelsson
On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson wrote: > After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't > actually doing the right thing at all. It seems clang on Macosx is > inconsistent with outputting relative or absolute paths in the deps files, so > some files end

Integrated: 8256541: Sort out what version of awk is used in the build system

2020-11-30 Thread Magnus Ihse Bursie
On Thu, 26 Nov 2020 20:58:38 GMT, Magnus Ihse Bursie wrote: > For historical reasons, there exists a variety of different implementations > of awk: awk (the original implementation), gawk (the GNU version), nawk (new > awk, iirc) and the lesser known mawk. > > Things are complicated by the fa

Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]

2020-11-30 Thread Erik Joelsson
On Mon, 23 Nov 2020 15:19:18 GMT, Bernhard Urban-Forster wrote: >> I think you need to wait for #1350, and then reconcile this patch with that >> refactoring. > > Thanks for all the comments. > >> - 40-50 min builds seem to be excessive for just the hotspot build, do >> youknow what exactly t

Re: RFR: 8256541: Sort out what version of awk is used in the build system

2020-11-30 Thread Erik Joelsson
On Thu, 26 Nov 2020 20:58:38 GMT, Magnus Ihse Bursie wrote: > For historical reasons, there exists a variety of different implementations > of awk: awk (the original implementation), gawk (the GNU version), nawk (new > awk, iirc) and the lesser known mawk. > > Things are complicated by the fa

Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v3]

2020-11-30 Thread Jan Lahoda
> Adding support for record classes in the historical data for ct.sym. This > includes a few changes not strictly needed for the change: > -updating and moving tests into test/langtools, so that it is easier to run > them. > -fixing Record attribute reading in javac's ClassReader (used for tests,

Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v3]

2020-11-30 Thread Jan Lahoda
On Mon, 30 Nov 2020 12:17:46 GMT, Chris Hegarty wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing tests on Windows - normalizing line endings. > > make/langtools/src/classes/build/tools/symbolgenerator/CreateSym

Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v2]

2020-11-30 Thread Jan Lahoda
> Adding support for record classes in the historical data for ct.sym. This > includes a few changes not strictly needed for the change: > -updating and moving tests into test/langtools, so that it is easier to run > them. > -fixing Record attribute reading in javac's ClassReader (used for tests,

Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols

2020-11-30 Thread Chris Hegarty
On Fri, 27 Nov 2020 13:21:15 GMT, Jan Lahoda wrote: > Adding support for record classes in the historical data for ct.sym. This > includes a few changes not strictly needed for the change: > -updating and moving tests into test/langtools, so that it is easier to run > them. > -fixing Record att