After fixing JDK-8256810 and starting to look into backporting it, I discovered
more potential failing cases. Certain versions of GCC may sometimes output
multiple prerequisite files on the same line. I think the easiest way to handle
this new issue is to split such lines.
When splitting lines,
On Tue, 1 Dec 2020 11:18:11 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing Record
On Tue, 1 Dec 2020 02:18:18 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> Looks mostly OK; some minor comments inline.
Thanks for the c
On Tue, 1 Dec 2020 01:43:47 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> test/langtools/tools/javac/platform/createsymbols/CreateSymbol
> Adding support for record classes in the historical data for ct.sym. This
> includes a few changes not strictly needed for the change:
> -updating and moving tests into test/langtools, so that it is easier to run
> them.
> -fixing Record attribute reading in javac's ClassReader (used for tests,
On Tue, 1 Dec 2020 10:09:33 GMT, Magnus Ihse Bursie wrote:
> According to the enhancement request:
>
> It would be nice and convenient to include the configuration name in the
> configuration summary, for example ("Name" being new):
>
> Configuration summary:
> * Name: my-conf
> * Debug level:
On Tue, 1 Dec 2020 10:09:33 GMT, Magnus Ihse Bursie wrote:
> According to the enhancement request:
>
> It would be nice and convenient to include the configuration name in the
> configuration summary, for example ("Name" being new):
>
> Configuration summary:
> * Name: my-conf
> * Debug level:
According to the enhancement request:
It would be nice and convenient to include the configuration name in the
configuration summary, for example ("Name" being new):
Configuration summary:
* Name: my-conf
* Debug level: release
* HS debug level: product
* JVM variants: server
...
-