Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Hao Sun
On Thu, 24 Dec 2020 13:27:33 GMT, Kim Barrett wrote: > I think the two issues described here are distinct and should be dealt > with in separate bugs and PRs. Their only relation is that both arise > with using clang-10. But they are very different problems, in very > different parts of the code,

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Hao Sun
On Thu, 24 Dec 2020 20:42:01 GMT, Xin Liu wrote: >> src/hotspot/share/opto/node.hpp line 1458: >> >>> 1456: // initialize to garbage >>> 1457: >>> 1458: DUIterator_Last (const DUIterator_Last& that) : >>> DUIterator_Fast(that) {} >> >> Since DUIterator_Last is just delegating both the cop

Re: RFR: 8247957: remove doclint support for HTML 4 [v7]

2020-12-24 Thread Jonathan Gibbons
On Fri, 25 Dec 2020 02:17:16 GMT, Yoshiki Sato wrote: >> HTML4 is no longer supported in javadoc. >> >> doclint needs to drop HTML4 support as well. >> The changes consist of: >> * Removing -Xhtmlversion option from doclint and --doclint-format from javac. >> * Removing jdk.javadoc.internal.docl

Re: RFR: 8247957: remove doclint support for HTML 4 [v7]

2020-12-24 Thread Yoshiki Sato
> HTML4 is no longer supported in javadoc. > > doclint needs to drop HTML4 support as well. > The changes consist of: > * Removing -Xhtmlversion option from doclint and --doclint-format from javac. > * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references. > * Updating makefile not

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Xin Liu
On Thu, 24 Dec 2020 17:27:39 GMT, Kim Barrett wrote: >> 1. '-Wdeprecated-copy' >> As specified in C++11 [1], "the generation of the implicitly-defined >> copy constructor is deprecated if T has a user-defined destructor or >> user-defined copy assignment operator". The rationale behind is the >>

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Kim Barrett
> On Dec 22, 2020, at 8:52 PM, Hao Sun > wrote: > > 1. '-Wdeprecated-copy' > As specified in C++11 [1], "the generation of the implicitly-defined > copy constructor is deprecated if T has a user-defined destructor or > user-defined copy assignment operator". The rationale behind is the > well-kn

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Kim Barrett
On Wed, 23 Dec 2020 01:45:58 GMT, Hao Sun wrote: > 1. '-Wdeprecated-copy' > As specified in C++11 [1], "the generation of the implicitly-defined > copy constructor is deprecated if T has a user-defined destructor or > user-defined copy assignment operator". The rationale behind is the > well-kno

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-24 Thread Kim Barrett
On Wed, 23 Dec 2020 01:45:58 GMT, Hao Sun wrote: > 1. '-Wdeprecated-copy' > As specified in C++11 [1], "the generation of the implicitly-defined > copy constructor is deprecated if T has a user-defined destructor or > user-defined copy assignment operator". The rationale behind is the > well-kno

RFR: 8258925: configure script failed on WSL

2020-12-24 Thread Yasumasa Suenaga
I ran configure script on WSL 1, but it failed as below: $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 : configure: Found potential Boot JDK using configure arguments configure: The command for java_to_test, which resolves as "/mnt/d/Java/jdk-15.0.1/bin/java", can n