Re: RFR: 8258925: configure script failed on WSL

2021-01-07 Thread Yasumasa Suenaga
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote: > I ran configure script on WSL 1, but it failed as below: > > $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 > > : > > configure: Found potential Boot JDK using configure arguments > configure: The command

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread David Holmes
On 8/01/2021 4:45 pm, Yasumasa Suenaga wrote: On Fri, 8 Jan 2021 06:23:35 GMT, David Holmes wrote: I pushed to new commit to save original `$path` and restore it later if the path not found. Could you review again? Sorry but I'm really not following exactly what the problem is and thus the

Adding to building info on space in windows directories

2021-01-07 Thread -
Hello, This is a followup of https://mail.openjdk.java.net/pipermail/build-dev/2021-January/029905.html. In that thread, my build on Windows 10 (not WSL) failed because Windows did not short path some directories with space in it, such as "Microsoft Visual Studio" or "Microsoft SDKs", while

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 06:23:35 GMT, David Holmes wrote: >> I pushed to new commit to save original `$path` and restore it later if the >> path not found. >> Could you review again? > > Sorry but I'm really not following exactly what the problem is and thus the > solution. How does setting path

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread David Holmes
On Fri, 8 Jan 2021 06:03:46 GMT, Yasumasa Suenaga wrote: >> make/scripts/fixpath.sh line 152: >> >>> 150: # If it fails, try again with an added .exe (needed on WSL) >>> 151: if [[ $? -ne 0 ]]; then >>> 152: path="$path.exe" >> >> This seems to conflict with the logic starting at

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
On Fri, 8 Jan 2021 04:27:16 GMT, David Holmes wrote: >> Yasumasa Suenaga has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8258925: configure script failed on WSL [v2]

2021-01-07 Thread Yasumasa Suenaga
> I ran configure script on WSL 1, but it failed as below: > > $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 > > : > > configure: Found potential Boot JDK using configure arguments > configure: The command for java_to_test, which resolves as >

Re: RFR: 8258925: configure script failed on WSL

2021-01-07 Thread David Holmes
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote: > I ran configure script on WSL 1, but it failed as below: > > $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1 > > : > > configure: Found potential Boot JDK using configure arguments > configure: The command

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jonathan Gibbons
On Fri, 8 Jan 2021 01:58:07 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Fixing tests after a merge. >> - Merging master into JDK-8250768 >> - Merging recent

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jonathan Gibbons
On Thu, 7 Jan 2021 20:23:16 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy [v4]

2021-01-07 Thread Vladimir Kozlov
On Wed, 6 Jan 2021 06:14:11 GMT, Hao Sun wrote: >> 1. '-Wdeprecated-copy' >> As specified in C++11 [1], "the generation of the implicitly-defined >> copy constructor is deprecated if T has a user-defined destructor or >> user-defined copy assignment operator". The rationale behind is the >>

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8258484: AIX build fails in Harfbuzz with XLC 16.01..0006 - 8039278: console.sh failed Automatically with exit code 1 - 8258972: unexpected compilation error with generic sealed interface - 8259227: C2 crashes with

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
On Thu, 7 Jan 2021 23:46:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 56a354eb Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/56a354eb Stats: 198 lines in 15 files changed: 147

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy [v3]

2021-01-07 Thread Hao Sun
On Wed, 6 Jan 2021 04:27:44 GMT, Hao Sun wrote: > Thanks for your comments. @kimbarrett and @navyxliu > I updated the patch based on my understanding. Please check the latest commit. > > As @kimbarrett mentioned, I suppose there still exist the following problems > to be addressed. > > 1.

Re: RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy [v2]

2021-01-07 Thread Hao Sun
On Wed, 6 Jan 2021 20:05:07 GMT, Vladimir Kozlov wrote: >> I manually checked the usages of assignment operators for class DUIterator, >> DUIterator_Fast and DUIterator_Last. (Simply grep the class names in the >> source code and check the context). >> >> ~~I found there exist only a couple

Re: Cannot build new jdk on Windows after commit d29c78d

2021-01-07 Thread Yasumasa Suenaga
Hi, I use WSL 1 to build OpenJDK on Windows 10. However, it has a problem in fixpath.sh, so I've posted PR for it. https://github.com/openjdk/jdk/pull/1889 You can build OpenJDK if you apply it. Thanks, Yasumasa On 2021/01/08 0:20, Anirvan Sarkar wrote: ++ build-dev On Thu, 7 Jan 2021

[jdk16] Integrated: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

2021-01-07 Thread Christoph Langer
On Thu, 7 Jan 2021 22:47:35 GMT, Christoph Langer wrote: > 8258484: AIX build fails in Harfbuzz with XLC 16.01..0006 This pull request has now been integrated. Changeset: 677802d2 Author:Christoph Langer URL: https://git.openjdk.java.net/jdk16/commit/677802d2 Stats: 6 lines

[jdk16] Integrated: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

2021-01-07 Thread Christoph Langer
8258484: AIX build fails in Harfbuzz with XLC 16.01..0006 - Commit messages: - Backport 3f9f86f0d3f918b9955ba6ba73c9c58ae8fcf7cb Changes: https://git.openjdk.java.net/jdk16/pull/95/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=95=00 Issue:

Re: [jdk16] RFR: JDK-8259429: Update reference to README.md

2021-01-07 Thread Iris Clark
On Thu, 7 Jan 2021 22:01:51 GMT, Erik Joelsson wrote: > In JDK-8251551, the top level README file changed names to README.md. In > jib-profiles.js we have a reference to this file to identify if the current > source tree is likely to be complete. This reference needs to be updated. Marked as

[jdk16] RFR: JDK-8259429: Update reference to README.md

2021-01-07 Thread Erik Joelsson
In JDK-8251551, the top level README file changed names to README.md. In jib-profiles.js we have a reference to this file to identify if the current source tree is likely to be complete. This reference needs to be updated. - Commit messages: - Change reference in jib-profiles.js

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
On Thu, 7 Jan 2021 20:40:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 555641ed Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/555641ed Stats: 2957 lines in 68 files changed: 751

RFR: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description - 8251200: False positive messages about missing comments for serialization - 8259312: VerifyCACerts.java fails as

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jan Lahoda
> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v12]

2021-01-07 Thread Jan Lahoda
On Wed, 9 Dec 2020 13:30:14 GMT, Magnus Ihse Bursie wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 55 commits: >> >> - Merging recent master changes into JDK-8250768 >> - Fixing navigator for the PREVIEW

Re: Cannot build new jdk on Windows after commit d29c78d

2021-01-07 Thread Anirvan Sarkar
++ build-dev On Thu, 7 Jan 2021 at 8:19 AM, - wrote: > Hello, > > I am a Windows 10 user trying to build OpenJDK HEAD > so that I can try to fix a bug in > javadoc. > > However, when I run make configure, my configure fails because it cannot > detect a regular

[jdk16] Integrated: JDK-8258657: Doc build is broken by use of new language features

2021-01-07 Thread Erik Joelsson
On Tue, 5 Jan 2021 22:51:29 GMT, Erik Joelsson wrote: > This patch changes how the docs-reference make target behaves to better > support the requirements for it. This target is used to generate javadocs in > a more stable way between releases, so that they those docs are better suited > for

Re: [jdk16] RFR: JDK-8258657: Doc build is broken by use of new language features [v2]

2021-01-07 Thread Erik Joelsson
> This patch changes how the docs-reference make target behaves to better > support the requirements for it. This target is used to generate javadocs in > a more stable way between releases, so that they those docs are better suited > for generating diffs between releases. Currently we use the

Integrated: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

2021-01-07 Thread Matthias Baesken
On Thu, 7 Jan 2021 08:51:25 GMT, Matthias Baesken wrote: > Hello, for a while the AIX build fails with the following error in the > harfbuzz build > 1500-004: (U) INTERNAL COMPILER ERROR while compiling >

Re: RFR: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006 [v2]

2021-01-07 Thread Martin Doerr
On Thu, 7 Jan 2021 09:34:09 GMT, Matthias Baesken wrote: >> Hello, for a while the AIX build fails with the following error in the >> harfbuzz build >> 1500-004: (U) INTERNAL COMPILER ERROR while compiling >>

Re: RFR: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006 [v2]

2021-01-07 Thread Matthias Baesken
> Hello, for a while the AIX build fails with the following error in the > harfbuzz build > 1500-004: (U) INTERNAL COMPILER ERROR while compiling > OT::MarkBasePosFormat1::collect_variation_indices(hb_collect_variation_indices_context_t > *) const. > Compilation ended. Contact your

Re: RFR: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006 [v2]

2021-01-07 Thread Christoph Langer
On Thu, 7 Jan 2021 09:19:27 GMT, Matthias Baesken wrote: >> Hello, for a while the AIX build fails with the following error in the >> harfbuzz build >> 1500-004: (U) INTERNAL COMPILER ERROR while compiling >>

RFR: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006

2021-01-07 Thread Matthias Baesken
Hello, for a while the AIX build fails with the following error in the harfbuzz build 1500-004: (U) INTERNAL COMPILER ERROR while compiling OT::MarkBasePosFormat1::collect_variation_indices(hb_collect_variation_indices_context_t *) const. Compilation ended. Contact your Service