Though this content seems simple, it would be extremely frustrating to
newcomers, especially when the build stalls at "cannot find valid visual studio
installation" for no clear reason in logs at all.
-
Commit messages:
- 8259485: Document need for short paths when building on
On Mon, 11 Jan 2021 17:09:14 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 41:
>>
>>> 39:NSLog(@"%@",[NSThread callStackSymbols]); \
>>> 40:if ([NSThread isMainThread] == NO) { \
>>> 41:if ((*env)->ExceptionOccurred(env) ==
On Mon, 11 Jan 2021 19:27:12 GMT, Phil Race wrote:
>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8259343: [macOS] Update JNI error handling in Cocoa code.
On Fri, 8 Jan 2021 00:49:36 GMT, Vladimir Kozlov wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Split the PR, addressing -Wdeprecated-copy only
>>
>> As suggested by kimbarrett, we should focus on warnings
On Mon, 11 Jan 2021 22:04:16 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 16 -> JDK 17
This pull request has now been integrated.
Changeset: b378f54d
Author:Jesper Wilhelmsson
URL: https://git.openjdk.java.net/jdk/commit/b378f54d
Stats: 139 lines in 12 files changed: 116
> Forwardport JDK 16 -> JDK 17
Jesper Wilhelmsson has updated the pull request incrementally with one
additional commit since the last revision:
Merge
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2040/files
- new:
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote:
> I ran configure script on WSL 1, but it failed as below:
>
> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>
> :
>
> configure: Found potential Boot JDK using configure arguments
> configure: The command
Forwardport JDK 16 -> JDK 17
-
Commit messages:
- Merge
- 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
- 8259028: ClassCastException when using custom filesystem with wrapper
FileChannel impl
- 8259043: More Zero architectures need linkage with
On Mon, 11 Jan 2021 19:27:12 GMT, Phil Race wrote:
>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8259343: [macOS] Update JNI error handling in Cocoa code.
Build changes look good.
On Mon, 11 Jan 2021 18:56:38 GMT, Erik Joelsson wrote:
> There should be a dependency declaration added too. Something like this right
> after the SetupJdkLibrary macro call:
>
> $(BUILD_LIBOSXAPP): $(call FindLib, java.base, java)
Fixed.
-
PR:
> Proposed updates to JNI error handling.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8259343: [macOS] Update JNI error handling in Cocoa code.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1967/files
-
On Mon, 11 Jan 2021 17:52:19 GMT, Phil Race wrote:
>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8259343: [macOS] Update JNI error handling in Cocoa code.
> The file `make/autoconf/version-numbers` is plagued by a two-fold problem:
> first of all, it's a configuration file, not a part of autoconf, so it should
> reside in `make/conf` instead of `make/autoconf`.
>
> Secondly, contrary to the name, it does not only contain version numbers, but
>
On Tue, 15 Dec 2020 19:07:55 GMT, Magnus Ihse Bursie wrote:
> The file `make/autoconf/version-numbers` is plagued by a two-fold problem:
> first of all, it's a configuration file, not a part of autoconf, so it should
> reside in `make/conf` instead of `make/autoconf`.
>
> Secondly, contrary
On Mon, 11 Jan 2021 11:11:01 GMT, Magnus Ihse Bursie wrote:
> COMPARE_BUILD will fail to run the compare stage, since re-applying an
> applied patch does not work.
This pull request has now been integrated.
Changeset: dab17875
Author:Magnus Ihse Bursie
URL:
On Mon, 11 Jan 2021 05:58:28 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 46:
>>
>>> 44: if ((*env)->ExceptionOccurred(env) != NULL) { \
>>> 45: (*env)->ExceptionDescribe(env); \
>>> 46: } \
>>
>> So
On Mon, 11 Jan 2021 06:01:36 GMT, Sergey Bylokhov wrote:
>> I hadn't noticed that line - and definintely not realised it was recent.
>> I suppose he must have had a way to trigger it.
>> But I don't think it hurts to have both.
>
> I just tried to understand why we need to complicate this, to
> Proposed updates to JNI error handling.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8259343: [macOS] Update JNI error handling in Cocoa code.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1967/files
-
On Mon, 11 Jan 2021 05:52:02 GMT, Sergey Bylokhov wrote:
> Not sure that the check for ExceptionOccurred is needed,
It may not be needed in practice but if the code path is never taken no harm ...
in all other places where we check the ref to methods/field we only check the
return value, and
Hi Roland,
> Sure. Is a comment stating that this was backported what you have in mind?
Preferrably comment + link "backportet by" to your backport issue.
> Would you mind reviewing my RFR given you've already taken a look at
> this area?
I'll take a look.
Best regards,
Martin
> -Original
> thanks for letting me know. My plan was to backport both changes in the
> original order, but I'm fine if you do change to the new version at once.
> May I ask you to flag both issues as backported once you're done?
Sure. Is a comment stating that this was backported what you have in mind?
Hi Roland,
thanks for letting me know. My plan was to backport both changes in the
original order, but I'm fine if you do change to the new version at once.
May I ask you to flag both issues as backported once you're done?
Best regards,
Martin
> -Original Message-
> From: Roland
Hi Martin,
> JDK-8256810 is backported to 11.0.11-oracle. I'd like to backport it for
> parity.
> Change doesn't apply cleanly because of an unlrelated context change (Solaris
> removal).
See my RFR for the backport of 8257547. It basically replaces all of
that code.
Roland.
Hi,
JDK-8256810 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change doesn't apply cleanly because of an unlrelated context change (Solaris
removal).
Bug:
https://bugs.openjdk.java.net/browse/JDK-8256810
Original change:
https://github.com/openjdk/jdk/commit/4c86e46d
On Mon, 11 Jan 2021 11:11:01 GMT, Magnus Ihse Bursie wrote:
> COMPARE_BUILD will fail to run the compare stage, since re-applying an
> applied patch does not work.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2025
On Sat, 9 Jan 2021 14:05:10 GMT, Yasumasa Suenaga wrote:
>> I ran configure script on WSL 1, but it failed as below:
>>
>> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>>
>> :
>>
>> configure: Found potential Boot JDK using configure arguments
>> configure: The
On Mon, 4 Jan 2021 08:34:02 GMT, Aleksey Shipilev wrote:
> JDK-8256831 added the Zero linkage with libatomic for MIPS, but there are
> other 32-bit Zero platforms that need the same kind of treatment.
>
> Additional testing:
> - [x] linux-mipsel-zero-fastdebug build
This pull request has
On Mon, 4 Jan 2021 18:42:05 GMT, Erik Joelsson wrote:
>> JDK-8256831 added the Zero linkage with libatomic for MIPS, but there are
>> other 32-bit Zero platforms that need the same kind of treatment.
>>
>> Additional testing:
>> - [x] linux-mipsel-zero-fastdebug build
>
> Marked as reviewed
> Right now `CompileJavaModules.gmk` contains two different part: one part with
> the functionality needed to compile a java module, and one part were all
> special requirements for all modules are listed.
>
> The second part should be removed from `CompileJavaModules.gmk`, and instead
>
On Tue, 15 Dec 2020 13:11:30 GMT, Magnus Ihse Bursie wrote:
> Right now `CompileJavaModules.gmk` contains two different part: one part with
> the functionality needed to compile a java module, and one part were all
> special requirements for all modules are listed.
>
> The second part should
On Mon, 4 Jan 2021 15:16:35 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Final bug fixes...
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 Actually, I had not done that. But it
COMPARE_BUILD will fail to run the compare stage, since re-applying an applied
patch does not work.
-
Commit messages:
- 8259559: COMPARE_BUILD can't compare patch files
Changes: https://git.openjdk.java.net/jdk/pull/2025/files
Webrev:
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs
On Mon, 4 Jan 2021 21:20:53 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains eight
>> additional
34 matches
Mail list logo
