Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2021-01-22 Thread Alan Bateman
On Fri, 15 Jan 2021 14:58:14 GMT, Alan Bateman wrote: >> This PR is not stale; it's just still waiting for input from @AlanBateman. > > @magicus Can the CharacterDataXXX.template files move to > src/java.base/share/classes/java/lang? > @AlanBateman When I moved the charset templates, I found th

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port

2021-01-22 Thread Erik Joelsson
On Fri, 22 Jan 2021 18:49:42 GMT, Anton Kozlov wrote: > Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new ca

RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port

2021-01-22 Thread Anton Kozlov
Please review the implementation of JEP 391: macOS/AArch64 Port. It's heavily based on existing ports to linux/aarch64, macos/x86_64, and windows/aarch64. Major changes are in: * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks JDK-8253817, JDK-8253818) * src/hotspot/os

Re: RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v5]

2021-01-22 Thread Harold Seigel
On Thu, 21 Jan 2021 05:24:09 GMT, David Holmes wrote: >> We are now confident that we have build-time and runtime support for >> clock_gettime and CLOCK_MONOTONIC on all our OpenJDK supported POSIX >> platforms - see bug report for some more details on different OS. >> Consequently we can simp

Re: RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-01-22 Thread Magnus Ihse Bursie
On Mon, 18 Jan 2021 18:27:14 GMT, Adam Farley wrote: > Ensure make files look on the include path or in PHASE_MAKEDIRS for > customizations. > > Change also adds a tidy-up that improves readability. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8260272: bash configure --prefix does not work after JDK-8257679 [v2]

2021-01-22 Thread Magnus Ihse Bursie
On Fri, 22 Jan 2021 04:49:07 GMT, Dongbo He wrote: >> $ bash configure --prefix=/home/hedongbo/jdk-release >> $ make install >> ... >> Creating CDS archive for jdk image >> Creating CDS-NOCOOPS archive for jdk image >> Installing jdk image into /jvm/openjdk-17-internal >> and creating 60 links fr

Re: RFR: 8260272: bash configure --prefix does not work after JDK-8257679 [v2]

2021-01-22 Thread Erik Joelsson
On Fri, 22 Jan 2021 04:49:07 GMT, Dongbo He wrote: >> $ bash configure --prefix=/home/hedongbo/jdk-release >> $ make install >> ... >> Creating CDS archive for jdk image >> Creating CDS-NOCOOPS archive for jdk image >> Installing jdk image into /jvm/openjdk-17-internal >> and creating 60 links fr

Re: RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v5]

2021-01-22 Thread Thomas Stuefe
On Thu, 21 Jan 2021 15:26:43 GMT, Gerard Ziemski wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove the always true os::supports_monotonic_clock() > > Marked as reviewed by gziemski (Committer). Builds fine on