Re: RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v5]

2021-01-24 Thread David Holmes
On 25/01/2021 5:19 pm, Thomas Stuefe wrote: On Fri, 22 Jan 2021 16:17:57 GMT, Harold Seigel wrote: David Holmes has updated the pull request incrementally with one additional commit since the last revision: Remove the always true os::supports_monotonic_clock() Hi David, The changes look

Re: RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v5]

2021-01-24 Thread Thomas Stuefe
On Fri, 22 Jan 2021 16:17:57 GMT, Harold Seigel wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove the always true os::supports_monotonic_clock() > > Hi David, > The changes look good. Just a couple of nits. >

Re: RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v6]

2021-01-24 Thread David Holmes
> We are now confident that we have build-time and runtime support for > clock_gettime and CLOCK_MONOTONIC on all our OpenJDK supported POSIX > platforms - see bug report for some more details on different OS. > Consequently we can simplify a lot of the code in this area and move common > code

Integrated: 8260272: bash configure --prefix does not work after JDK-8257679

2021-01-24 Thread Dongbo He
On Fri, 22 Jan 2021 01:29:10 GMT, Dongbo He wrote: > $ bash configure --prefix=/home/hedongbo/jdk-release > $ make install > ... > Creating CDS archive for jdk image > Creating CDS-NOCOOPS archive for jdk image > Installing jdk image into /jvm/openjdk-17-internal > and creating 60 links from /bin

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Vladimir Kempik
On Sat, 23 Jan 2021 11:43:31 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/macroAsse

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Sat, 23 Jan 2021 11:42:48 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/interpret

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Sat, 23 Jan 2021 11:10:17 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/interpret

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Fri, 22 Jan 2021 20:18:51 GMT, Erik Joelsson wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > make/autoconf/flags-cflags.m4 li

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)