Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Integrated: 8254702: jpackage app launcher crashes on CentOS

2021-02-05 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote: > Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ cod

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

RFR: JDK-8261261: The version extra fields needs to be overridable in jib-profiles.js

2021-02-05 Thread Erik Joelsson
The Oracle internal file jib-profiles.js needs needs the getVersion function extended so that the extra1-3 fields can be overridden just like the existing version fields. - Commit messages: - Make extra1-3 overridable Changes: https://git.openjdk.java.net/jdk/pull/2435/files Webr

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v6]

2021-02-05 Thread Andy Herrick
On Fri, 5 Feb 2021 17:44:21 GMT, Alexey Semenyuk wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C++

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Alexey Ushakov
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v6]

2021-02-05 Thread Erik Joelsson
On Fri, 5 Feb 2021 17:44:21 GMT, Alexey Semenyuk wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C++

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-05 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 18:35:54 GMT, Alexey Semenyuk wrote: >>> "common" was perfectly enough until this change. Unfortunately we cant just >>> drop new C sources in "common" dir because we don't want them to be >>> compiled with g++. That is why need new common directory >>> (applauncherlibcommon

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v6]

2021-02-05 Thread Alexey Semenyuk
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ code from app launcher. > At startup app launcher loads launc

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Tue, 2 Feb 2021 18:35:51 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/cpu/aarch64/vm_version_aarch64.hpp line 93: > >> 91: CPU_MARVELL

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Wed, 3 Feb 2021 23:29:30 GMT, Gerard Ziemski wrote: >> using ` ```c ` >> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks >> >> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's used on i386, >> x86_64: >> https://github.com/openjdk/jdk/blob/2

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Gerard Ziemski
On Fri, 5 Feb 2021 12:26:27 GMT, Anton Kozlov wrote: >> Marked as reviewed by ihse (Reviewer). > >> I haven't got a MacOS AArch64 system right now. Is it possible to >> enable W^X in Linux in order to kick the tyres? > > I've just got rid of asserts that fired on Linux sometime :) As for W^X lik

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread daniel . daugherty
On 2/5/21 4:51 AM, Magnus Ihse Bursie wrote: On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: support macos_aarch64 in hsdis make/autoconf/flags.m4 line 140: 138:

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v5]

2021-02-05 Thread Alexey Semenyuk
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ code from app launcher. > At startup app launcher loads launc

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v4]

2021-02-05 Thread Alexey Semenyuk
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ code from app launcher. > At startup app launcher loads launc

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v11]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-02-05 Thread Anton Kozlov
On Mon, 25 Jan 2021 22:48:50 GMT, Chris Plummer wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor CDS disabling >> - Redo builsys support for aarch64-darwin > > src/jdk.hotspot.agent/macosx/native/libsapr

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Anton Kozlov
On Fri, 5 Feb 2021 09:57:54 GMT, Magnus Ihse Bursie wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target' [v2]

2021-02-05 Thread John Paul Adrian Glaubitz
On Fri, 5 Feb 2021 10:30:56 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop -Werror > > Marked as reviewed by ihse (Reviewer). > > Apparently so. But then again all platforms excep

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target' [v2]

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 10:28:59 GMT, Aleksey Shipilev wrote: >> Configuration summary: >> * Name: linux-alpha-zero-slowdebug >> * Debug level: slowdebug >> * HS debug level: debug >> * JVM variants: zero >> * JVM features: zero: 'epsilongc g1gc jni-check jvmti management nmt >> parallelgc serialgc s

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target' [v2]

2021-02-05 Thread Aleksey Shipilev
> Configuration summary: > * Name: linux-alpha-zero-slowdebug > * Debug level: slowdebug > * HS debug level: debug > * JVM variants: zero > * JVM features: zero: 'epsilongc g1gc jni-check jvmti management nmt > parallelgc serialgc services vm-structs zero' > * OpenJDK target: OS: linux, CPU archit

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target' [v2]

2021-02-05 Thread Aleksey Shipilev
On Fri, 5 Feb 2021 10:19:18 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop -Werror > > Changes requested by ihse (Reviewer). > Apparently so. But then again all platforms except a

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target'

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 09:38:03 GMT, Aleksey Shipilev wrote: > Configuration summary: > * Name: linux-alpha-zero-slowdebug > * Debug level: slowdebug > * HS debug level: debug > * JVM variants: zero > * JVM features: zero: 'epsilongc g1gc jni-check jvmti management nmt > parallelgc serialgc services

Re: RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target'

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 09:38:03 GMT, Aleksey Shipilev wrote: > I believe the intent was to trust that every recent GCC has this option. But > this issue shows that stack-protector support is also arch-specific? Apparently so. But then again all platforms except alpha has this in recent gcc version

RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target'

2021-02-05 Thread Aleksey Shipilev
Configuration summary: * Name: linux-alpha-zero-slowdebug * Debug level: slowdebug * HS debug level: debug * JVM variants: zero * JVM features: zero: 'epsilongc g1gc jni-check jvmti management nmt parallelgc serialgc services vm-structs zero' * OpenJDK target: OS: linux, CPU architecture: alpha, a

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 09:49:11 GMT, Andrew Haley wrote: >> I reviewed bsd_aarch64.cpp digging bit deeper and left some comments. > >> > Umm, so how does patching work? We don't even know if other threads are >> > executing the code we need to patch. >> >> I thought java can handle that scenario in

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Andrew Haley
On Thu, 4 Feb 2021 23:05:56 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Magnus Ihse Bursie
On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > make/autoconf/flags.m4 line 140: > >> 138: else >> 139: MACOSX_VERS