Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v6]

2021-03-03 Thread Ioi Lam
On Mon, 1 Mar 2021 17:08:02 GMT, Yumin Qi wrote: >> Hi, Please review >> Usually most OSes are configured with page size of 4K, but some others are >> configured with 64K. If jdk binary is built on 4K platform and run on >> different configured platforms, CDS fails to be loaded due to region

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-03 Thread Anton Kozlov
On Wed, 3 Mar 2021 17:46:41 GMT, Andrew Haley wrote: > A list of the bugs that our internal testing revealed so far ... Thank you! Some of them look like test issues, but a few need more serious consideration. I want to resolve https://bugs.openjdk.java.net/browse/JDK-8262903 at least, along w

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-03 Thread Andrew Haley
On Wed, 3 Mar 2021 17:39:28 GMT, Gerard Ziemski wrote: > A list of the bugs that our internal testing revealed so far: Are any of these blockers for integration? Some of them are to do with things like features that aren't yet supported, and we can't fix what we can't see. - PR: h

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-03 Thread Gerard Ziemski
On Tue, 2 Mar 2021 11:05:20 GMT, Anton Kozlov wrote: >> For platform files that were copied from other ports to this port, if the >> file wasn't >> changed I presume the copyright years are left alone. If the file required >> changes >> for this port, I expect the year to be updated to 2021. Ho

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v5]

2021-03-03 Thread Yumin Qi
On Mon, 1 Mar 2021 13:51:39 GMT, Erik Joelsson wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add --enable-compatible-cds-alignment for linux-aarch64 and macosx-x64 in >> jib job > > Build changes look ok to me. Pin

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v23]

2021-03-03 Thread Gerard Ziemski
On Tue, 2 Mar 2021 23:21:28 GMT, David Holmes wrote: > Note that `thread` can be NULL here if the signal handler is running in a > non-attached thread. If we then perform: > `ThreadWXEnable(WXMode new_mode, Thread* thread = NULL) : _thread(thread ? > thread : Thread::current()),` > we call Thre