Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:37:07 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 35: > >> 33: #include >> 3

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 06:34:26 GMT, Thomas Stuefe wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 80: > >> 78: uli.LowPar

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Thomas Stuefe
On Mon, 8 Mar 2021 00:56:24 GMT, Yasumasa Suenaga wrote: >> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): >> >> AccessBridgeDebug.cpp >> メモ: インクルード ファイル: >> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h >> >> : >> >> c:\progra~

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Thomas Stuefe
On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov wrote: > > I wondered why C++ std headers are even used. The source code looks C-ish; > > but "8196681: Java Access Bridge logging and debug flags dynamically > > controlled" added some coding, adding a bunch of C++11x semantics and > > included

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Yasumasa Suenaga
On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov wrote: >> Yes, including c++ standard library headers like means you need to >> deal with C++ exceptions thrown from library functions, and the code needs >> to be compiled with unwind capabilities. If its not switched on, and a C++ >> exceptio

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-07 Thread Yasumasa Suenaga
> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): > > AccessBridgeDebug.cpp > メモ: インクルード ファイル: > d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h > > : > > c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\ostream(61

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]

2021-03-07 Thread Sergey Bylokhov
On Fri, 5 Feb 2021 22:00:54 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 36 additional >> commits

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]

2021-03-07 Thread Sergey Bylokhov
On Mon, 1 Mar 2021 11:17:39 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal API.

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Sergey Bylokhov
On Sun, 7 Mar 2021 19:34:36 GMT, Thomas Stuefe wrote: > I wondered why C++ std headers are even used. The source code looks C-ish; > but "8196681: Java Access Bridge logging and debug flags dynamically > controlled" added some coding, adding a bunch of C++11x semantics and > included C++ std h

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Thomas Stuefe
On Sun, 7 Mar 2021 16:19:15 GMT, Phil Race wrote: >> I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): >> >> AccessBridgeDebug.cpp >> メモ: インクルード ファイル: >> d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h >> >> : >> >> c:\progra~2\micro

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Phil Race
On Sun, 7 Mar 2021 03:18:53 GMT, Yasumasa Suenaga wrote: > I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): > > AccessBridgeDebug.cpp > メモ: インクルード ファイル: > d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h > > : > > c:\progra~2\micros~