Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]

2021-03-16 Thread Naoto Sato
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]

2021-03-16 Thread Magnus Ihse Bursie
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]

2021-03-16 Thread Claes Redestad
> This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the lookup in Character.isLowerCase/isUpperCase to a single

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups

2021-03-16 Thread Roger Riggs
On Tue, 16 Mar 2021 12:51:02 GMT, Claes Redestad wrote: > This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups

2021-03-16 Thread Erik Joelsson
On Tue, 16 Mar 2021 12:51:02 GMT, Claes Redestad wrote: > This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the

RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups

2021-03-16 Thread Claes Redestad
This patch changes the otherLowercase / otherUppercase bits to be set if either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies the lookup in Character.isLowerCase/isUpperCase to a single table

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups

2021-03-16 Thread Claes Redestad
On Tue, 16 Mar 2021 12:51:02 GMT, Claes Redestad wrote: > This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the

Integrated: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux

2021-03-16 Thread Phil Race
On Sat, 13 Mar 2021 00:15:16 GMT, Phil Race wrote: > From a build perspective this partially reverts > https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps > the harfbuzz sources separate and still supports building and running against > a system harfbuzz which is only of

Re: RFR: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux [v3]

2021-03-16 Thread Alexander Zvegintsev
On Tue, 16 Mar 2021 16:56:22 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: RFR: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux [v3]

2021-03-16 Thread Magnus Ihse Bursie
On Tue, 16 Mar 2021 16:56:22 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: RFR: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux [v2]

2021-03-16 Thread Phil Race
On Tue, 16 Mar 2021 10:38:19 GMT, Alexander Zvegintsev wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux > >

Re: RFR: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux [v3]

2021-03-16 Thread Phil Race
> From a build perspective this partially reverts > https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps > the harfbuzz sources separate and still supports building and running against > a system harfbuzz which is only of interest or relevance on Linux. > > I ended up having

Re: RFR: 8263667: Avoid running GitHub actions on branches named pr/*

2021-03-16 Thread Magnus Ihse Bursie
On Tue, 16 Mar 2021 10:53:06 GMT, Robin Westberg wrote: > When the Skara feature "dependent pull requests" is activated for the JDK > repository, branches with the name "pr/" will start to appear. These > will not be synced into personal forks by the Skara sync command, but if they > are

Re: RFR: 8263667: Avoid running GitHub actions on branches named pr/*

2021-03-16 Thread Erik Joelsson
On Tue, 16 Mar 2021 10:53:06 GMT, Robin Westberg wrote: > When the Skara feature "dependent pull requests" is activated for the JDK > repository, branches with the name "pr/" will start to appear. These > will not be synced into personal forks by the Skara sync command, but if they > are

Re: RFR: 8263667: Avoid running GitHub actions on branches named pr/*

2021-03-16 Thread Erik Helin
On Tue, 16 Mar 2021 10:53:06 GMT, Robin Westberg wrote: > When the Skara feature "dependent pull requests" is activated for the JDK > repository, branches with the name "pr/" will start to appear. These > will not be synced into personal forks by the Skara sync command, but if they > are

RFR: 8263667: Avoid running GitHub actions on branches named pr/*

2021-03-16 Thread Robin Westberg
When the Skara feature "dependent pull requests" is activated for the JDK repository, branches with the name "pr/" will start to appear. These will not be synced into personal forks by the Skara sync command, but if they are synced manually, we should avoid running GitHub actions workflows on

Re: RFR: 8255790: GTKL: Java 16 crashes on initialising GTKL on Manjaro Linux [v2]

2021-03-16 Thread Alexander Zvegintsev
On Mon, 15 Mar 2021 18:57:28 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v21]

2021-03-16 Thread Andrew Haley
On 3/15/21 6:56 PM, Anton Kozlov wrote: > On Wed, 10 Mar 2021 11:21:44 GMT, Andrew Haley wrote: > >>> We always check for `R18_RESERVED` with `#if(n)def`, is there any reason to >>> define the value for the macro? >> >> Robustness, clarity, maintainability, convention. Why not? > > I've tried