On Wed, 7 Apr 2021 22:37:28 GMT, Ioi Lam wrote:
> Many HotSpot developers make only the `hotspot` target, and copy the
> resulting `libjvm.so` into an already-build JDK image.
>
> HotSpot requires `interim-langtools` only when Graal is enabled. When Graal
> is disabled, we can avoid building
Many HotSpot developers make only the `hotspot` target, and copy the resulting
`libjvm.so` into an already-build JDK image.
HotSpot requires `interim-langtools` only when Graal is enabled. When Graal is
disabled, we can avoid building `interim-langtools`. This improves the build
time of `make
Switch to Xcode 12.4 for building macosx-x64 at Oracle. The new lldb dependency
is needed to ensure that we can collect information when testing on older
versions of macOS which do not support Xcode 12.4.
-
Commit messages:
- 8264623: Change to Xcode 12.4 for building on Macos at
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
On Wed, 7 Apr 2021 19:06:26 GMT, Daniel D. Daugherty wrote:
>> Thumbs up.
>
> Side bar: I don't quite understand the commit history part of this PR.
> It looks like this PR was used for something else before it was used
> for this fix.
@dcubed-ojdk Please just ignore the commit history. For
On Wed, 7 Apr 2021 19:03:14 GMT, Daniel D. Daugherty wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment per request from erikj79
>
> Thumbs up.
Side bar: I don't quite understand the commit history
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
On Wed, 7 Apr 2021 18:48:01 GMT, Lutz Schmidt wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> Lutz Schmidt has updated the
On Wed, 7 Apr 2021 18:11:43 GMT, Naoto Sato wrote:
>> or just "The length of the input" so that it is consistent with the
>> description of the getInputLength method.
>
> That sounds good.
Changed to "The length of the input." in the [most recent
On Wed, 7 Apr 2021 18:54:26 GMT, Conor Cleary wrote:
>> This fix addresses the following warnings which were generated by building
>> JDK API documentation with the `-Xdoclint:all` option enabled:
>>
>>
> This fix addresses the following warnings which were generated by building
> JDK API documentation with the `-Xdoclint:all` option enabled:
>
> ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java:47:
> warning: no comment
> private String
On Wed, 7 Apr 2021 18:29:31 GMT, Erik Joelsson wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> So that's where that warning
> May I please request reviews for this small build fix. It removes a linker
> warning by adding a assembly-time parameter which was previously missing. The
> same parameter is used at c++ compile time.
Lutz Schmidt has updated the pull request incrementally with one additional
commit since
On Wed, 7 Apr 2021 18:12:20 GMT, Naoto Sato wrote:
>> This makes changes to the copyright headers of of the generated source files
>> `UnsupportedCharsetException.java` and `IllegalCharsetNameException.java`.
>> These can be found under a jdk build in `support/gensrc` and the headers
>>
On Wed, 7 Apr 2021 18:13:53 GMT, Alexandre Iline wrote:
> Use a build which uses ASM bundled into JDK.
This pull request has now been integrated.
Changeset: ab3be728
Author:Alexandre Iline
URL: https://git.openjdk.java.net/jdk/commit/ab3be728
Stats: 3 lines in 1 file changed: 0
On Wed, 7 Apr 2021 18:13:53 GMT, Alexandre Iline wrote:
> Use a build which uses ASM bundled into JDK.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3380
On Wed, 7 Apr 2021 16:32:52 GMT, Lutz Schmidt wrote:
> May I please request reviews for this small build fix. It removes a linker
> warning by adding a assembly-time parameter which was previously missing. The
> same parameter is used at c++ compile time.
So that's where that warning came
Use a build which uses ASM bundled into JDK.
-
Commit messages:
- 8264863: Update JCov version to support JDK 17
Changes: https://git.openjdk.java.net/jdk/pull/3380/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3380=00
Issue:
On Wed, 7 Apr 2021 18:13:53 GMT, Alexandre Iline wrote:
> Use a build which uses ASM bundled into JDK.
@erikj79 can you take a look?
-
PR: https://git.openjdk.java.net/jdk/pull/3380
On Wed, 7 Apr 2021 18:04:48 GMT, Alan Bateman wrote:
>> It could, maybe something like "The length of the input byte (or character)
>> sequence." would work?
>
> or just "The length of the input" so that it is consistent with the
> description of the getInputLength method.
That sounds good.
On Wed, 7 Apr 2021 17:58:58 GMT, Conor Cleary wrote:
>> src/java.base/share/classes/java/nio/exceptions line 31:
>>
>>> 29: PACKAGE=java.nio
>>> 30: # This year should only change if the generated source is modified.
>>> 31: COPYRIGHT_YEARS="2000, 2021,"
>>
>> Does not seem necessary, as I
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote:
>> This fix addresses the following warnings which were generated by building
>> JDK API documentation with the `-Xdoclint:all` option enabled:
>>
>>
On Wed, 7 Apr 2021 18:01:25 GMT, Conor Cleary wrote:
>> src/java.base/share/classes/java/nio/charset/MalformedInputException.java
>> line 45:
>>
>>> 43:
>>> 44: /**
>>> 45: * The length of the input byte sequence.
>>
>> Should this comment also refer to the character sequence?
>
>
On Wed, 7 Apr 2021 16:09:22 GMT, Naoto Sato wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8264779: Simplified comments
>
> src/java.base/share/classes/java/nio/charset/MalformedInputException.java
> line 45:
>
May I please request reviews for this small build fix. It removes a linker
warning by adding a assembly-time parameter which was previously missing. The
same parameter is used at c++ compile time.
-
Commit messages:
- Update Copyright Header
- Merge branch 'JDK-8264848' of
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote:
>> This fix addresses the following warnings which were generated by building
>> JDK API documentation with the `-Xdoclint:all` option enabled:
>>
>>
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote:
>> This fix addresses the following warnings which were generated by building
>> JDK API documentation with the `-Xdoclint:all` option enabled:
>>
>>
> This fix addresses the following warnings which were generated by building
> JDK API documentation with the `-Xdoclint:all` option enabled:
>
> ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java:47:
> warning: no comment
> private String
On Wed, 7 Apr 2021 13:48:00 GMT, Alan Bateman wrote:
>> This fix addresses the following warnings which were generated by building
>> JDK API documentation with the `-Xdoclint:all` option enabled:
>>
>>
On Wed, 7 Apr 2021 13:22:44 GMT, Conor Cleary wrote:
> This fix addresses the following warnings which were generated by building
> JDK API documentation with the `-Xdoclint:all` option enabled:
>
>
On Wed, 7 Apr 2021 13:22:44 GMT, Conor Cleary wrote:
> This fix addresses the following warnings which were generated by building
> JDK API documentation with the `-Xdoclint:all` option enabled:
>
>
This fix addresses the following warnings which were generated by building JDK
API documentation with the `-Xdoclint:all` option enabled:
./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java:47:
warning: no comment
private String charsetName;
32 matches
Mail list logo
