> This patch enables ZGC on macOS/aarch64. It does three things:
> 1) Enables building of ZGC on this platform.
> 2) Adds `os::processor_id()`, which for now always returns 0.
> 3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, where the
> stackwater mark might unnecessarily process a fr
On Thu, 22 Apr 2021 04:26:11 GMT, David Holmes wrote:
>> Per Liden has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add comment to #else
>
> src/hotspot/os/bsd/os_bsd.cpp line 2149:
>
>> 2147:
>> 2148: return (uint)processor_id;
>> 21
On Thu, 22 Apr 2021 06:27:45 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
On Thu, 22 Apr 2021 06:19:19 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/dynamicArchive.hpp line 38:
>>
>>> 36: #include "utilities/resourceHash.hpp"
>>> 37:
>>> 38: #if INCLUDE_CDS
>>
>> I have to wonder who is including this file and why, if CDS is not enabled.
>
> E.g., jvm.cpp includes dy
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Thu, 22 Apr 2021 04:16:57 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - exclude all files under shared/cds if CDS is disabled;
>> compactHashtable.cpp cannot be excluded since a bit of it is us
On Thu, 22 Apr 2021 04:14:38 GMT, David Holmes wrote:
>> Thank you!
>
> I don't suppose we can just exclude the new directory rather than listing
> individual files?
Fixed. Now all files under share/cds are excluded. I needed to move
compactHashtable.cpp back to its old location since a little
On Thu, 22 Apr 2021 06:10:17 GMT, Thomas Stuefe wrote:
> Hi @iklam,
>
> this is a very welcome change!
>
> Nothing much to add to what David wrote (include guards need renaming).
>
> Apart from that, I was surprised that no gtests needed to be adapted, but
> seems cds has no gtests?
>
> I te
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 21:10:02 GMT, Per Liden wrote:
> This patch enables ZGC on macOS/aarch64. It does three things:
> 1) Enables building of ZGC on this platform.
> 2) Adds `os::processor_id()`, which for now always returns 0.
> 3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, where th
On Wed, 6 Jan 2021 06:16:43 GMT, Hao Sun wrote:
> Making the conversion explicit would fix it.
>
> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
> Therefore clang-8 and clang-9 are not affected. The flag with similar
> functionality in gcc is '-Wfloat-conversion', but i
On Wed, 21 Apr 2021 21:10:02 GMT, Per Liden wrote:
> This patch enables ZGC on macOS/aarch64. It does three things:
> 1) Enables building of ZGC on this platform.
> 2) Adds `os::processor_id()`, which for now always returns 0.
> 3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, where th
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 23:05:26 GMT, Erik Joelsson wrote:
>> make/hotspot/lib/JvmFeatures.gmk line 134:
>>
>>> 132: metaspaceShared_$(HOTSPOT_TARGET_CPU_ARCH).cpp \
>>> 133: sharedClassUtil.cpp \
>>> 134: sharedPathsMiscInfo.cpp \
>>
>> Removed obsolete files that no longer exist
On Tue, 9 Feb 2021 05:17:06 GMT, Hao Sun wrote:
>> Making the conversion explicit would fix it.
>>
>> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
>> Therefore clang-8 and clang-9 are not affected. The flag with similar
>> functionality in gcc is '-Wfloat-conversion',
On Thu, 22 Apr 2021 02:04:05 GMT, David Holmes wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use static_cast
>>
>> To match the style in this file, use static_cast to perform type
>> casting.
>
> Sorry this sli
On Wed, 21 Apr 2021 22:04:13 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 21:10:02 GMT, Per Liden wrote:
> This patch enables ZGC on macOS/aarch64. It does three things:
> 1) Enables building of ZGC on this platform.
> 2) Adds `os::processor_id()`, which for now always returns 0.
> 3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, where th
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
The number of CDS source files have grown significantly. To improve modularity,
the following files should be moved a new directory, src/hotspot/share/cds.
- src/hotspot/share/classfile/classListParser.cpp
- src/hotspot/share/classfile/classListParser.hpp
- src/hotspot/share/classfile/classListWr
This patch enables ZGC on macOS/aarch64. It does three things:
1) Enables building of ZGC on this platform.
2) Adds `os::processor_id()`, which for now always returns 0.
3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, where the
stackwater mark might unnecessarily process a frame when t
On Wed, 21 Apr 2021 14:42:39 GMT, Maurizio Cimadamore
wrote:
> Compiler changes look good (I have not checked SymbolGenerator).
>
> Why were some tests removed?
thanks for the review. The removed tests were already covered in langtools
regression tests, so I only removed duplicated tests
---
On Fri, 16 Apr 2021 03:35:06 GMT, Vicente Romero wrote:
>> Please review this PR that intents to make sealed classes a final feature in
>> Java. This PR contains compiler and VM changes. In line with similar PRs,
>> which has made preview features final, this one is mostly removing preview
>>
On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie wrote:
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> ma
On Wed, 16 Dec 2020 10:47:50 GMT, Robin Westberg wrote:
> Normally when running GitHub Actions on a pull request, what is checked out
> is the merge of the pull request with the latest changes on the target
> branch. This ensure that what is tested is as close as possible to what will
> actual
On Tue, 9 Feb 2021 05:17:06 GMT, Hao Sun wrote:
>> Making the conversion explicit would fix it.
>>
>> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
>> Therefore clang-8 and clang-9 are not affected. The flag with similar
>> functionality in gcc is '-Wfloat-conversion',
On Fri, 16 Apr 2021 11:57:32 GMT, Aleksey Shipilev wrote:
> After [JDK-8257913](https://bugs.openjdk.java.net/browse/JDK-8257913), we do
> not need to set a whole lot of options for cross-compiled builds. Docs should
> be updated to reflect that fact. Also put in more configurations that are
>
On Fri, 16 Apr 2021 11:57:32 GMT, Aleksey Shipilev wrote:
> After [JDK-8257913](https://bugs.openjdk.java.net/browse/JDK-8257913), we do
> not need to set a whole lot of options for cross-compiled builds. Docs should
> be updated to reflect that fact. Also put in more configurations that are
>
On Sun, 18 Apr 2021 17:33:56 GMT, John Paul Adrian Glaubitz
wrote:
>> After [JDK-8257913](https://bugs.openjdk.java.net/browse/JDK-8257913), we do
>> not need to set a whole lot of options for cross-compiled builds. Docs
>> should be updated to reflect that fact. Also put in more configuration
On Sun, 18 Apr 2021 17:33:56 GMT, John Paul Adrian Glaubitz
wrote:
>> After [JDK-8257913](https://bugs.openjdk.java.net/browse/JDK-8257913), we do
>> not need to set a whole lot of options for cross-compiled builds. Docs
>> should be updated to reflect that fact. Also put in more configuration
32 matches
Mail list logo
