On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
This pull request makes node selection more visible.
At present when selecting node, node name is bolder. In addition to that,
thickness of the border is bolder after applying this code.
I tested manually. Here are the images that I took before and after applying
this patch as follows.
### Aft
On Wed, 2 Jun 2021 00:19:56 GMT, Jonathan Gibbons wrote:
>> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
>> probably need to check `realpath` availability in idea.sh and suggest
>> installing `coreutils` if it's not available
>
> @YaaZ I'm aware of the workaround, but t
On Tue, 1 Jun 2021 22:20:25 GMT, Nikita Gubarkov
wrote:
>> The fix fails on a Mac, where `realpath` is not available by default.
>
> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
> probably need to check `realpath` availability in idea.sh and suggest
> installing `coreu
On Tue, 1 Jun 2021 22:10:41 GMT, Jonathan Gibbons wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> The fix fails on a Mac, where `realpath` is not availa
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
On Tue, 1 Jun 2021 07:50:49 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
On Mon, 24 May 2021 14:03:45 GMT, Maxim Kartashev
wrote:
> This commit adds the `-fno-delete-null-pointer-checks` compiler option to
> clang builds, which is going to become necessary starting from clang version
> 12.0.0 (see the [bug
> report](https://bugs.openjdk.java.net/browse/JDK-8265431
On Tue, 1 Jun 2021 13:23:49 GMT, Erik Joelsson wrote:
>> This commit adds the `-fno-delete-null-pointer-checks` compiler option to
>> clang builds, which is going to become necessary starting from clang version
>> 12.0.0 (see the [bug
>> report](https://bugs.openjdk.java.net/browse/JDK-8265431
On Mon, 24 May 2021 14:03:45 GMT, Maxim Kartashev
wrote:
> This commit adds the `-fno-delete-null-pointer-checks` compiler option to
> clang builds, which is going to become necessary starting from clang version
> 12.0.0 (see the [bug
> report](https://bugs.openjdk.java.net/browse/JDK-8265431
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Tue, 1 Jun 2021 13:23:49 GMT, Erik Joelsson wrote:
> I left a comment in the bug that you haven't answered.
Sorry, don't have write access to the bug.
To answer your comment
> You seem to be mixing up -fno-delete-null-pointer-checks and
> -fdelete-null-pointer-checks between the descriptio
On Mon, 24 May 2021 14:03:45 GMT, Maxim Kartashev
wrote:
> This commit adds the `-fno-delete-null-pointer-checks` compiler option to
> clang builds, which is going to become necessary starting from clang version
> 12.0.0 (see the [bug
> report](https://bugs.openjdk.java.net/browse/JDK-8265431
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
>
> A
18 matches
Mail list logo
