Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

2021-06-07 Thread ScientificWare
On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare wrote: > This concerns [dtdbuilder > tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). > > In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. > > So, in `DTDBuilder.java`

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3]

2021-06-07 Thread Jatin Bhateja
On Tue, 8 Jun 2021 00:30:38 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to

Re: RFR: 8265440: IGV: make node selection more visible

2021-06-07 Thread Koichi Sakata
On Wed, 2 Jun 2021 06:22:44 GMT, Koichi Sakata wrote: > This pull request makes node selection more visible. > > At present when selecting node, node name is bolder. In addition to that, > thickness of the border is bolder after applying this code. > > I tested manually. Here are the images

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3]

2021-06-07 Thread Scott Gibbons
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to > accept an additional parameter (isMIME) for fast-path MIME

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v2]

2021-06-07 Thread Corey Ashford
On Tue, 8 Jun 2021 00:11:42 GMT, Scott Gibbons wrote: >> src/java.base/share/classes/java/util/Base64.java line 813: >> >>> 811: while (sp < sl) { >>> 812: if (shiftto == 18 && sp < sl - 4) { // fast path >>> 813: int dl = decodeBlock(src,

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v2]

2021-06-07 Thread Scott Gibbons
On Mon, 7 Jun 2021 22:34:33 GMT, Corey Ashford wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update full name > > src/java.base/share/classes/java/util/Base64.java line 813: > >> 811: while (sp <

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v2]

2021-06-07 Thread Corey Ashford
On Mon, 7 Jun 2021 13:20:20 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

2021-06-07 Thread Iris Clark
On Mon, 7 Jun 2021 19:38:58 GMT, Joe Darcy wrote: >> 8267630: Start of release updates for JDK 18 > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:53:55 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > >

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 15:27:21 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8263468 >> - JDK-8263468: automate build

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:52:57 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > >

Re: RFR: JDK-8263468: New page for "recent" new API [v4]

2021-06-07 Thread Hannes Wallnöfer
> This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively minor thanks to the existing > infrastructure for summary

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

2021-06-07 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last

Integrated: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-07 Thread Liam Miller-Cushon
On Sun, 6 Jun 2021 20:09:32 GMT, Liam Miller-Cushon wrote: > This change fixes a build error during the generation of > `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` > instead of `cp a b` to avoid propagating the permissions to the generated > source. This

Re: RFR: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

2021-06-07 Thread Erik Joelsson
On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov wrote: > I got rid of `realpath` usage as discussed in > https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro > instead, however there were quite a few problems with this macro, here's the > example: > > $(call

Integrated: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Joe Darcy
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > >

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Jonathan Gibbons
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > >

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 15:46:45 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8263468 >> - JDK-8263468: automate build

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 15:00:43 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Jonathan Gibbons
On Fri, 28 May 2021 08:19:33 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are

Re: RFR: 8268327: Upstream: 8268169: The system lookup can not find stdio functions such as printf on Windows 10

2021-06-07 Thread Athijegannathan Sundararajan
On Mon, 7 Jun 2021 13:23:46 GMT, Jorn Vernee wrote: > Hi, > > The documentation of `CLinker::systemLookup` [1] says this: > > > * Obtains a system lookup which is suitable to find symbols in the standard C > libraries. > > > However, currently it is not possible to look up common stdio.h

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
> This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively minor thanks to the existing > infrastructure for summary

Integrated: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-07 Thread Weijun Wang
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

Re: RFR: 8268327: Upstream: 8268169: The system lookup can not find stdio functions such as printf on Windows 10

2021-06-07 Thread Erik Joelsson
On Mon, 7 Jun 2021 13:23:46 GMT, Jorn Vernee wrote: > Hi, > > The documentation of `CLinker::systemLookup` [1] says this: > > > * Obtains a system lookup which is suitable to find symbols in the standard C > libraries. > > > However, currently it is not possible to look up common stdio.h

RFR: 8268327: Upstream: 8268169: The system lookup can not find stdio functions such as printf on Windows 10

2021-06-07 Thread Jorn Vernee
Hi, The documentation of `CLinker::systemLookup` [1] says this: * Obtains a system lookup which is suitable to find symbols in the standard C libraries. However, currently it is not possible to look up common stdio.h symbols, such as `printf`, using the system lookup on Windows 10. This is

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v2]

2021-06-07 Thread Scott Gibbons
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to > accept an additional parameter (isMIME) for fast-path MIME

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Erik Joelsson
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > >

Re: RFR: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-07 Thread Erik Joelsson
On Sun, 6 Jun 2021 20:09:32 GMT, Liam Miller-Cushon wrote: > This change fixes a build error during the generation of > `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` > instead of `cp a b` to avoid propagating the permissions to the generated > source. Looks

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512

2021-06-07 Thread Erik Joelsson
On Fri, 4 Jun 2021 20:55:51 GMT, Scott Gibbons wrote: > Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

Integrated: 8262891: Compiler implementation for Pattern Matching for switch (Preview)

2021-06-07 Thread Jan Lahoda
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote: > This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: >