Re: RFR: 8269760: idea.sh should not invoke cygpath directly

2021-07-01 Thread Maurizio Cimadamore
On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking > `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to > something else, such as `wslpath`. >

Re: RFR: 8269758: idea.sh doesn't work when there are multiple configurations available.

2021-07-01 Thread Maurizio Cimadamore
On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, > when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given,

Re: RFR: 8269760: idea.sh should not invoke cygpath directly

2021-07-01 Thread Jorn Vernee
On Thu, 1 Jul 2021 16:06:47 GMT, Maurizio Cimadamore wrote: > Not an expert on the value of these variables My own line of thought is that it is reasonable to expect that anything found in the `CYGPATH` variable is fine to treat as if it were `cygpath` like this (this could be an alternative

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL

2021-07-01 Thread Maurizio Cimadamore
On Thu, 1 Jul 2021 15:02:03 GMT, Jorn Vernee wrote: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this > results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such > file or directory > > Adding

RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL

2021-07-01 Thread Jorn Vernee
>From the JBS issue: At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory Adding a .exe suffix to the javac path fixes this issue, which can be done ju

RFR: 8269760: idea.sh should not invoke cygpath directly

2021-07-01 Thread Jorn Vernee
>From the JBS issue: Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. Instead of invoking `cygpath` directly, the value of the `CYGPATH` va

RFR: 8269758: idea.sh doesn't work when there are multiple configurations available.

2021-07-01 Thread Jorn Vernee
>From the JBS issue: The idea.sh script invokes `make`, but doesn't specify a configuration. So, when multiple configurations are present, this results in an error like this: $ bash bin/idea.sh java.base Error: No CONF given, but more than one configuration found. Available configurations in /m

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-07-01 Thread Aleksey Shipilev
Hi Matthias, On 7/1/21 1:28 PM, Matthias Klose wrote: what's the status of this? Trying to run the tests for 17+29 using jtreg 6+1, I get: I saw a similar problem with some custom jtreg builds. IIRC, that happens when jtreg6 source is built with "old" make/build-all.sh, not with the new "mak

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-07-01 Thread Matthias Klose
On 6/2/21 6:25 PM, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated