RFR: 8275569: Add linux-aarch64 to test-make profiles

2021-10-20 Thread Mikhailo Seledtsov
Please review this trivial change that adds "linux-aarch64" to test make profile. - Commit messages: - Add linux-aarch64 to test make profile Changes: https://git.openjdk.java.net/jdk/pull/6051/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6051&range=00 Issue: http

Re: RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-20 Thread Mikhailo Seledtsov
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds the linux-aarch64 zero build > profile. Thanks for review. I have removed the extra brackets and re-tested. - PR: https://git.openjdk.java.net/jdk/pull/6024

Integrated: 8275449: Add linux-aarch64-zero build profile

2021-10-20 Thread Mikhailo Seledtsov
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds the linux-aarch64 zero build > profile. This pull request has now been integrated. Changeset: 0021a2f4 Author:Mikhailo Seledtsov URL: https://git.openjdk.java.net/jdk/commit/002

Re: RFR: 8275449: Add linux-aarch64-zero build profile [v2]

2021-10-20 Thread Mikhailo Seledtsov
> Please review this small change that adds the linux-aarch64 zero build > profile. Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision: Removing extra brackets per review feedback - Changes: - all: https://git.openj

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI [v2]

2021-10-20 Thread Pavel Rappo
On Wed, 20 Oct 2021 10:18:24 GMT, Hannes Wallnöfer wrote: >> test/langtools/jdk/javadoc/lib/javadoc/tester/LinkChecker.java line 354: >> >>> 352: void addReference(String name, Path from, int line) { >>> 353: if (checked) { >>> 354: if (name != null && !name.i

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI [v2]

2021-10-20 Thread Pavel Rappo
On Wed, 20 Oct 2021 10:15:39 GMT, Hannes Wallnöfer wrote: >> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java line >> 214: >> >>> 212: >> class="element-name">case%s() >>> 213: >>> 214: >> class="snippe

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v8]

2021-10-20 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI [v2]

2021-10-20 Thread Hannes Wallnöfer
> Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~hannesw/8275406/api.00/java.base/java/lang/Throwable.html#printStackTrace()

Re: RFR: 8275405: Linking error for classes with lambda template parameters and virtual functions [v2]

2021-10-20 Thread Per Liden
On Wed, 20 Oct 2021 12:23:28 GMT, Stefan Karlsson wrote: >> We encountered the following linking error when trying to build Generational >> ZGC on Windows: >> >> jvm.exp : error LNK2001: unresolved external symbol "const >> ZBasicOopIterateClosure >> >::`vftable'" >> (??_7?$ZBasicOopIterateC

Re: RFR: 8275405: Linking error for classes with lambda template parameters and virtual functions [v2]

2021-10-20 Thread Stefan Karlsson
> We encountered the following linking error when trying to build Generational > ZGC on Windows: > > jvm.exp : error LNK2001: unresolved external symbol "const > ZBasicOopIterateClosure > >::`vftable'" > (??_7?$ZBasicOopIterateClosure@V6B@) > > > I narrowed this down to a simple reproduc

Integrated: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-20 Thread Harold Seigel
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote: > Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows > fastdebug builds. The change was tested by running Mach5 tiers 1-6 on > Windows-x64-debug. > > Thanks, Harold This pull request has now been integrated. Chan

Re: RFR: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-20 Thread Harold Seigel
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote: > Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows > fastdebug builds. The change was tested by running Mach5 tiers 1-6 on > Windows-x64-debug. > > Thanks, Harold Thanks David and Erik! - PR: https

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v7]

2021-10-20 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2021-10-20 Thread Magnus Ihse Bursie
On Tue, 19 Oct 2021 04:47:52 GMT, Nick Gasson wrote: >> This patch expands the newly added system for hsdis backends to include LLVM. >> >> The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, >> as published in the never integrated PR >> https://github.com/openjdk/jdk/p

Re: RFR: 8275405: Linking error for classes with lambda template parameters and virtual functions

2021-10-20 Thread Magnus Ihse Bursie
On Wed, 20 Oct 2021 08:11:34 GMT, Stefan Karlsson wrote: > We encountered the following linking error when trying to build Generational > ZGC on Windows: > > jvm.exp : error LNK2001: unresolved external symbol "const > ZBasicOopIterateClosure > >::`vftable'" > (??_7?$ZBasicOopIterateClosure@

Re: RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-20 Thread Magnus Ihse Bursie
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds the linux-aarch64 zero build > profile. Changes requested by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6024

Re: RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-20 Thread Magnus Ihse Bursie
On Wed, 20 Oct 2021 00:10:14 GMT, Erik Joelsson wrote: >> Please review this small change that adds the linux-aarch64 zero build >> profile. > > make/autoconf/lib-ffi.m4 line 152: > >> 150: AC_MSG_ERROR([Could not locate libffi.so.? for bundling]) >> 151: fi >> 152:

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-20 Thread Magnus Ihse Bursie
On Wed, 20 Oct 2021 09:28:30 GMT, Leslie Zhai wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> upgrade the version in GHA config >> >> only in patch2: >> unchanged: > > Hi @wangweij > > But how to be suitabl

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-20 Thread Hannes Wallnöfer
On Tue, 19 Oct 2021 16:14:37 GMT, Pavel Rappo wrote: >> Please review a change to add a copy-to-clipboard feature to snippets. I >> took special care to make the feature usable on mobile devices. Sample >> output can be viewed and tested here: >> >> http://cr.openjdk.java.net/~hannesw/8275406/

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-20 Thread Leslie Zhai
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

RFR: 8275405: Linking error for classes with lambda template parameters and virtual functions

2021-10-20 Thread Stefan Karlsson
We encountered the following linking error when trying to build Generational ZGC on Windows: jvm.exp : error LNK2001: unresolved external symbol "const ZBasicOopIterateClosure >::`vftable'" (??_7?$ZBasicOopIterateClosure@V6B@) I narrowed this down to a simple reproducer, which doesn't li