RFR: 8278885: Remove Windows ARM64 int8_t workaround in G1

2022-01-12 Thread aamarsh
Please review this small change to revert a previous workaround that avoided an MSVC issue. This issue has now been fixed in VS 16.8 and higher. I also updated some documentation to reflect this change. - Commit messages: - reverted windows/aarch64 workaround and added to

RFR: 8279315: Add Git support to update_copyright_year.sh script

2022-01-12 Thread Dmitry Kulikov
Modified the `make/scripts/update_copyright_year.sh` script to support Git as well as Mercurial, as per [JDK-8279315](https://bugs.openjdk.java.net/browse/JDK-8279315). Also added the ability to specify company name as a command line argument instead of being hard-coded into the script.

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-12 Thread Markus Grönlund
On Wed, 12 Jan 2022 15:18:46 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK  >> >> ### Implementation notes and alternatives considered >> >> After

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 14:46:54 GMT, Daniel Jelinski wrote: >> Currently the information about using IDEA can only be found on mailing >> lists. >> >> Additionally fixed the documentation for Visual Studio; the target >> `ide-project` does not exist. > > Daniel Jelinski has updated the pull

Integrated: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-12 Thread Naoto Sato
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. This pull request has now been integrated. Changeset: 0a094d7c Author:Naoto Sato URL:

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Daniel Jelinski
On Wed, 12 Jan 2022 18:08:51 GMT, Lance Andersen wrote: > Not sure if you want to refer to the idea.sh -h for additional options I'm not sure about that either. These options are usually not required, and the -h output leaves something to be desired. I'd rather keep the current version, and

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-12 Thread Kevin Rushforth
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. The CSR is now approved. This comment should be sufficient to wake up the bot. -

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2022-01-12 Thread Saint Wesonga
On Wed, 17 Nov 2021 13:17:21 GMT, Magnus Ihse Bursie wrote: >> This patch expands the newly added system for hsdis backends to include LLVM. >> >> The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, >> as published in the never integrated PR >>

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 14:46:54 GMT, Daniel Jelinski wrote: >> Currently the information about using IDEA can only be found on mailing >> lists. >> >> Additionally fixed the documentation for Visual Studio; the target >> `ide-project` does not exist. > > Daniel Jelinski has updated the pull

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v11]

2022-01-12 Thread Andrew Dinn
On Wed, 12 Jan 2022 17:08:34 GMT, Alan Hayward wrote: > Is it worth holding this patch up for those fixes? Probably. It depends on exactly what is failing. Can you provide more info? - PR: https://git.openjdk.java.net/jdk/pull/6334

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v11]

2022-01-12 Thread Alan Hayward
On Tue, 14 Dec 2021 09:40:03 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Erik Joelsson
On Wed, 12 Jan 2022 14:46:54 GMT, Daniel Jelinski wrote: >> Currently the information about using IDEA can only be found on mailing >> lists. >> >> Additionally fixed the documentation for Visual Studio; the target >> `ide-project` does not exist. > > Daniel Jelinski has updated the pull

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-12 Thread Tyler Steele
> Just in time for the holidays I have completed an implementation of the JFR > functionality for AIX. As a side note, this is my first submission to OpenJDK >  > > ### Implementation notes and alternatives considered > > After modifying the build system to allow the --enable-jvm-feature-jfr

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Daniel Jelinski
On Wed, 12 Jan 2022 07:29:33 GMT, Daniel Jelinski wrote: > Currently the information about using IDEA can only be found on mailing lists. > > Additionally fixed the documentation for Visual Studio; the target > `ide-project` does not exist. Thanks for all your suggestions. Let me know if the

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Daniel Jelinski
> Currently the information about using IDEA can only be found on mailing lists. > > Additionally fixed the documentation for Visual Studio; the target > `ide-project` does not exist. Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Erik Joelsson
On Wed, 12 Jan 2022 07:29:33 GMT, Daniel Jelinski wrote: > Currently the information about using IDEA can only be found on mailing lists. > > Additionally fixed the documentation for Visual Studio; the target > `ide-project` does not exist. Added some suggestions on language. doc/ide.md line

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Erik Joelsson
On Wed, 12 Jan 2022 12:17:02 GMT, Lance Andersen wrote: > > > (...) As far as I am aware, the ide.html should be generated from the > > > ide.md so you should only need to modify ide.md > > > > > > Are you sure about this? The discussion on #5676 suggests that the HTML > > files need to be

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 12:10:50 GMT, Daniel Jelinski wrote: > > (...) As far as I am aware, the ide.html should be generated from the > > ide.md so you should only need to modify ide.md > > Are you sure about this? The discussion on #5676 suggests that the HTML files > need to be modified. > >

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Daniel Jelinski
On Wed, 12 Jan 2022 11:55:39 GMT, Lance Andersen wrote: > (...) As far as I am aware, the ide.html should be generated from the ide.md > so you should only need to modify ide.md Are you sure about this? The discussion on #5676 suggests that the HTML files need to be modified. I wouldn't mind

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 07:29:33 GMT, Daniel Jelinski wrote: > Currently the information about using IDEA can only be found on mailing lists. > > Additionally fixed the documentation for Visual Studio; the target > `ide-project` does not exist. Thank you for taking a stab at this. As far as I am

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

2022-01-12 Thread Martin Doerr
On Tue, 11 Jan 2022 16:53:05 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK  >> >> ### Implementation notes and alternatives considered >> >> After