On Tue, 18 Jan 2022 23:09:12 GMT, Liam Miller-Cushon wrote:
> Update links to the chromium style guide in the HotSpot Style Guide.
This pull request has now been integrated.
Changeset: dac15efc
Author:Liam Miller-Cushon
URL:
https://git.openjdk.java.net/jdk/commit/dac15efc1be8fe49d2
On Tue, 18 Jan 2022 15:23:42 GMT, Thomas Stuefe wrote:
>> Tyler Steele has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into JDK-8203290
>> - Clean up & testing
>>
>>- Run JFR t
On Fri, 14 Jan 2022 13:45:51 GMT, Daniel Jelinski wrote:
> Backslashes in `sed` replacement string are interpreted by `sed`. In order to
> output the strings we want, the replacement text needs to be escaped again.
> See https://stackoverflow.com/a/2705678
>
> Verified that with this patch VSC
On Fri, 14 Jan 2022 14:32:00 GMT, Erik Joelsson wrote:
>> Backslashes in `sed` replacement string are interpreted by `sed`. In order
>> to output the strings we want, the replacement text needs to be escaped
>> again. See https://stackoverflow.com/a/2705678
>>
>> Verified that with this patch
On Tue, 18 Jan 2022 23:09:12 GMT, Liam Miller-Cushon wrote:
> Update links to the chromium style guide in the HotSpot Style Guide.
Looks good. Thanks for noticing the problem and fixing it.
David
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pul
