Re: RFR: JDK-8236128: Allow jpackage create installers for services

2022-03-14 Thread Alexander Matveev
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR Marked as reviewed by almatvee (Reviewer). - PR:

Re: RFR: 8282507: Add a separate license file for hsdis [v2]

2022-03-14 Thread Man Cao
On Mon, 14 Mar 2022 22:27:29 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone help review the addition of LICENSE file to hsdis directory? >> >> -Man > > Man Cao has updated the pull request incrementally with one additional commit > since the last revision: > > Rename license file to

Re: RFR: 8282507: Add LICENSE file for hsdis [v2]

2022-03-14 Thread Man Cao
> Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Man Cao has updated the pull request incrementally with one additional commit since the last revision: Rename license file to hsdis-license.txt - Changes: - all:

Re: RFR: 8253495: CDS generates non-deterministic output [v6]

2022-03-14 Thread Calvin Cheung
On Fri, 11 Mar 2022 06:55:23 GMT, Ioi Lam wrote: >> This patch makes the result of "java -Xshare:dump" deterministic: >> - Disabled new Java threads from launching. This is harmless. See comments >> in jvm.cpp >> - Fixed a problem in hashtable ordering in heapShared.cpp >> - BasicHashtableEntry

Integrated: 8283062: Uninitialized warnings in libgtest with GCC 11.2

2022-03-14 Thread Mikael Vidstedt
On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt wrote: > Background, from JBS: > > In file included from > googletest-release-1.8.1/googletest/src/gtest-all.cc:42: > googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function > 'bool testing::internal::StackGrowsDown()': >

Re: Supporting alternative toolchains on Windows

2022-03-14 Thread erik . joelsson
On 2022-03-11 23:17, Julian Waters wrote: I meant in toolchain.m4, which allows gcc for macOS Apple used to ship GCC as part of Xcode, and the original Mac port of OpenJDK used that GCC. This was eventually removed from Xcode and the OpenJDK build was changed to use Clang instead. To make

Re: RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2

2022-03-14 Thread Erik Joelsson
On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt wrote: > Background, from JBS: > > In file included from > googletest-release-1.8.1/googletest/src/gtest-all.cc:42: > googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function > 'bool testing::internal::StackGrowsDown()': >

Integrated: 8283017: GHA: Workflows break with update release versions

2022-03-14 Thread Aleksey Shipilev
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For example, in JDK 18u

Re: RFR: 8283017: GHA: Workflows break with update release versions

2022-03-14 Thread Aleksey Shipilev
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For example, in JDK 18u