On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 17:34:18 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>
>> 16: *
>> 17: * You should have
On Wed, 23 Mar 2022 01:57:25 GMT, Fei Yang wrote:
>> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>>
>>> 16: *
>>> 17: * You should have received a copy of the GNU General Public License
>>> version
>>> 18: * 2 along with this work; if not, write to the Free Software
>>> Foundation
On Tue, 22 Mar 2022 14:01:28 GMT, Roger Riggs wrote:
> The test/jdk files look ok. (I didn't look at the rest)
Thank you for looking at that part.
-
PR: https://git.openjdk.java.net/jdk/pull/6294
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests a
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote:
> Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
> which is used by libsplashscreen.
>
> Policy is not to change the upstream code locally unless it is also changed
> in the same way upstream.
> We could consider r
On Tue, 22 Mar 2022 19:07:12 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote:
> Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
> which is used by libsplashscreen.
>
> Policy is not to change the upstream code locally unless it is also changed
> in the same way upstream.
> We could consider r
On Tue, 22 Mar 2022 15:20:38 GMT, Daniel Jeliński wrote:
> Sample output after the changes:
>
> [Stub Code]
> 0x01cd0a937e20: nopl (%rax, %rax); {no_reloc}
> 0x01cd0a937e25: movabsq $0x0, %rbx ;
> {static_stub}
> 0x01cd0a937e2f:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
which is used by libsplashscreen.
Policy is not to change the upstream code locally unless it is also changed in
the same way upstream.
We could consider reporting it upstream but libpng releases are very infrequent.
--
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 14:04:07 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
Sample output after the changes:
[Stub Code]
0x01cd0a937e20: nopl(%rax, %rax); {no_reloc}
0x01cd0a937e25: movabsq $0x0, %rbx ; {static_stub}
0x01cd0a937e2f: jmp 0x1cd0a937e2f ; {runtime_call}
[Exception Handler]
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Mon, 21 Mar 2022 17:36:53 GMT, Maurizio Cimadamore
wrote:
>> make/modules/java.base/Lib.gmk line 217:
>>
>>> 215: CXXFLAGS := $(CXXFLAGS_JDKLIB), \
>>> 216: LDFLAGS := $(LDFLAGS_JDKLIB) -Wl$(COMMA)--no-as-needed, \
>>> 217: LIBS := $(LIBCXX) -lc -lm -ldl, \
>>
>> Instead o
On Tue, 22 Mar 2022 12:08:01 GMT, Fei Yang wrote:
>> make/autoconf/libraries.m4 line 152:
>>
>>> 150: fi
>>> 151:
>>> 152: # Programs which use C11 or C++11 atomics, like #include ,
>>
>> Use of C++ atomics is not allowed in hotspot code base. See the style guide:
>> https://github.com/ope
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 04:13:17 GMT, David Holmes wrote:
>> Fei Yang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> sinc
On Tue, 22 Mar 2022 05:12:46 GMT, David Holmes wrote:
> Hi,
>
> I've looked at everything that is not a RISC-V specific file, except for the
> C1 changes as the compiler folk will need to approve those.
>
> Some copyrights will need updating to 2022 on the Oracle copyright line
> please.
Hi
On Tue, 22 Mar 2022 03:31:16 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests a
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
25 matches
Mail list logo
