Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v2]

2022-04-06 Thread Alan Bateman
On Thu, 7 Apr 2022 00:56:42 GMT, Tim Prinzing wrote: >> Created a test called NullCallerGetResource to test >> Module::getResourceAsStream and Class::getResourceAsStream from the native >> level. >> >> At the java level the test builds a test module called 'n' which opens the >> package

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v2]

2022-04-06 Thread Tim Prinzing
> Created a test called NullCallerGetResource to test > Module::getResourceAsStream and Class::getResourceAsStream from the native > level. > > At the java level the test builds a test module called 'n' which opens the > package 'open' to everyone. There is also a package 'closed' which is

RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null

2022-04-06 Thread Tim Prinzing
Created a test called NullCallerGetResource to test Module::getResourceAsStream and Class::getResourceAsStream from the native level. At the java level the test builds a test module called 'n' which opens the package 'open' to everyone. There is also a package 'closed' which is neither opened

Integrated: 8284437: Building from different users/workspace is not always deterministic

2022-04-06 Thread Andrew Leonard
On Wed, 6 Apr 2022 10:27:40 GMT, Andrew Leonard wrote: > This PR fixes the non-deterministic behavior when building on linux with > different userids or within > different workspace folders. > It fixes the following issues: > - MakeZipReproducible.java used to produce reproducible src.zip

Integrated: 8277517: Bump minimum boot jdk to JDK 18

2022-04-06 Thread Mikael Vidstedt
On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds This pull request has now been integrated. Changeset: 46ce2ef1 Author:Mikael Vidstedt URL:

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-06 Thread Andrew Leonard
> This PR fixes the non-deterministic behavior when building on linux with > different userids or within > different workspace folders. > It fixes the following issues: > - MakeZipReproducible.java used to produce reproducible src.zip removes the > optional zip "extra" field containing UID/GID.

Re: RFR: 8284437: Building from different users/workspace is not always deterministic

2022-04-06 Thread Erik Joelsson
On Wed, 6 Apr 2022 10:27:40 GMT, Andrew Leonard wrote: > This PR fixes the non-deterministic behavior when building on linux with > different userids or within > different workspace folders. > It fixes the following issues: > - MakeZipReproducible.java used to produce reproducible src.zip

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer [v2]

2022-04-06 Thread Aleksey Shipilev
On Wed, 6 Apr 2022 11:12:39 GMT, Christoph Langer wrote: >> Make cygwin usage in GHA more reliable >> >> With this change we now attempt to retrieve the cygwin installer from cache >> every time we need it. >> We would also only try to download it once per build job, in the beginning. >>

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer [v2]

2022-04-06 Thread Christoph Langer
> Make cygwin usage in GHA more reliable > > With this change we now attempt to retrieve the cygwin installer from cache > every time we need it. > We would also only try to download it once per build job, in the beginning. > During testing we rely on it being cached which will make potential

RFR: 8284437: Building from different users/workspace is not always deterministic

2022-04-06 Thread Andrew Leonard
This PR fixes the non-deterministic behavior when building on linux with different userids or within different workspace folders. It fixes the following issues: - MakeZipReproducible.java used to produce reproducible src.zip removes the optional zip "extra" field containing UID/GID. - When

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

2022-04-06 Thread Christoph Langer
On Wed, 6 Apr 2022 07:40:41 GMT, Aleksey Shipilev wrote: > Let's not switch `v2` -> `v3` in this PR. You're right. I'll do another PR to update the actions versions. There are also updates possible for upload and donwload actions. > So `windows_aarch64_build`, `windows_x64_build` checks the

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

2022-04-06 Thread Aleksey Shipilev
On Tue, 5 Apr 2022 20:57:45 GMT, Christoph Langer wrote: > Make cygwin usage in GHA more reliable > > With this change we now attempt to retrieve the cygwin installer from cache > every time we need it. > We would also only try to download it once per build job, in the beginning. > During