On Thu, 14 Apr 2022 16:13:59 GMT, Andrew Leonard wrote:
> JDK-8282769 added support for more ISO-8601 formats, but remove handling of
> just a date "-MM-DD" being present, which is the case for a configure
> using --with-source-date=version which uses the date string from
>
> Implementation of [JDK-8275062: "Allow jpackage create installers for
> services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
> CSR
Alexey Semenyuk has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 121 commits:
- Merge
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A
On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang wrote:
>I found [yet another
>typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948),
> I wonder if you can merge this into your patch so that I do not need to
>submit a new PR for it? Thanks.
I think it deserves a
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
This pull request has now been integrated.
Changeset: 48c75498
Author:Andrey Turbanov
URL:
On 06:25 Wed 13 Apr , Langer, Christoph wrote:
> Hi Andrew,
>
> > > > One dummy question:
> > > > Why do we need to specify the real package name here?
> > > > If we install gcc-10, I think apt system will pick up the latest gcc-10
> > > > for us.
> > >
> > > IIRC the intent is to keep
On 12:57 Wed 13 Apr , Magnus Ihse Bursie wrote:
> I disagree completely. We had it this way in mainline originally, but it
> was fixed in https://bugs.openjdk.java.net/browse/JDK-8256393.
>
Prior to this patch, it seems there were no GCC version requirements.
That's not what I'm suggesting.
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>
On Thu, 14 Apr 2022 16:13:59 GMT, Andrew Leonard wrote:
> JDK-8282769 added support for more ISO-8601 formats, but remove handling of
> just a date "-MM-DD" being present, which is the case for a configure
> using --with-source-date=version which uses the date string from
>
JDK-8282769 added support for more ISO-8601 formats, but remove handling of
just a date "-MM-DD" being present, which is the case for a configure using
--with-source-date=version which uses the date string from version-numbers.conf.
Also, the first date parse had an invalid format string
I ran `codespell` on the `make` directory, and accepted those changes where it
indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
Most of the fixes are in comments. A few are in messages aimed at the user.
-
Commit messages:
-
> This patch examines and optimizes `Wrapper` lookups.
>
> First wrote a few simple microbenchmarks to verify there are actual speedups
> from using perfect hash tables in `sun.invoke.util.Wrapper` compared to
> simpler lookup mechanisms (such as if-else or switch). Turns out there _is_ a
>
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853:
On Thu, 14 Apr 2022 12:07:06 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On 2022-04-14 04:15, Julian Waters wrote:
Hi Magnus,
> So this is only in @-files?
> Sounds like it could be a newline issue then. (CR/LF vs LF) Is this in
> cygwin?
> Have you checked if "make doctor" finds autocrlf issues?
Yes, it only happens when files containing commands are tagged as
On Thu, 14 Apr 2022 11:19:04 GMT, Claes Redestad wrote:
> This patch examines and optimizes `Wrapper` lookups.
>
> First wrote a few simple microbenchmarks to verify there are actual speedups
> from using perfect hash tables in `sun.invoke.util.Wrapper` compared to
> simpler lookup mechanisms
On Thu, 14 Apr 2022 12:00:56 GMT, Andrew Leonard wrote:
>> @mkartashev thanks. So at the moment we are only using this assembly header
>> for gcc tooling, see NativeCompliation.gmk change.
>> So maybe I change this to specifically state gcc and it's effect on linux
>> debuginfo ?
>
> updated
On Thu, 14 Apr 2022 11:13:20 GMT, Andrew Leonard wrote:
>> make/data/autoheaders/assemblyprefix.h line 25:
>>
>>> 23:
>>> 24: // ASSEMBLY_SRC_FILE gets replaced by relative or absolute file path
>>> 25: // in NativeCompilation.gmk, this ensures reproducible .debuginfo
>>
>> Actually, this
On Wed, 13 Apr 2022 13:55:59 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
This patch examines and optimizes `Wrapper` lookups.
First wrote a few simple microbenchmarks to verify there are actual speedups
from using perfect hash tables in `sun.invoke.util.Wrapper` compared to simpler
lookup mechanisms (such as if-else or switch). Turns out there _is_ a speed-up
for
On Thu, 14 Apr 2022 10:13:32 GMT, Maxim Kartashev wrote:
>> Andrew Leonard has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8284661: Reproducible assembly builds without relative linking
>>
>>Signed-off-by: Andrew Leonard
>>
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853:
On Wed, 13 Apr 2022 13:55:59 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8284853: Fix various 'expected' typo
improve test log
-
Changes:
27 matches
Mail list logo
