Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-28 Thread David Holmes
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-28 Thread Guoxiong Li
On Thu, 28 Apr 2022 18:10:57 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-28 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Integrated: JDK-8285728: Alpine Linux build fails with busybox tar

2022-04-28 Thread Matthias Baesken
On Thu, 28 Apr 2022 10:24:37 GMT, Matthias Baesken wrote: > Currently , in target "product-bundles" , the Alpine Linux build fails when > BusyBox tar is used. > Error is : This pull request has now been integrated. Changeset: 36bf6fbe Author:Matthias Baesken URL: https://git.openjd

Integrated: 8285630: Fix a configure error in RISC-V cross build

2022-04-28 Thread Pengfei Li
On Wed, 27 Apr 2022 09:50:35 GMT, Pengfei Li wrote: > We are trying to cross build a RISC-V version of OpenJDK. We specified > `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an > error message. > > > configure: error: /usr/bin/bash > /home/ent-user/jdk_src/make/autoconf/bu

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Pengfei Li
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: JDK-8285728: Alpine Linux build fails with busybox tar

2022-04-28 Thread Thomas Stuefe
On Thu, 28 Apr 2022 10:24:37 GMT, Matthias Baesken wrote: > Currently , in target "product-bundles" , the Alpine Linux build fails when > BusyBox tar is used. > Error is : Looks good. I confirmed that the build works now in my Alpine container. Thanks for fixing! - Marked as revi

Integrated: 8285755: JDK-8285093 changed the default for --with-output-sync

2022-04-28 Thread Erik Joelsson
On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote: > The make option '--output-sync recurse' can be useful in certain situations, > especially when dealing with very verbose output from makefiles and you want > to parse them after the fact. However, when running make interactively on the >

Re: RFR: JDK-8285728: Alpine Linux build fails with busybox tar

2022-04-28 Thread Erik Joelsson
On Thu, 28 Apr 2022 10:24:37 GMT, Matthias Baesken wrote: > Currently , in target "product-bundles" , the Alpine Linux build fails when > BusyBox tar is used. > Error is : Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8449

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Erik Joelsson
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Erik Joelsson
On Thu, 28 Apr 2022 08:14:08 GMT, Nick Gasson wrote: > Is there a reason we can't import the latest upstream config.sub? That > already handles RISC-V and AArch64 correctly. > > https://git.savannah.gnu.org/cgit/config.git/plain/config.sub That would indeed be convenient, but unfortunately the

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-28 Thread Erik Joelsson
On Thu, 28 Apr 2022 07:16:30 GMT, Matthias Baesken wrote: > Hi Erik/David/Phil, we already have a good central place where we set the > definition of WIN32_LEAN_AND_MEAN > > autoconf/flags-cflags.m4:460: ALWAYS_DEFINES_JDK="-DWIN32_LEAN_AND_MEAN > -D_CRT_SECURE_NO_DEPRECATE autoconf/flags-cfla

RFR: JDK-8285728: Alpine Linux build fails with busybox tar

2022-04-28 Thread Matthias Baesken
Currently , in target "product-bundles" , the Alpine Linux build fails when BusyBox tar is used. Error is : - Commit messages: - JDK-8285728 Changes: https://git.openjdk.java.net/jdk/pull/8449/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8449&range=00 Issue: https

Re: RFR: 8285755: JDK-8285093 changed the default for --with-output-sync

2022-04-28 Thread Maurizio Cimadamore
On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote: > The make option '--output-sync recurse' can be useful in certain situations, > especially when dealing with very verbose output from makefiles and you want > to parse them after the fact. However, when running make interactively on the >

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Feilong Jiang
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Nick Gasson
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-28 Thread Fei Yang
On Thu, 28 Apr 2022 01:31:07 GMT, Fei Yang wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/autoco

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Fei Yang
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Aleksey Shipilev
On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/auto

Re: RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-28 Thread Pengfei Li
On Thu, 28 Apr 2022 01:31:07 GMT, Fei Yang wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >> /home/ent-user/jdk_src/make/autoco

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Pengfei Li
On Thu, 28 Apr 2022 02:26:02 GMT, Feilong Jiang wrote: >> Pengfei Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address comments > > make/autoconf/build-aux/config.sub line 54: > >> 52: echo $result >> 53: exit >> 54: fi >

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

2022-04-28 Thread Pengfei Li
> We are trying to cross build a RISC-V version of OpenJDK. We specified > `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an > error message. > > > configure: error: /usr/bin/bash > /home/ent-user/jdk_src/make/autoconf/build-aux/config.sub riscv64-linux-gnu > failed > confi

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-28 Thread Matthias Baesken
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-28 Thread Matthias Baesken
On Wed, 27 Apr 2022 15:10:51 GMT, Alan Bateman wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/winpro