On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
On Fri, 13 May 2022 22:11:17 GMT, Joe Wang wrote:
>> Applied required casts for the upcoming warning. Verified by cherry-picking
>> Adam's patch.
>
> make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java
> line 1278:
>
>> 1276:
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java
line 1278:
> 1276: state[numCategories]
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
Applied required casts for the upcoming warning. Verified by cherry-picking
Adam's patch.
-
Commit messages:
- 8286399: Address possibly lossy conversions in JDK Build Tools
Changes: https://git.openjdk.java.net/jdk/pull/8706/files
Webrev:
On Fri, 13 May 2022 14:36:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as
> Can I please get a review of this change which proposes to fix the failure
> handler command `dmesg` on macOS?
>
> As noted in the JBS issue, the command currently fails with permission error.
> The commit in this PR uses `sudo` as suggested in the man pages of that
> command.
>
> Tested
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Fri, 13 May 2022 09:42:44 GMT, Maurizio Cimadamore
wrote:
>> This change here also closes
>> [JDK-8259034](https://bugs.openjdk.java.net/browse/JDK-8259034)
>
> @uschindler - the issue you mention with respect lack of UOE for wrong file
> system applies to BB as well. I suggest filing an
On Fri, 13 May 2022 11:59:12 GMT, Maurizio Cimadamore
wrote:
>> RFE = issue?
>
>> RFE = issue?
>
> issue, with type RFE (request for enhancement)
See: https://bugs.openjdk.java.net/browse/JDK-8286734
-
PR: https://git.openjdk.java.net/jdk/pull/7888
On Fri, 13 May 2022 11:01:09 GMT, Uwe Schindler wrote:
> RFE = issue?
issue, with type RFE (request for enhancement)
-
PR: https://git.openjdk.java.net/jdk/pull/7888
On Fri, 13 May 2022 09:43:55 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 1164:
>>
>>> 1162: }
>>> 1163: if (unmapper != null) {
>>> 1164: AbstractMemorySegmentImpl segment = new
>>>
On Fri, 13 May 2022 08:43:35 GMT, Christian Hagedorn
wrote:
>> I'm googling around for some information about -gdwarf-4 but is mostly
>> coming up empty handed. :( I found
>> [this](https://www.phoronix.com/scan.php?page=news_item=GCC-11-DWARF-5-Possible-Default)
>> saying that dwarf-5
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000],
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
>
On Fri, 13 May 2022 08:29:13 GMT, Uwe Schindler wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Merge branch 'master' into
On Fri, 13 May 2022 08:33:11 GMT, Uwe Schindler wrote:
>> src/java.base/share/classes/java/nio/channels/FileChannel.java line 1045:
>>
>>> 1043: *
>>> 1044: * @throws UnsupportedOperationException
>>> 1045: * If an unsupported map mode is specified.
>>
>> I think this
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000],
On Fri, 8 Apr 2022 13:34:03 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/flags-cflags.m4 line 116:
>>
>>> 114: fi
>>> 115:
>>> 116: CFLAGS_DEBUG_SYMBOLS="-g -gdwarf-4"
>>
>> We may need to guard this with a FLAGS_COMPILER_CHECK_ARGUMENTS. Perhaps it
>> should also be applied only
On Fri, 13 May 2022 08:25:01 GMT, Uwe Schindler wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Merge branch 'master' into
On Thu, 12 May 2022 15:45:01 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
23 matches
Mail list logo