Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-16 Thread Kim Barrett
On Tue, 17 May 2022 03:05:09 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot/share/opto/memnode.cpp line 1413: >

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-16 Thread Kim Barrett
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >> >> * -Wstringop-overflow >>

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v4]

2022-05-16 Thread Kim Barrett
On Thu, 12 May 2022 18:28:02 GMT, Kim Barrett wrote: >> Thanks for all to review this PR! I think we should separate this issue as >> following: >> >> * Suppress warnings >> * make/modules/java.desktop/lib/Awt2dLibraries.gmk >> * src/hotspot/share/classfile/bytecodeAssembler.cpp >>

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v4]

2022-05-16 Thread Yasumasa Suenaga
On Thu, 12 May 2022 11:02:02 GMT, Magnus Ihse Bursie wrote: >> Thanks for all to review this PR! I think we should separate this issue as >> following: >> >> * Suppress warnings >> * make/modules/java.desktop/lib/Awt2dLibraries.gmk >> * src/hotspot/share/classfile/bytecodeAssembler.cpp

Integrated: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues

2022-05-16 Thread Jaikiran Pai
On Fri, 13 May 2022 14:17:44 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the failure > handler command `dmesg` on macOS? > > As noted in the JBS issue, the command currently fails with permission error. > The commit in this PR uses `sudo` as

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Jaikiran Pai
On Mon, 16 May 2022 22:06:25 GMT, Leonid Mesnik wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright year > > Looks reasonable. Thank you @lmesnik for the review. - PR:

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Leonid Mesnik
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the failure >> handler command `dmesg` on macOS? >> >> As noted in the JBS issue, the command currently fails with permission >> error. The commit in this PR uses `sudo` as

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v2]

2022-05-16 Thread Phil Race
On Thu, 12 May 2022 00:26:41 GMT, Yasumasa Suenaga wrote: >> I don't understand what the actual warning is getting at .. can anyone >> explain it ? >> >> FWIW the code is still the same in upstream harfbuzz >> https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-font.cc > > I've pasted a part

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v5]

2022-05-16 Thread Phil Race
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >> >> * -Wstringop-overflow >>

Re: RFR: 8286262: Windows: Cleanup deprecation warning suppression

2022-05-16 Thread Magnus Ihse Bursie
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote: > Please review this cleanup of deprecation warning suppression when building > for Windows. > > This change consists of several parts. > > (1) Remove the global deprecation warning suppression when building HotSpot > for Windows. > > (2)

Integrated: 8286399: Address possibly lossy conversions in JDK Build Tools

2022-05-16 Thread Naoto Sato
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote: > Applied required casts for the upcoming warning. Verified by cherry-picking > Adam's patch. This pull request has now been integrated. Changeset: c044cb83 Author:Naoto Sato URL:

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v8]

2022-05-16 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v7]

2022-05-16 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]

2022-05-16 Thread Erik Gahlin
On Mon, 16 May 2022 11:37:43 GMT, Markus Grönlund wrote: >> Greetings, >> >> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to >> address artefact tagging for Compiler threads, letting threads run >> _thread_in_native to avoid the transition. Unfortunately, that

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]

2022-05-16 Thread Markus Grönlund
> Greetings, > > [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to > address artefact tagging for Compiler threads, letting threads run > _thread_in_native to avoid the transition. Unfortunately, that attempt proved > inadequate. > > The epoch race is avoided only

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate

2022-05-16 Thread David Holmes
On Mon, 16 May 2022 10:17:42 GMT, Markus Grönlund wrote: > Greetings, > > [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to > address artefact tagging for Compiler threads, letting threads run > _thread_in_native to avoid the transition. Unfortunately, that attempt

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread David Holmes
On Mon, 16 May 2022 07:54:09 GMT, Jaikiran Pai wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright year > > Thank you Daniel and Lance for the reviews. > > Would anyone from the build team like to provide

RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate

2022-05-16 Thread Markus Grönlund
Greetings, [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to address artefact tagging for Compiler threads, letting threads run _thread_in_native to avoid the transition. Unfortunately, that attempt proved inadequate. The epoch race is avoided only by performing the

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Jaikiran Pai
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the failure >> handler command `dmesg` on macOS? >> >> As noted in the JBS issue, the command currently fails with permission >> error. The commit in this PR uses `sudo` as

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v8]

2022-05-16 Thread Christian Hagedorn
On Fri, 13 May 2022 10:04:25 GMT, Magnus Ihse Bursie wrote: >> I'm back to work again. I also had a look but could not find something on >> Google, either. I then skimmed through the old GCC manuals. I found the >> first occurrence of `-gdwarf-4` in the manual for GCC 4.5.4 >>