Re: RFR: 8286562: GCC 12 reports some compiler warnings [v9]

2022-05-25 Thread Kim Barrett
On Wed, 25 May 2022 09:16:43 GMT, Yasumasa Suenaga wrote: >> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 >> on Fedora 36. >> As you can see, the warnings spreads several areas. Let me know if I should >> separate them by area. >> >> * -Wstringop-overflow >>

Re: RFR: 8287187: Utilize HashMap.newHashMap() in CLDRConverter [v2]

2022-05-25 Thread Joe Wang
On Wed, 25 May 2022 17:15:18 GMT, Naoto Sato wrote: >> Refactoring the leftover self-calculations of the optimized `HashMap` >> initial value with `newHashMap()` method. Also replaced some string literals >> using text blocks for better readability. Confirmed that the output resource >>

Re: RFR: 8287336: GHA: Workflows break on patch versions

2022-05-25 Thread Aleksey Shipilev
On Wed, 25 May 2022 17:17:12 GMT, Christoph Langer wrote: > This fixes the issue on GHA when the branch contains a patch version. > > Here you can see the problem: > https://github.com/openjdk-bots/jdk18u/actions/runs/2385040187 > And here you see how it looks if it's fixed: >

RFR: 8287336: GHA: Workflows break on patch versions

2022-05-25 Thread Christoph Langer
This fixes the issue on GHA when the branch contains a patch version. Here you can see the problem: https://github.com/openjdk-bots/jdk18u/actions/runs/2385040187 And here you see how it looks if it's fixed: https://github.com/RealCLanger/jdk18u/actions/runs/2384983103 I plan to backport this

Re: RFR: 8287187: Utilize HashMap.newHashMap() in CLDRConverter [v2]

2022-05-25 Thread Naoto Sato
> Refactoring the leftover self-calculations of the optimized `HashMap` initial > value with `newHashMap()` method. Also replaced some string literals using > text blocks for better readability. Confirmed that the output resource bundle > sources are effectively (sans indentation) the same as

RFR: 8287187: Utilize HashMap.newHashMap() in CLDRConverter

2022-05-25 Thread Naoto Sato
Refactoring the leftover self-calculations of the optimized `HashMap` initial value with `newHashMap()` method. Also replaced some string literals using text blocks for better readability. Confirmed that the output resource bundle sources are effectively (sans indentation) the same as the

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v8]

2022-05-25 Thread Yasumasa Suenaga
On Wed, 25 May 2022 01:50:57 GMT, Kim Barrett wrote: >> Yasumasa Suenaga has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 11 commits: >> >> - Merge remote-tracking branch 'upstream/master' into gcc12-warnings >> - Use getter

Re: RFR: 8286562: GCC 12 reports some compiler warnings [v9]

2022-05-25 Thread Yasumasa Suenaga
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on > Fedora 36. > As you can see, the warnings spreads several areas. Let me know if I should > separate them by area. > > * -Wstringop-overflow > * src/hotspot/share/oops/array.hpp > * >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v9]

2022-05-25 Thread Thomas Stuefe
On Fri, 20 May 2022 14:54:39 GMT, Christian Hagedorn wrote: > Thanks Thomas for doing the testing! Hi Christian, I can see no problems on ppcle attributable to your test. However, I may overlook something since tests are still failing all over the place because of loom. I see test errors

Integrated: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event

2022-05-25 Thread Christoph Langer
On Tue, 24 May 2022 06:41:52 GMT, Christoph Langer wrote: > It seems that it was forgotten to add the macOS aarch64 platform to the > default platforms of workflow_dispatch. Let's fix this. This pull request has now been integrated. Changeset: f7a37f58 Author:Christoph Langer URL:

Integrated: 8287254: Clean up Xcode sysroot logic

2022-05-25 Thread Magnus Ihse Bursie
On Tue, 24 May 2022 17:09:10 GMT, Magnus Ihse Bursie wrote: > The logic in BASIC_SETUP_DEVKIT for setting a correct sysroot for Xcode is > hard to follow. This should be straightened out. We also expose variables > that are no longer used. So there's a bit of related cleanup. > > The new