Integrated: 8233269: Improve handling of JAVA_ARGS

2022-06-01 Thread Adam Sotona
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote: > LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option > for all JDK launchers, including java launcher. > JAVA_ARGS should not be defined for java launcher (in contrast to the other > JDK launchers), and the command l

Re: RFR: 8233269: Improve handling of JAVA_ARGS

2022-06-01 Thread Erik Joelsson
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote: > LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option > for all JDK launchers, including java launcher. > JAVA_ARGS should not be defined for java launcher (in contrast to the other > JDK launchers), and the command l

Re: RFR: 8287171: Refactor null caller tests to a single directory [v8]

2022-06-01 Thread Mandy Chung
On Wed, 1 Jun 2022 19:27:33 GMT, Tim Prinzing wrote: >> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates >> a test module with some resources in it for the actual tests that occur at >> the native level. The native part was switched to c++ instead of c to make >> it

Re: RFR: 8287171: Refactor null caller tests to a single directory [v8]

2022-06-01 Thread Tim Prinzing
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates > a test module with some resources in it for the actual tests that occur at > the native level. The native part was switched to c++ instead of c to make it > easier to create helper objects that reduce the redundant

Re: RFR: 8287171: Refactor null caller tests to a single directory [v7]

2022-06-01 Thread Tim Prinzing
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates > a test module with some resources in it for the actual tests that occur at > the native level. The native part was switched to c++ instead of c to make it > easier to create helper objects that reduce the redundant

Re: RFR: 8287171: Refactor null caller tests to a single directory [v6]

2022-06-01 Thread Mandy Chung
On Wed, 1 Jun 2022 03:01:35 GMT, Tim Prinzing wrote: >> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates >> a test module with some resources in it for the actual tests that occur at >> the native level. The native part was switched to c++ instead of c to make >> it

RFR: 8233269: Improve handling of JAVA_ARGS

2022-06-01 Thread Adam Sotona
LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option for all JDK launchers, including java launcher. JAVA_ARGS should not be defined for java launcher (in contrast to the other JDK launchers), and the command line option `-J-ms8m` is obsolete for java launcher. Proposed

Integrated: 8287366: Improve test failure reporting in GHA

2022-06-01 Thread Magnus Ihse Bursie
On Thu, 26 May 2022 12:04:41 GMT, Magnus Ihse Bursie wrote: > It is currently both tricky and tedious to figure out what went wrong when a > jtreg test fails in GHA. > > We should utilize the full potential of GitHub Action summaries and error > annotations to make finding failures easier and