One can select a testcase by ID when running a jtreg test case directly from
jtreg (using the testcase.java#testID syntax). However, this has not been
possible to do when launching jtreg indirectly from make.
This fix attempts to address this issue. I have not tested this thoroughly yet,
I
On Fri, 3 Jun 2022 22:40:52 GMT, Tim Prinzing wrote:
>> make/test/JtregNativeJdk.gmk line 67:
>>
>>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX)
>>> jvm.lib
>>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokeall := advapi32.lib
>>> 67:
On Fri, 3 Jun 2022 18:16:53 GMT, Mandy Chung wrote:
>> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
>
> make/test/JtregNativeJdk.gmk line 67:
>
>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
>> 66:
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Thanks for doing the run, Dan.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
I did a Mach5 Tier1 test run on the v00 version of this patch. There were
no failures and all 6 runs of jni/nullCaller/NullCallerTest.java passed.
-
PR:
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by mchung (Reviewer).
make/test/JtregNativeJdk.gmk line 67:
> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
> 66:
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the
On Thu, 2 Jun 2022 23:33:13 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> test/langtools/jdk/javadoc/doclet/testDoclintDocletMessages/TestDocLintDocletMessages.java
>
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the new larger set of
> diagnostics that could be generated by
Could I have a review of PR that removes a printStackTrace() for the jfr tool.
Testing: jdk/jfr/tool
Thanks
Erik
-
Commit messages:
- Initial
Changes: https://git.openjdk.java.net/jdk/pull/9018/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9018=00
Issue:
On Fri, 3 Jun 2022 15:59:04 GMT, Pavel Rappo wrote:
> > I did a visual inspection over the Checker class.
>
> > The test is set up to be a framework to accommodate new cases if any should
> > arise.
>
> This is good. It would be even better if we had a mechanism to reduce risk of
>
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the
On Fri, 3 Jun 2022 07:48:15 GMT, Pavel Rappo wrote:
> > Since the introduction of doclint, there was some (small) overlap between
> > the small set ... and the new larger set ... But, the sets do not overlap
>
> Do or do they not overlap? :)
Ooops. Wrong word. I was meaning that neither set
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9010
Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
-
Commit messages:
- 8287745 Fix JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Changes: https://git.openjdk.java.net/jdk/pull/9010/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9010=00
Issue:
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the
Hi,
I see the same on my windows build. I verified that 8.3 filenames are enabled.
I took a little closer look. In my PATH env in Cygwin I have:
...:/cygdrive/c/Program Files/Git/cmd:...
The git path is resolved via UTIL_LOOKUP_PROGS(GIT, git) in basic_tools.m4.
UTIL_LOOKUP_PROGS, defined in
17 matches
Mail list logo
