Re: RFR: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-19 Thread Erik Joelsson
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote: > Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows > fastdebug builds. The change was tested by running Mach5 tiers 1-6 on > Windows-x64-debug. > > Thanks, Harold Looks good to me. - Marked as

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-19 Thread Erik Joelsson
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > >

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-14 Thread Erik Joelsson
On Thu, 14 Oct 2021 13:36:19 GMT, Weijun Wang wrote: > The cacerts file is now a password-less PKCS12 file. This make sure old code > that uses a JKS KeyStore object can continuously load it using a null > password (in fact, any password) and see all certificates inside. Build change looks

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2021-10-13 Thread Erik Joelsson
On Wed, 13 Oct 2021 00:00:22 GMT, Magnus Ihse Bursie wrote: > This patch expands the newly added system for hsdis backends to include LLVM. > > The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, > as published in the never integrated PR >

Re: RFR: 8275128: Build hsdis using normal build system [v3]

2021-10-12 Thread Erik Joelsson
On Tue, 12 Oct 2021 21:58:23 GMT, Magnus Ihse Bursie wrote: >> There are multiple bugs related to hsdis, calling both for added simplicity >> in building, and allowing for multiple backends. >> >> The very first step is getting rid of the stand-alone Makefile and integrate >> the build using

Re: RFR: 8275063: Implementation of Memory Access API (Second incubator)

2021-10-12 Thread Erik Joelsson
On Tue, 12 Oct 2021 11:16:51 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] -

Re: RFR: 8275128: Build hsdis using normal build system

2021-10-12 Thread Erik Joelsson
On Tue, 12 Oct 2021 11:24:01 GMT, Magnus Ihse Bursie wrote: > There are multiple bugs related to hsdis, calling both for added simplicity > in building, and allowing for multiple backends. > > The very first step is getting rid of the stand-alone Makefile and integrate > the build using

Re: RFR: 8272167: AbsPathsInImage.java should skip *.dSYM directories

2021-10-11 Thread Erik Joelsson
On Sun, 10 Oct 2021 22:35:40 GMT, Sergey Bylokhov wrote: > This fix changes the AbsPathsInImage test to skip *.dSYM directories. Thanks for fixing this! - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5885

Re: RFR: 8274610: Add linux-aarch64 to bootcycle build profiles

2021-09-30 Thread Erik Joelsson
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov wrote: > Please review this simple/trivial change that add linux-aarch64 platform to > bootcycle build profiles. Looks good! - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5783

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Erik Joelsson
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote: > This is an initial PR for expanded lint warnings done under two bugs: > > 8202056: Expand serial warning to check for bad overloads of serial-related > methods and ineffectual fields > 8160675: Issue lint warning for non-serializable

Re: RFR: 8274345: make build-test-lib is broken

2021-09-27 Thread Erik Joelsson
On Mon, 27 Sep 2021 03:26:54 GMT, xpbob wrote: > 8274345: make build-test-lib is broken Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5710

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Erik Joelsson
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale

2021-09-24 Thread Erik Joelsson
On Fri, 24 Sep 2021 09:50:19 GMT, Jie Fu wrote: > Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. >

Re: RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution

2021-09-24 Thread Erik Joelsson
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds hook for custom makefiles to > augment parameters for jtreg test execution. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5666

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Erik Joelsson
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: 8273459: Update code segment alignment to 64 bytes

2021-09-16 Thread Erik Joelsson
On Thu, 16 Sep 2021 13:52:24 GMT, Scott Gibbons wrote: > Change the default code entry alignment to 64 bytes from 32 bytes. This > allows for maintaining proper 64-byte alignment of data within a code > segment, which is required by several AVX-512 instructions. > > I ran into this while

Re: RFR: 8273797: Stop impersonating "server" VM in all VM variants

2021-09-15 Thread Erik Joelsson
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote: > As the follow-up for Zero-specific JDK-8273494, we might want to clean up > build system logic for all VM variants: stop impersonating "server" VMs for > all of them. This basically leaves "core" and "custom" variants to be handled >

Re: RFR: 8273801: Handle VMTYPE for "core" VM variant

2021-09-15 Thread Erik Joelsson
On Wed, 15 Sep 2021 09:55:22 GMT, Aleksey Shipilev wrote: > Building with --with-jvm-variants=core currently produces a binary that > replies an odd version: > > > $ build/linux-x86_64-core-fastdebug/images/jdk/bin/java -version > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime

Re: RFR: 8256977: Bump minimum GCC from 5.x to 6 for JDK

2021-09-09 Thread Erik Joelsson
On Thu, 9 Sep 2021 19:28:54 GMT, Magnus Ihse Bursie wrote: > The minimum acceptable version is raised from 5 to 6. There were no > objections on the mailing list for doing so in the mainline, see > https://mail.openjdk.java.net/pipermail/build-dev/2021-August/031899.html. > > This patch also

Re: RFR: 8273497: building.md should link to both md and html

2021-09-09 Thread Erik Joelsson
On Thu, 9 Sep 2021 18:51:10 GMT, Magnus Ihse Bursie wrote: > The building.md (and the generated building.html) should link to both the > markdown and the html version of the test documentation. > > This is a replacement PR for https://git.openjdk.java.net/jdk/pull/5417, > since I'm taking

Re: RFR: 8263773: Request for German localization

2021-09-09 Thread Erik Joelsson
On Thu, 9 Sep 2021 17:55:22 GMT, Saravana Kumar Vijayasekaran wrote: > 8263773: Request for German localization Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5448

Re: RFR: 8273497: Building.md should link to testing md file rather than html

2021-09-08 Thread erik . joelsson
On 2021-09-08 10:44, Dan Heidinga wrote: On Wed, 8 Sep 2021 16:14:36 GMT, Aleksey Shipilev wrote: (2) looks appealing for me, for a different reason: if you regenerate `.md` -> `.html`, and choose the unexpected pandoc version (for example one provided by distro), then `.html` diff would

Re: RFR: 8273497: Building.md should link to testing md file rather than html

2021-09-08 Thread Erik Joelsson
On Wed, 8 Sep 2021 14:20:04 GMT, Dan Heidinga wrote: > Discovered while working through the building guide. When updating the .md doc files, you must also run the make target to generate the corresponding .html files and submit them together. In this case, changing the link to .md will

Re: Bumping minimum GCC from 5.x to 6.x?

2021-09-01 Thread erik . joelsson
On 2021-09-01 10:01, Andrew Hughes wrote: On 15:17 Mon 30 Aug , Magnus Ihse Bursie wrote: Hi all, There is an open request[1] to bump the minimum GCC version from 5 to 6. We've traditionally been very conservative with supporting old GCC versions, but GCC 6 was released in 2016 (compared

Re: RFR: 8270438: "Cores to use" output in configure is misleading

2021-08-30 Thread Erik Joelsson
On Mon, 30 Aug 2021 13:06:19 GMT, Magnus Ihse Bursie wrote: > Description from the bug: > > When building the JDK and running `configure` the output includes (example): > > Build performance summary: > * Cores to use: 4 > * Memory limit: 32768 MB > > > The "Cores to use" value is

Re: RFR: 8229031: Exporting CLASSPATH from shell can result in build failures

2021-08-27 Thread Erik Joelsson
On Fri, 27 Aug 2021 14:28:07 GMT, Magnus Ihse Bursie wrote: > Having the environment variable CLASSPATH set when building can cause > hard-to-diagnose build errors. We should not silently accept the CLASSPATH > variable when building. Normally, the classpath should be correctly setup for >

Re: RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

2021-08-27 Thread Erik Joelsson
On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf wrote: > Hi! > > Please review this tiny patch which removes the special casing of > `--with-native-debug-symbols=external` for the static libs build. I don't see > why this is needed. If no debug symbols are wanted >

Re: RFR: 8270517: Add Zero support for LoongArch

2021-07-15 Thread Erik Joelsson
On Thu, 15 Jul 2021 04:04:08 GMT, Ao Qi wrote: > LoongArch is a new RISC ISA. This issue proposes adding Zero support for > LoongArch. Only 64-bit support is proposed at present. > > linux-loongarch64-zero-{release, fastdebug} build tested: > > $

[jdk17] Integrated: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848

2021-07-14 Thread Erik Joelsson
On Wed, 14 Jul 2021 07:34:58 GMT, Erik Joelsson wrote: > This patch extends the filter for marker files when creating jmods. Our > latest established marker file format is `_*.marker` and through > ExecuteWithLog, we regularly append additional suffixes to such file names. > Thus

[jdk17] RFR: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848

2021-07-14 Thread Erik Joelsson
This patch extends the filter for marker files when creating jmods. Our latest established marker file format is `_*.marker` and through ExecuteWithLog, we regularly append additional suffixes to such file names. Thus I propose we simply extend the filter pattern to `_*.marker*`. -

[jdk17] Integrated: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote: > This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra &g

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links [v2]

2021-07-13 Thread Erik Joelsson
of this file. Rebuilding > should now work better with the various clean targets and any problems with > the generation tool will be captured in separate log files, along with the > command lines. > > @hns Can you verify that this solves the problem you reported? Erik Joelsson h

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Fri, 9 Jul 2021 20:13:56 GMT, Jonathan Gibbons wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >>

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Mon, 12 Jul 2021 11:10:26 GMT, Magnus Ihse Bursie wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >>

Re: [jdk17] RFR: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot [v2]

2021-07-12 Thread Erik Joelsson
> Add missing make dependency in Main.gmk. Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: Fix comment - Changes: - all: https://git.openjdk.java.net/jdk17/pull/239/files - new: https://git.openjdk.java.net/jd

[jdk17] Integrated: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot

2021-07-12 Thread Erik Joelsson
On Fri, 9 Jul 2021 19:45:09 GMT, Erik Joelsson wrote: > Add missing make dependency in Main.gmk. This pull request has now been integrated. Changeset: 0f329828 Author: Erik Joelsson URL: https://git.openjdk.java.net/jdk17/commit/0f32982872eb1454e55390760b65beb5838afc55 Stats:

Re: Building OpenJDK with Xcode12 devkits on older macOS

2021-07-12 Thread erik . joelsson
Hello Matthias, I don't know of a nicer way. I have just assumed that the build won't work on a Macos version older than what the Xcode in the kit officially supports. /Erik On 2021-07-12 04:26, Baesken, Matthias wrote: Hello, I noticed the following when building jdk on macOS 10.14 with

[jdk17] RFR: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot

2021-07-09 Thread Erik Joelsson
Add missing make dependency in Main.gmk. - Commit messages: - JDK-8270203 Changes: https://git.openjdk.java.net/jdk17/pull/239/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=239=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270203 Stats: 3 lines in 1 file

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

2021-07-09 Thread Erik Joelsson
On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote: > This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra &g

Re: RFR: JDK-8270108: Update JCov version to 3.0.9

2021-07-08 Thread Erik Joelsson
On Thu, 8 Jul 2021 18:59:56 GMT, Alexandre Iline wrote: > JDK-8270108: Update JCov version to 3.0.9 Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4729

Re: RFR: 8270083: -Wnonnull errors happen with GCC 11.1.1

2021-07-08 Thread Erik Joelsson
On Thu, 8 Jul 2021 09:42:43 GMT, Yasumasa Suenaga wrote: > I attempted to build OpenJDK on Fedora 34 with gcc-11.1.1-3.fc34.x86_64, but > I saw following errors: > > > In file included from > /home/ysuenaga/github-forked/jdk/src/hotspot/share/runtime/frame.inline.hpp:42, >

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4]

2021-07-06 Thread Erik Joelsson
On Mon, 5 Jul 2021 18:05:19 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this >> results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such >> file or directory >>

Re: RFR: 8269760: idea.sh should not invoke cygpath directly

2021-07-02 Thread Erik Joelsson
On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking > `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to > something else, such as `wslpath`. >

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL

2021-07-02 Thread Erik Joelsson
On Thu, 1 Jul 2021 16:10:03 GMT, Maurizio Cimadamore wrote: > Question though: with WSL, the boot JDK could also be a Linux JDK, no? If > that's the case, then the .exe suffix would be bad? That's a good point, maybe check if BOOT_JDK/bin/java.exe exists and have that as the condition?

Re: RFR: 8269758: idea.sh doesn't work when there are multiple configurations available.

2021-07-02 Thread Erik Joelsson
On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, > when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given,

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-23 Thread Erik Joelsson
On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (DumpTime/RunTime)

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Erik Joelsson
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= >

Re: RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 [v2]

2021-06-22 Thread Erik Joelsson
On Tue, 22 Jun 2021 11:18:47 GMT, Matthias Baesken wrote: >> This change adds a check for binutils 2.25 or higher after 8265783. The >> change 8265783 introduced on linux x86_64 a minimum requirement for binutils >> : "Minimum required would be binutils 2.25 where AVX512 support was added >>

Re: [jdk17] RFR: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails

2021-06-16 Thread Erik Joelsson
On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee wrote: > Upstream a critical fix from the panama-foreign repo. > > See the prior review thread here: > https://github.com/openjdk/panama-foreign/pull/558 > > Testing: tier 1-2, local run of run-test-jdk_foreign. Build changes look good.

Re: Github Action CI pipeline

2021-06-16 Thread erik . joelsson
Hello Giuseppe, Maurizio is correct, we do not publish builds using Github actions. This is not based on a technical limitation, but a general policy in OpenJDK. The current set of Github actions are there to let developers run them in their own repository forks to help them verify their

Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Erik Joelsson
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Erik Joelsson
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Erik Joelsson
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Erik Joelsson
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Erik Joelsson
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: [jdk17] RFR: 8268643: SVML lib shouldn't be generated when C2 is absent [v2]

2021-06-14 Thread Erik Joelsson
On Mon, 14 Jun 2021 14:01:21 GMT, Jie Fu wrote: >> Hi all, >> >> SVML lib shouldn't be generated when C2 is absent. >> This is because it is only used by C2. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit > since the last

Re: [jdk17] RFR: 8268643: SVML lib shouldn't be generated when C2 is absent

2021-06-14 Thread erik . joelsson
On 2021-06-14 06:13, Jie Fu wrote: On Mon, 14 Jun 2021 12:54:33 GMT, Erik Joelsson wrote: Hi all, SVML lib shouldn't be generated when C2 is absent. This is because it is only used by C2. Thanks. Best regards, Jie make/autoconf/jvm-features.m4 line 571: 569: ENABLE_CDS="true

Re: [jdk17] RFR: 8268643: SVML lib shouldn't be generated when C2 is absent

2021-06-14 Thread Erik Joelsson
On Sat, 12 Jun 2021 09:03:19 GMT, Jie Fu wrote: > Hi all, > > SVML lib shouldn't be generated when C2 is absent. > This is because it is only used by C2. > > Thanks. > Best regards, > Jie make/autoconf/jvm-features.m4 line 571: > 569: ENABLE_CDS="true" > 570: INCLUDE_JVMCI="true" > 571:

Re: RFR: 8268626: Remove native pre-jdk9 support for jtreg failure handler

2021-06-11 Thread Erik Joelsson
On Fri, 11 Jun 2021 18:44:38 GMT, Leonid Mesnik wrote: > jtreg failure handler uses native lib to implement getPid for preJDK9. > Currently. it is not needed and might be removed. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4476

Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home [v2]

2021-06-09 Thread Erik Joelsson
On Wed, 9 Jun 2021 00:42:35 GMT, ScientificWare wrote: >> This concerns [dtdbuilder >> tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). >> >> In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. >> >> So, in

Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

2021-06-08 Thread Erik Joelsson
On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare wrote: > This concerns [dtdbuilder > tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). > > In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. > > So, in `DTDBuilder.java`

Re: RFR: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

2021-06-07 Thread Erik Joelsson
On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov wrote: > I got rid of `realpath` usage as discussed in > https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro > instead, however there were quite a few problems with this macro, here's the > example: > > $(call

Re: RFR: 8268327: Upstream: 8268169: The system lookup can not find stdio functions such as printf on Windows 10

2021-06-07 Thread Erik Joelsson
On Mon, 7 Jun 2021 13:23:46 GMT, Jorn Vernee wrote: > Hi, > > The documentation of `CLinker::systemLookup` [1] says this: > > > * Obtains a system lookup which is suitable to find symbols in the standard C > libraries. > > > However, currently it is not possible to look up common stdio.h

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Erik Joelsson
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > >

Re: RFR: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-07 Thread Erik Joelsson
On Sun, 6 Jun 2021 20:09:32 GMT, Liam Miller-Cushon wrote: > This change fixes a build error during the generation of > `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` > instead of `cp a b` to avoid propagating the permissions to the generated > source. Looks

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512

2021-06-07 Thread Erik Joelsson
On Fri, 4 Jun 2021 20:55:51 GMT, Scott Gibbons wrote: > Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

Re: RFR: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov wrote: > I got rid of `realpath` usage as discussed in > https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro > instead, however there were quite a few problems with this macro, here's the > example: > > $(call

Re: RFR: 8268272: Remove JDK-8264874 changes because Graal was removed.

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 17:40:48 GMT, Vladimir Kozlov wrote: > JDK-8264806 removed Graal sources from JDK and INCLUDE_GRAAL is not defined > anymore. We can now remove code added by JDK-8264874: > https://github.com/openjdk/jdk/commit/951f277a > > Tested Tier1. Marked as reviewed by erikj

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

Re: RFR: JDK-8268185: Update GitHub Actions for jtreg 6

2021-06-03 Thread Erik Joelsson
On Thu, 3 Jun 2021 19:05:35 GMT, Jonathan Gibbons wrote: > Please review changes to the GitHub Actions for the repo, to use jtreg 6. > > There are three small parts to the change: > > 1. The version info is updated in `make/conf/test-dependencies` > 2. The new `make/build.sh` script is used to

Re: RFR: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle

2021-06-03 Thread Erik Joelsson
On Thu, 3 Jun 2021 18:24:51 GMT, Mikael Vidstedt wrote: > With promoted builds available it's a good time to switch the boot JDK etc. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4341

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v6]

2021-06-03 Thread Erik Joelsson
On Thu, 3 Jun 2021 16:43:51 GMT, Maurizio Cimadamore wrote: >> This patch overhauls the library loading mechanism used by the Foreign >> Linker API. We realized that, while handy, the *default* lookup abstraction >> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. >>

Re: RFR: 8267630: Start of release updates for JDK 18

2021-06-03 Thread Erik Joelsson
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 Build change looks good. Please be aware of the incoming change https://bugs.openjdk.java.net/browse/JDK-8263468 which will add another version field to version-numbers.conf, which may need to

Re: RFR: JDK-8266254: Update to use jtreg 6 [v2]

2021-06-03 Thread Erik Joelsson
On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote: >> Please review the change to update to using jtreg 6. >> >> The primary change is to the jib-profiles.js file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Erik Joelsson
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk We

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk We do

Re: RFR: 8265431: Add -fdelete-null-pointer-checks to clang builds

2021-06-01 Thread Erik Joelsson
On Mon, 24 May 2021 14:03:45 GMT, Maxim Kartashev wrote: > This commit adds the `-fno-delete-null-pointer-checks` compiler option to > clang builds, which is going to become necessary starting from clang version > 12.0.0 (see the [bug >

Re: RFR: 8265431: Add -fdelete-null-pointer-checks to clang builds

2021-06-01 Thread Erik Joelsson
On Mon, 24 May 2021 14:03:45 GMT, Maxim Kartashev wrote: > This commit adds the `-fno-delete-null-pointer-checks` compiler option to > clang builds, which is going to become necessary starting from clang version > 12.0.0 (see the [bug >

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-05-28 Thread Erik Joelsson
On Fri, 28 May 2021 08:19:33 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL

2021-05-27 Thread Erik Joelsson
On Tue, 25 May 2021 16:37:30 GMT, Nikita Gubarkov wrote: > 8267706: bin/idea.sh tries to use cygpath on WSL I think this looks ok, though I'm not very familiar with the details of this code. I also very rarely use the idea projects. It would be good if some frequent users could take this for

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 13:28:33 GMT, Erik Joelsson wrote: >> I don't have a solution for this problem. AFAIK there are a few things that >> have to be "bumped" manually between releases, and this would be yet >> another. Obviously not a great solution. >

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 13:05:27 GMT, Hannes Wallnöfer wrote: >> make/Docs.gmk line 336: >> >>> 334: >>> 335: # Add summary pages for new/deprecated APIs in recent releases >>> 336: $1_OPTIONS += --since 12,13,14,15,16,17 --since-label "New API since >>> JDK 11" >> >> How do you expect this

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Wed, 26 May 2021 16:02:29 GMT, Hannes Wallnöfer wrote: > This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively

Re: RFR: 8267123: Remove RMI Activation

2021-05-25 Thread Erik Joelsson
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote: > This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). > > This is a fairly straightforward removal of this component. > - Activation implementation classes removed > - Activation tests removed > - adjustments to

Re: RFR: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines [v2]

2021-05-18 Thread Erik Joelsson
On Tue, 18 May 2021 03:35:11 GMT, Jie Fu wrote: >> Hi all, >> >> vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails on our >> many-core machines due to `-XX:MaxRAMPercentage=0`. >> This is because `MaxRAMPercentage` will be always 0 if JTREG_JOBS > 25 [1]. >> >> It can be

Re: RFR: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font

2021-05-18 Thread Erik Joelsson
On Tue, 18 May 2021 15:55:09 GMT, Phil Race wrote: > See the bug report for lots of explanation. > The short version (not that short) is that Swing adds a new line char to > editable TextComponents > It used to work because harfbuzz asked CoreText which mapped it to an > invisible glyph > Now

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-17 Thread Erik Joelsson
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR: 8267112: JVMCI compiler modules should be kept upgradable

2021-05-17 Thread Erik Joelsson
On Thu, 13 May 2021 16:37:38 GMT, Vladimir Kozlov wrote: > [JDK-8264806](https://bugs.openjdk.java.net/browse/JDK-8264806) changes > removed sources and also removed JVMCI compiler from list of upgradable > modules. JVMCI compiler modules should be upgradable in JDK to work with > GraalVM. >

Re: RFR: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines

2021-05-17 Thread erik . joelsson
On 2021-05-17 10:19, Aleksey Shipilev wrote: On Mon, 17 May 2021 13:24:16 GMT, Jie Fu wrote: Hi all, vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails on our many-core machines due to `-XX:MaxRAMPercentage=0`. This is because `MaxRAMPercentage` will be always 0 if

Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current

2021-05-17 Thread Erik Joelsson
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote: > Please review the changes to the subject issue. java.util.Locale class has a > long-standing issue for those obsolete ISO 639 languages where its > normalization ends up in the obsolete codes. This change intends to flip the >

Re: RFR: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines

2021-05-17 Thread Erik Joelsson
On Mon, 17 May 2021 13:24:16 GMT, Jie Fu wrote: > Hi all, > > vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails on our > many-core machines due to `-XX:MaxRAMPercentage=0`. > This is because `MaxRAMPercentage` will be always 0 if JTREG_JOBS > 25 [1]. > > It can be reproduced

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v4]

2021-05-17 Thread Erik Joelsson
On Sat, 15 May 2021 02:06:29 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library

Re: RFR: 8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142

2021-05-13 Thread Erik Joelsson
On Wed, 12 May 2021 00:06:34 GMT, Sergey Bylokhov wrote: > Performance in one of the tests in the bimg_misc group is dropped by 20%(or > 5% of the group) after some unused code was removed from the libawt. I assume > the size of the lib became smaller and GCC heuristics were changed to do not

Re: RFR: 8267043: IntelliJ project doesn't handle generated sources correctly [v2]

2021-05-12 Thread Erik Joelsson
On Wed, 12 May 2021 17:51:11 GMT, Maurizio Cimadamore wrote: >> Since generated sources are placed in the build folder, and since the build >> folder is indicated by the IntelliJ project settings as "project output", >> IntelliJ indexing blissfully ignores all the classes which are generated

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview)

2021-05-11 Thread Erik Joelsson
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote: > This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: >

Re: RFR: 8266465: Add wildcard to JTwork/JTreport exclude in jib-profiles.js

2021-05-04 Thread Erik Joelsson
On Mon, 3 May 2021 23:40:24 GMT, David Holmes wrote: > If you stash away jtreg test results in a specific JTwork directory this can > causes problem creating a jib source bundle. Simple fix is to add a wildcard > to the JTwork and JTreport exclude entries. > > Thanks, > David Marked as

Re: RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread Erik Joelsson
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup

Re: RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Erik Joelsson
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt wrote: > Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. Marked as reviewed by erikj (Reviewer). -

<    1   2   3   4   5   6   7   8   9   10   >