Re: Can not build jdk10 under Solaris 11

2018-09-05 Thread Gary Adams
With jdk10 repos you should be using solstudio 12.4. The changes were added to jdk11 repos to begin support for solstudio 12.6, but there are some additional patches needed in solstudio 12.6 to be able to build openjdk. Hopefully those issues will be resolved for the next jdk release. On 9/5/18,

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Gary Adams
Is any update needed for EXTRA_OBJECT_FILES? On 4/10/18, 2:32 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-04-10 11:22, John Paul Adrian Glaubitz wrote: Hi! Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out d

RFR: JDK-8199782: Fix compilation warnings detected by Solaris Developer Studio 12.6

2018-04-04 Thread Gary Adams
Getting the sources ready for the next Solaris developer studio toolchain. Issue: https://bugs.openjdk.java.net/browse/JDK-8199782 Webrev: http://cr.openjdk.java.net/~gadams/8199782/webrev.00/ This update conditionally disables some new error checks, if the new toolchain is used.

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-05 Thread Gary Adams
One more to fix to cover the remaining test failures I was seeing. Previously, using inet_addr, there was a single -1 return that needed to be checked. Now that we're using inet_pton, there is a -1 and a 0 error return to be considered. My preference would be to leave the dbgSysInetAddr name

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Gary Adams
0, "gethostbyname: unknown host"); you should change the description text of the error to getaddrinfo instead of gethostbyname. Best regards Christoph -Original Message- From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of Gary Adams Sent: Donnerstag, 25.

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Gary Adams
On 2/1/18, 6:59 AM, Langer, Christoph wrote: But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it? I still don't see the reason... vs2013 include/um/winsock2.h has WSASendDisconnect deprecated. .../src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c(230) : erro

RFR: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-01-25 Thread Gary Adams
Here's a first pass attempt to remove the -D_WINSOCK_DEPRECATED_NO_WARNINGS build flag and update the winsock deprecated functions. Issue: https://bugs.openjdk.java.net/browse/JDK-8080990 Webrev: http://cr.openjdk.java.net/~gadams/8080990/ These are the initial deprecated functions updated:

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Gary Adams
Is the expectation that all of the := will be changed to += for these variables? 468 jdk.internal.vm.ci_ADD_JAVAC_FLAGS := -parameters -Xlint:-exports -XDstringConcat=inline Do the closed makefiles also need to be updated? On 8/30/17, 10:36 AM, Erik Joelsson wrote: Hello Jason, I took the

RFR: JDK-8165946: buildjdk logic is incomplete when separate sysroots needed

2016-09-13 Thread Gary Adams
When the buildjdk logic was added to the jdk9 build system, it did not completely cover the use cases required in the mobile/dev builds. We have been working around this issue using a prebuilt macosx buildjdk with the --with-build-jdk autoconf option. This is an awkward workaround, because the b

Re: RFR: 8151630 and 8151631 ios build failures after b106 merge

2016-03-10 Thread Gary Adams
/Erik On 2016-03-10 17:43, Gary Adams wrote: Here are two quick fixes for ios build issues after the b106 merge A quick workaround for the ios build issue with upack executable is to noop the launcher makefile, similar to what has been done for other launcher makefiles. A longer term solution wi

RFR: 8151630 and 8151631 ios build failures after b106 merge

2016-03-10 Thread Gary Adams
Here are two quick fixes for ios build issues after the b106 merge A quick workaround for the ios build issue with upack executable is to noop the launcher makefile, similar to what has been done for other launcher makefiles. A longer term solution will be added later with a proper configure fla

RFR: JDK-8151402: Allow template files from closed and open repos

2016-03-08 Thread Gary Adams
Here is the proposed update to the GensrcMisc.gmk makefile. If a closed repos makefile is present, let it provide an alternate closed location for the template files. If it does not exist attempt to use the template from the open repos location. This change will allow the template files to be

Re: RFR: JDK-8150257 Remove softfloat lib support

2016-02-22 Thread Gary Adams
As far as I know the only build that uses the sflt libs is the legacy armv5 linux systems. http://closedjdk.us.oracle.com/ejdk9/dev/closed/file/a2055fab159f/bin/build-embedded.csh#l331 ... # ARMv5t, non-thumb, soft-float emulation, soft-float ABI case linux-arm-sflt: set JVM_VARIANT = "-

RFR: 8148361: Need to disable the thread local storage compiler option for ios

2016-01-27 Thread Gary Adams
When the sync with jdk9 b102 was pulled into mobile/dev repos a new feature for thread local storage was over looked. Most modern compilers include support for thread local declaration, but this feature is intentionally not supported by Apple's clang compiler. This change declares USE_LIBRARY_B

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2016-01-12 Thread Gary Adams
ime/orderAccess.inline.hpp These changes are ugly and should not be necessary - needs further examination. The whole point of intptr_t is that it will the same as int on 32-bit (ILP32), and same as a pointer on 64-bit (LP64). Is Android/iOS defining a different programming model? On 12/12/

Follow up bugs from the initial review comments

2015-12-18 Thread Gary Adams
I deferred a number of changes in order to get the first set of sources out to the mobile/dev repos. Just so we don't lose sight of those changes, I've filed a few bugs that can be addressed independently going forward. JDK-8145802: CPPFLAGS sysroot support JDK-8145804: ARFLAGS versus AR_OUT_

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-18 Thread Gary Adams
On 12/18/15 07:34, Magnus Ihse Bursie wrote: On 2015-12-17 20:40, Gary Adams wrote: On 12/17/15 11:09, Magnus Ihse Bursie wrote: On 2015-12-17 14:19, Gary Adams wrote: I've revised the original webrev based on some feedback received. - reverted white space only changes - p

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Gary Adams
On 12/17/15 11:09, Magnus Ihse Bursie wrote: On 2015-12-17 14:19, Gary Adams wrote: I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyrights on the new files - some hotspot files contained previously removed

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Gary Adams
first batch tomorrow. On 12/11/15 10:15, Gary Adams wrote: Here's the initial upload of changes that provides support for the ios and android ports for the mobile/dev repos. While there have been some preliminary reviews of the code, there is still more work required before we will loo

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread Gary Adams
On 12/14/15 07:34, David Holmes wrote: On 14/12/2015 6:30 PM, Magnus Ihse Bursie wrote: On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-inf

RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-11 Thread Gary Adams
Here's the initial upload of changes that provides support for the ios and android ports for the mobile/dev repos. While there have been some preliminary reviews of the code, there is still more work required before we will look for more thorough reviews and an integration to mobile/jdk9 repos.

Re: Java compilation and -g

2014-04-11 Thread Gary Adams
What is the size difference? On 4/11/14, 10:53 AM, Chris Hegarty wrote: On 11/04/14 15:40, Erik Joelsson wrote: Hello, While converting the build to the new build-infra makefiles, one thing that annoyed me was the fact that we aren't consistently compiling with or without -g for java code. In