Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v3]

2022-03-10 Thread George Adams
On Thu, 10 Mar 2022 12:44:07 GMT, Magnus Ihse Bursie wrote: > Do you need to test the entire JDK, or just hotspot? We could get away with just testing hotspot, I would reiterate my previous comments though around ramping down some of the Linux x86 testing if you're concerned about executor tim

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v3]

2022-03-10 Thread George Adams
On Thu, 10 Mar 2022 12:27:56 GMT, Magnus Ihse Bursie wrote: > While to code itself looks like its doing what it claims to do, I wonder > about the reason for doing this. This will slurp up even more CPU minutes > from the individual OpenJDK contributors free GitHub allowance, and > potentially

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v3]

2022-03-10 Thread George Adams
> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests > too if people think that would be useful but for now I've left it as just > build. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremen

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v2]

2022-03-10 Thread George Adams
> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests > too if people think that would be useful but for now I've left it as just > build. George Adams has updated the pull request incrementally with one additional commit since the last revision: change

RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check

2022-03-10 Thread George Adams
Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests too if people think that would be useful but for now I've left it as just build. - Commit messages: - fix sha256 command - add alpine github action Changes: https://git.openjdk.java.net/jdk/pull/7771/files

RFR: 8254846 Warn before building if Xcode has no disk space left

2021-04-26 Thread George Adams
This PR creates a simple sanity check for all systems to verify that there is at least 6 GB available disk space before compiling. I got the 6 GB requirement from https://github.com/openjdk/jdk/blob/master/doc/building.md#building-on-x86 - Commit messages: - ensure that system has

Integrated: 8265531: doc/building.md should mention homebrew install freetype

2021-04-23 Thread George Adams
On Tue, 20 Apr 2021 14:58:02 GMT, George Adams wrote: > Updates the docs/building.html guide to include steps to install FreeType on > macOS using homebrew. This pull request has now been integrated. Changeset: 5aab1609 Author:George Adams Committer: Erik Joelsson URL:

Re: RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-23 Thread George Adams
On Thu, 22 Apr 2021 16:12:24 GMT, Erik Joelsson wrote: >> Updates the docs/building.html guide to include steps to install FreeType on >> macOS using homebrew. > > Marked as reviewed by erikj (Reviewer). @erikj79 are you happy to sponsor this PR? - PR: https://git.openjdk.java.net

RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-22 Thread George Adams
Updates the docs/building.html guide to include steps to install FreeType on macOS using homebrew. - Commit messages: - add macOS freetype install steps to docs/building.html Changes: https://git.openjdk.java.net/jdk/pull/3590/files Webrev: https://webrevs.openjdk.java.net/?repo=j