Integrated: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-11-02 Thread Hannes Wallnöfer
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI [v2]

2021-10-20 Thread Hannes Wallnöfer
printStackTrace() Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision: Update copyright years - Changes: - all: https://git.openjdk.java.net/jdk/pull/6011/files - new: https://git.openjdk.java.net/jdk/pull/6011/files/8aa

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-20 Thread Hannes Wallnöfer
On Tue, 19 Oct 2021 16:14:37 GMT, Pavel Rappo wrote: >> Please review a change to add a copy-to-clipboard feature to snippets. I >> took special care to make the feature usable on mobile devices. Sample >> output can be viewed and tested here: >> >> http://cr.openjdk.java.net/~hannesw/8275406/

RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-19 Thread Hannes Wallnöfer
Please review a change to add a copy-to-clipboard feature to snippets. I took special care to make the feature usable on mobile devices. Sample output can be viewed and tested here: http://cr.openjdk.java.net/~hannesw/8275406/api.00/java.base/java/lang/Throwable.html#printStackTrace() -

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-21 Thread Hannes Wallnöfer
On Tue, 21 Sep 2021 15:27:12 GMT, Daniel Fuchs wrote: >> I just realized I commented on a test file, while the actual culprit is in >> `FileServerHandler.java`. But I guess it applies to all usages of this class >> and method. > > Hmm... When printing messages on the console don't we want a loc

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-21 Thread Hannes Wallnöfer
On Tue, 21 Sep 2021 14:59:18 GMT, Hannes Wallnöfer wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-21 Thread Hannes Wallnöfer
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: JDK-8272374: doclint should report missing "body" comments

2021-08-16 Thread Hannes Wallnöfer
On Fri, 13 Aug 2021 03:51:23 GMT, Jonathan Gibbons wrote: > Please review a relatively simple update to have doclnt check for empty > "descriptions" -- the body of a doc comment, before the block tags. > > It is already the case that doclint checks for missing/empty descriptions in > block tag

Integrated: JDK-8263468: New page for "recent" new API

2021-06-08 Thread Hannes Wallnöfer
On Wed, 26 May 2021 16:02:29 GMT, Hannes Wallnöfer wrote: > This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:53:55 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > > src/jdk.javadoc/share/classes/jdk/ja

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 15:27:21 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8263468

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:52:57 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > > src/jdk.javadoc/share/classes/jdk/ja

Re: RFR: JDK-8263468: New page for "recent" new API [v4]

2021-06-07 Thread Hannes Wallnöfer
erated documentation here: > > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/new-list.html > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/deprecated-list.html Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision: J

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
erated documentation here: > > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/new-list.html > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/deprecated-list.html Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-05-28 Thread Hannes Wallnöfer
On Thu, 27 May 2021 13:32:36 GMT, Erik Joelsson wrote: >> Yes, there are a few things, but in the build itself, we are down to a >> single config file today, so I would really appreciate if this could be >> figured out. I can provide the implementation for generating this, but I >> need to und

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-05-28 Thread Hannes Wallnöfer
erated documentation here: > > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/new-list.html > http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/deprecated-list.html Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Hannes Wallnöfer
On Thu, 27 May 2021 12:52:34 GMT, Erik Joelsson wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relatively m

RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Hannes Wallnöfer
This adds a new kind of summary list for new API added in specific releases, and adds information to the deprecated API list about elements that were deprecated in the given releases. The changes to the code are relatively minor thanks to the existing infrastructure for summary list pages, whic

Re: [jdk16] RFR: JDK-8247994: Localize javadoc search [v4]

2020-12-17 Thread Hannes Wallnöfer
On Thu, 17 Dec 2020 17:10:10 GMT, Jonathan Gibbons wrote: >> This is for JDK16, as a precursor to fixing JDK-8258002. >> >> While it is good to be using localized strings in the generated output, the >> significance for JDK-8258002 is that the strings are now obtained from a >> resource file,

Re: [jdk16] RFR: JDK-8247994: Localize javadoc search [v3]

2020-12-17 Thread Hannes Wallnöfer
On Thu, 17 Dec 2020 16:39:17 GMT, Jonathan Gibbons wrote: >> This is for JDK16, as a precursor to fixing JDK-8258002. >> >> While it is good to be using localized strings in the generated output, the >> significance for JDK-8258002 is that the strings are now obtained from a >> resource file,

Re: [jdk16] RFR: JDK-8247994: Localize javadoc search

2020-12-14 Thread Hannes Wallnöfer
On Mon, 14 Dec 2020 09:34:31 GMT, Hannes Wallnöfer wrote: >> This is for JDK16, as a precursor to fixing JDK-8258002. >> >> While it is good to be using localized strings in the generated output, the >> significance for JDK-8258002 is that the strings are now obtained

Re: [jdk16] RFR: JDK-8247994: Localize javadoc search

2020-12-14 Thread Hannes Wallnöfer
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote: > This is for JDK16, as a precursor to fixing JDK-8258002. > > While it is good to be using localized strings in the generated output, the > significance for JDK-8258002 is that the strings are now obtained from a > resource file, and n

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec)

2020-11-04 Thread Hannes Wallnöfer
On Thu, 22 Oct 2020 02:40:44 GMT, Jonathan Gibbons wrote: > This introduces support for a new `@spec` tag that can be used as either an > inline tag or as a block tag. It is used to identify references to external > specifications, in such a way that the references can be collected together >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v2]

2020-10-21 Thread Hannes Wallnöfer
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview API

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Mon, 19 Oct 2020 14:09:51 GMT, Hannes Wallnöfer wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc >> behavior to more closely adhere to JEP 12. >> The notable changes are: >> &g

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac un

Integrated: 8216497: javadoc should auto-link to platform classes

2020-10-07 Thread Hannes Wallnöfer
On Tue, 15 Sep 2020 09:10:54 GMT, Hannes Wallnöfer wrote: > This pull request is identical with the RFR previously sent for the Mercurial > repository: > > https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html > > I'm copy-pasting the comments from

Re: RFR: 8216497: javadoc should auto-link to platform classes [v4]

2020-10-07 Thread Hannes Wallnöfer
e tests to use some static > release or source version, which we don’t want either). I updated the CSR to > the new code. It also needs to be > reviewed: https://bugs.openjdk.java.net/browse/JDK-8251181 > > Thanks, > Hannes Hannes Wallnöfer has updated the pull request with a new targe

Re: RFR: 8216497: javadoc should auto-link to platform classes [v3]

2020-09-23 Thread Hannes Wallnöfer
e tests to use some static > release or source version, which we don’t want either). I updated the CSR to > the new code. It also needs to be > reviewed: https://bugs.openjdk.java.net/browse/JDK-8251181 > > Thanks, > Hannes Hannes Wallnöfer has updated the pull request incrementally

Re: RFR: 8216497: javadoc should auto-link to platform classes [v2]

2020-09-23 Thread Hannes Wallnöfer
On Tue, 22 Sep 2020 17:30:19 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge pull request #1 from lahodaj/JDK-8216497 >> >>Automatic

Re: RFR: 8216497: javadoc should auto-link to platform classes [v2]

2020-09-21 Thread Hannes Wallnöfer
e tests to use some static > release or source version, which we don’t want either). I updated the CSR to > the new code. It also needs to be > reviewed: https://bugs.openjdk.java.net/browse/JDK-8251181 > > Thanks, > Hannes Hannes Wallnöfer has updated the pull request incrementally

Re: RFR: 8216497: javadoc should auto-link to platform classes

2020-09-15 Thread Hannes Wallnöfer
On Tue, 15 Sep 2020 12:56:13 GMT, Erik Joelsson wrote: >> This pull request is identical with the RFR previously sent for the >> Mercurial repository: >> >> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html >> >> I'm copy-pasting the comments from the original RFR bel

Re: RFR: 8216497: javadoc should auto-link to platform classes

2020-09-15 Thread Hannes Wallnöfer
On Tue, 15 Sep 2020 11:30:09 GMT, Jan Lahoda wrote: >> This pull request is identical with the RFR previously sent for the >> Mercurial repository: >> >> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html >> >> I'm copy-pasting the comments from the original RFR below.

RFR: 8216497: javadoc should auto-link to platform classes

2020-09-15 Thread Hannes Wallnöfer
This pull request is identical with the RFR previously sent for the Mercurial repository: https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html I'm copy-pasting the comments from the original RFR below. Most of the new code is added to the Extern class where it fits in qui

Re: RFR [15] JDK-8235926: Update @jls @jvms taglets to allow inline usage

2019-12-17 Thread Hannes Wallnöfer
Hi Jon, Looks good to me. Hannes > Am 13.12.2019 um 22:21 schrieb Jonathan Gibbons : > > Please review a change to the JDK-specific taglet used to generate links to > the JLS and JVMS specifications. The change is to allow instances of these > tags to be used inline as well as in the series

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

2018-06-27 Thread Hannes Wallnöfer
Looks good. Hannes > Am 27.06.2018 um 06:19 schrieb Sundararajan Athijegannathan > : > > Forgot to CC build-dev for makefile changes. > > -Sundar > > On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote: >> Please review. >> >> Bug https://bugs.openjdk.java.net/browse/JDK-8204492 >> Webr