Integrated: 8204541: Correctly support AIX xlC 16.1 symbol visibility flags

2022-03-18 Thread Ichiroh Takiguchi
On Fri, 18 Mar 2022 01:50:56 GMT, Ichiroh Takiguchi wrote: > This change is just for AIX platform with IBM XL C/C++ 16.1. > By this change, lib's entry points are reduced by compilation and linkage > option changes. > > Without changes: > > $ dump -X32_64 -Tv lib/liba

Re: RFR: 8204541: Correctly support AIX xlC 16.1 symbol visibility flags [v2]

2022-03-18 Thread Ichiroh Takiguchi
On Fri, 18 Mar 2022 08:07:53 GMT, Thomas Stuefe wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unexpected comment > > So, does this mean we cannot build with ol

Re: RFR: 8204541: Correctly support AIX xlC 16.1 symbol visibility flags [v2]

2022-03-18 Thread Ichiroh Takiguchi
gt; $ dump -X32_64 -Tv lib/libawt.so | grep EXP | wc > 142 Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision: Remove unexpected comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/7862/files - new: htt

Re: RFR: 8204541: Correctly support AIX xlC 16.1 symbol visibility flags [v2]

2022-03-18 Thread Ichiroh Takiguchi
On Fri, 18 Mar 2022 07:41:28 GMT, Magnus Ihse Bursie wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unexpected comment > > make/autoconf/flags-ldflags.m4 line 80: &g

RFR: 8204541: Correctly support AIX xlC 16.1 symbol visibility flags

2022-03-17 Thread Ichiroh Takiguchi
This change is just for AIX platform with IBM XL C/C++ 16.1. By this change, lib's entry points are reduced by compilation and linkage option changes. Without changes: $ dump -X32_64 -Tv lib/libawt.so | grep EXP | wc 914 With changes $ dump -X32_64 -Tv lib/libawt.so | grep EXP | wc 142

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Ichiroh Takiguchi
. Ichiroh Takiguchi IBM Japan, Ltd. On 2020-02-20 14:10, Sergey Bylokhov wrote: Hello, Christoph. Could you shed some light on the changes below: -statusWindow->fgGC = XCreateGC(dpy, status, valuemask, ); +statusWindow->fgGC = create_gc(status, FALSE); XSetForeground(dpy, status

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Ichiroh Takiguchi
To reviewers, Thank you for reviewing in a short time. Best regards, Ichiroh Takiguchi On 2019-01-29 20:20, Lindenmaier, Goetz wrote: Pushed. Best regards, Goetz -Original Message- From: Ichiroh Takiguchi Sent: Dienstag, 29. Januar 2019 11:30 To: Lindenmaier, Goetz Cc: build-dev

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Ichiroh Takiguchi
Hello Goetz. Thank you for build testing. Yes, I need a sponsor. If possible, could you handle it ? Thanks, Ichiroh Takiguchi On 2019-01-29 19:17, Lindenmaier, Goetz wrote: Hi, this looks good, the build works with this patch. Do you need a sponsor? Best regards, Goetz. -Original

RFR: JDK-8217880 AIX build issue about JDK-8214533

2019-01-28 Thread Ichiroh Takiguchi
Hello. Sorry about build issue for JDK-8214533. EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. Bug:https://bugs.openjdk.java.net/browse/JDK-8217880 Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ Could you review the fix ? Thanks, Ichiroh Takiguchi IBM

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Ichiroh Takiguchi
Hello Goetz. Thank you for your suggestion. I just open JDK-8217880 [1]. I just restart clean build. I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. [1] https://bugs.openjdk.java.net/browse/JDK-8217880 Thanks, Ichiroh Takiguchi On 2019-01-28 22:11, Lindenmaier, Goetz

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-28 Thread Ichiroh Takiguchi
Hello. I'm very sorry. It's my fault. EUC_JP class was moved to java.base module. (sun.nio.cs.EUC_JP). make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and EUC_JP_Open. Could you suggest me how I should provide new webrev files ? Thanks, Ichiroh Takiguchi On 2019-01-28 17:03

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2019-01-14 Thread Ichiroh Takiguchi
Hello Alan. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. Thanks, Ichiroh Takiguchi IBM Japan, Ltd

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-14 Thread Ichiroh Takiguchi
Hello Alan. I opened JDK-8215333 for Charset filtering issue [1]. I cannot wait until JDK-8215333 is closed. Is it possible to put IBM-29626C charset with standard way ? [1] https://bugs.openjdk.java.net/browse/JDK-8215333 Thanks, Ichiroh Takiguchi On 2018-12-10 21:21, Ichiroh Takiguchi wrote

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-10 Thread Ichiroh Takiguchi
Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-12-06 Thread Ichiroh Takiguchi
gensrc/jdk.charsets/sun/nio/cs/ext/ExtendedCharsets.java $ find support/gensrc/ | grep Charsets | xargs grep 29626 $ == I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-11-28 19:10, Magnus Ihse Bursie wrote: On 2018-11-28 10:36, Alan Bat

Re: RFR: 8212794 IBM-964 is required for AIX default charset

2018-12-04 Thread Ichiroh Takiguchi
Hello Roger. Thank you for your suggestion. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212794 Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.04/ Thanks, Ichiroh Takiguchi On 2018-12-04 23:36, Roger Riggs wrote: Hi Ichiroh, On 12/03

Re: RFR: 8212794 IBM-964 is required for AIX default charset

2018-12-04 Thread Ichiroh Takiguchi
to sun.nio.cs package. About IBM33722, If IBM33722 is moved to sun.nio.cs package also, "import sun.nio.cs.*;" is no need on IBM33722.java If IBM33722 is not in stdcs-aix, "import sun.nio.cs.*;" is still required on IBM33722.java Thanks, Ichiroh Takiguchi On 2018-12-04 19:42, Magn

Re: RFR: 8212794 IBM-964 is required for AIX default charset

2018-12-03 Thread Ichiroh Takiguchi
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.03/ Thanks, Ichiroh Takiguchi On 2018-12-04 05:50, Roger Riggs wrote: Hi Ichiroh, src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:     I think this is no longer needed since it only has imports.     By the way, the sty

Re: RFR: 8212794 IBM-964 is required for AIX default charset

2018-11-30 Thread Ichiroh Takiguchi
4" jshell> System.out.println(String.join("\n", cs.aliases())) ibm-964 cp964 ibm-euctw ibm964 964 jshell> /exit | Goodbye $ == I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-11-29 22:39, Ichiroh Takiguchi wrote: Hello Ala

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-29 Thread Ichiroh Takiguchi
fter test is done. I'll post new code. Thanks, Ichiroh Takiguchi On 2018-11-28 19:10, Magnus Ihse Bursie wrote: On 2018-11-28 10:36, Alan Bateman wrote: On 28/11/2018 09:28, Magnus Ihse Bursie wrote: I'm quite unsatisfied with the current handling of character sets in the build in general. :-(

RE: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

2018-06-07 Thread Ichiroh Takiguchi
istoph Subject: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags Hello. Could you review it ? Bug:https://bugs.openjdk.java.net/browse/JDK-8204541 Change: http://cr.openjdk.java.net/~clanger/webrevs/8204541.0/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. Original

RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

2018-06-07 Thread Ichiroh Takiguchi
Hello. Could you review it ? Bug:https://bugs.openjdk.java.net/browse/JDK-8204541 Change: http://cr.openjdk.java.net/~clanger/webrevs/8204541.0/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. Original Message Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-06-05 Thread Ichiroh Takiguchi
ild only with XLC12 . As a workaround you might want to remove the "-qvisibility=hidden" setting for XLC 13 as well , like I did for XLC12 with the change 8202322 . Best regards, Matthias -Original Message- From: Langer, Christoph Sent: Freitag, 1. Juni 2018 10:

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

2018-05-31 Thread Ichiroh Takiguchi
Hello. 8202322 was integrated into jdk-11+15. I'm using XLC 13.1.3 on AIX 7.1.4. Build was failed because of "-qvisibility=hidden" on make/lib/LibCommon.gmk. According to "XL C/C++ for AIX 13.1.3" documentation [1], "-qvisibility=hidden" cannot create shared libraries entry points. For example,

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-14 Thread Ichiroh Takiguchi
Hello Christoph. Our team tested your fixed code on Linux (RHEL7) and AIX (7.1). resetCompositionState() was missing in src/java.desktop/aix/classes/sun/awt/X11InputMethod.java ---