Integrated: JDK-8284858: Start of release updates for JDK 20

2022-06-09 Thread Joe Darcy
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote: > Time to start getting ready for JDK 20... This pull request has now been integrated. Changeset: edff51e5 Author: Joe Darcy Committer: Erik Joelsson URL: https://git.openjdk.org/jdk/commit/edff51e5fdb5282830ecfb3792a88c7b28ca6

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v6]

2022-06-08 Thread Joe Darcy
> Time to start getting ready for JDK 20... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 44 additional commits since the last revis

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v5]

2022-06-02 Thread Joe Darcy
> Time to start getting ready for JDK 20... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revis

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v4]

2022-05-31 Thread Joe Darcy
> Time to start getting ready for JDK 20... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 38 additional commits since the last revis

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v3]

2022-05-31 Thread Joe Darcy
> Time to start getting ready for JDK 20... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revis

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Joe Darcy
On Thu, 26 May 2022 22:38:12 GMT, David Holmes wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/java.base/share/classes/jdk/internal/org/objectwe

Re: RFR: JDK-8284858: Start of release updates for JDK 20

2022-05-26 Thread Joe Darcy
On Thu, 26 May 2022 22:40:59 GMT, Kevin Rushforth wrote: > You also need to change the JBS version from 19 to 20 in > [`.jcheck/conf`](https://github.com/openjdk/jdk/blob/6a33974a6b8a629744c6d76c3b4fa1f772e52ac8/.jcheck/conf#L4): Acknowledged; will fix in the next push. Thanks. -

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Joe Darcy
> Time to start getting ready for JDK 20... Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.java.net/jdk/pull/8236/files - new: ht

RFR: JDK-8284858: Start of release updates for JDK 20

2022-05-26 Thread Joe Darcy
Time to start getting ready for JDK 20... - Commit messages: - Update symbol information for JDK 19 b24. - Merge branch 'master' into JDK-8284858 - Merge branch 'master' into JDK-8284858 - Merge branch 'master' into JDK-8284858 - Merge branch 'master' into JDK-8284858 - Merge

Re: RFR: JDK-8284858: Start of release updates for JDK 20

2022-05-26 Thread Joe Darcy
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote: > Time to start getting ready for JDK 20... The expected kinds of updates to start up JDK 20. - PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-05-09 Thread Joe Darcy
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Joe Darcy
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

Integrated: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

2022-01-21 Thread Joe Darcy
On Thu, 20 Jan 2022 19:03:36 GMT, Joe Darcy wrote: > Update of JDK 18 symbol information for build 32. > > @lahodaj , can you take a look at the diff? Given the code changes for > JDK-8270416: "Enhance construction of Identity maps" > (https://gith

Re: RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

2022-01-21 Thread Joe Darcy
On Fri, 21 Jan 2022 18:39:02 GMT, Jan Lahoda wrote: > I believe this is an artifact of limited optimization of the InnerClasses > attribute: if the InnerClasses attribute refers to a class that is not part > of `ct.sym`, then it is stripped, but if the class is part of ct.sym, the > code does

RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

2022-01-20 Thread Joe Darcy
Update of JDK 18 symbol information for build 32. @lahodaj , can you take a look at the diff? Given the code changes for JDK-8270416: "Enhance construction of Identity maps" (https://github.com/openjdk/jdk/commit/5832a3440489d0967dc3b0542c1ace51eed292d6), I didn't see why the symbol update was

Integrated: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

2022-01-05 Thread Joe Darcy
On Mon, 3 Jan 2022 18:26:24 GMT, Joe Darcy wrote: > Usual update to the JDK 19 symbol files for changes in JDK 18; this time > JDK-8276660 in JDK 18 build 28. This pull request has now been integrated. Changeset: 9a0e8900 Author: Joe Darcy URL: https://git.openjdk.java.n

RFR: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

2022-01-03 Thread Joe Darcy
Usual update to the JDK 19 symbol files for changes in JDK 18; this time JDK-8276660 in JDK 18 build 28. - Commit messages: - JDK-8277515: Update --release 18 symbol information for JDK 18 build 29 Changes: https://git.openjdk.java.net/jdk/pull/6948/files Webrev:

Integrated: JDK-8273146: Start of release updates for JDK 19

2021-12-09 Thread Joe Darcy
On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy wrote: > The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.REL

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v9]

2021-12-06 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

2021-12-06 Thread Joe Darcy
On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote: > The "missing-explicit-ctor" check was disabled by the > [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was > fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). > So we can re-enable

Integrated: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-06 Thread Joe Darcy
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) This pull request has now bee

RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-05 Thread Joe Darcy
Exploratory builds indicate it is not currently necessary to exclude the doclint accessibility checks; this patch enables them. (Enabling the reference checks is left for future work.) - Commit messages: - JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patc

Integrated: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patc

Integrated: JDK-8278179: Enable all doclint warnings for build of java.naming

2021-12-03 Thread Joe Darcy
On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy wrote: > An exploratory build indicates that it is not necessary to disable the > accessibility doclint check for the java.naming module. This pull request has now been integrated. Changeset: 780b8b10 Author: Joe Darcy URL:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v8]

2021-12-02 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

RFR: JDK-8278179: Enable all doclint warnings for build of java.naming

2021-12-02 Thread Joe Darcy
An exploratory build indicates that it is not necessary to disable the accessibility doclint check for the java.naming module. - Commit messages: - JDK-8278179: Enable all doclint warnings for build of java.naming Changes: https://git.openjdk.java.net/jdk/pull/6688/files Webrev:

RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

2021-12-02 Thread Joe Darcy
In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. Therefore, it is now possible to enable the full doclint checks for the java.desktop module if the instances of warnings are suppressed. This patch does this; it would be preferable to address the doc warnings directly, but

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v7]

2021-12-02 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v6]

2021-11-30 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now conta

Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

2021-11-29 Thread Joe Darcy
On Mon, 29 Nov 2021 19:05:59 GMT, Vicente Romero wrote: > Hi, > > Please review this PR which is basically rewriting some redundant boolean > expressions in the compiler. > > TIA make/langtools/tools/compileproperties/CompileProperties.java line 187: > 185: } > 186:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

2021-11-29 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v4]

2021-11-28 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exclu

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v3]

2021-11-23 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exclu

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v26]

2021-11-22 Thread Joe Darcy
On Mon, 22 Nov 2021 12:09:30 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-21 Thread Joe Darcy
On Mon, 22 Nov 2021 04:17:44 GMT, David Holmes wrote: > Hi Joe, > > I looked at all the non-sym file changes. Only one potential issue spotted. > > Thanks, David *sigh* Yep; cut and paste error -- corrected in next push. Well spotted! Thanks David - PR:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-21 Thread Joe Darcy
K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revisi

RFR: JDK-8273146: Start of release updates for JDK 19

2021-11-21 Thread Joe Darcy
The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates: JDK-8277512: Add SourceVersion.RELEASE_19 https://bugs.openjdk.java.net/browse/JDK-8277512 JDK-8277514: Add source 19 and target 19

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Joe Darcy
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v4]

2021-09-28 Thread Joe Darcy
;) or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Darcy ha

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v3]

2021-09-28 Thread Joe Darcy
;) or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Darcy has

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v2]

2021-09-27 Thread Joe Darcy
;) or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Darcy has

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Joe Darcy
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: JDK-8272667: substandard error messages from the docs build

2021-08-18 Thread Joe Darcy
On Wed, 18 Aug 2021 22:06:13 GMT, Jonathan Gibbons wrote: > Please review a small (delete one character) change to improve the error > messages reported when bad HTML is detected when post-processing the output > from pandoc to generate the docs. > > The change is just to pass the filename as

Re: RFR: 8272067: Initial nroff manpage generation for JDK 18

2021-08-05 Thread Joe Darcy
On Fri, 6 Aug 2021 01:53:51 GMT, David Holmes wrote: > Please review this trivial update to the generated manpages that updates > their version from "JDK 17" to "JDK 18-ea". > > Thanks, > David Marked as reviewed by darcy (Reviewer). - PR:

RFR: 8269689: Update --release 17 symbol information for JDK 17 build 31

2021-07-18 Thread Joe Darcy
Usual kind of updates for the symbol information in JDK 18 to reflect changes in the JDK 17 API. Bug fixes with API changes since JDK 17 b28 include JDK-8266313, JDK-8268972, and JDK-8266269. - Commit messages: - 8269689: Update --release 17 symbol information for JDK 17 build 31

Integrated: 8268637: Update --release 17 symbol information for JDK 17 build 28

2021-06-30 Thread Joe Darcy
On Wed, 30 Jun 2021 16:54:57 GMT, Joe Darcy wrote: > JDK 17 b28 had two fixes which updated the symbol information. A > CallerSensitive annotation was removed as part of JDK-8268349 and API changes > in JDK-826. > > These should be reflected in the JDK 18 symbol inf

RFR: 8268637: Update --release 17 symbol information for JDK 17 build 28

2021-06-30 Thread Joe Darcy
JDK 17 b28 had two fixes which updated the symbol information. A CallerSensitive annotation was removed as part of JDK-8268349 and API changes in JDK-826. These should be reflected in the JDK 18 symbol information for 17. - Commit messages: - 8268637: Update --release 17

Integrated: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Joe Darcy
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. This pull request has now been integrated. Changeset: a466b49e Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/a466b49e71b0d235294e17faba47ed4fd3fb8f6e St

RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Joe Darcy
Update symbol files in JDK 18 for changes in JDK 17 b26. - Commit messages: - 8267634: Update --release 17 symbol information for JDK 17 build 26 Changes: https://git.openjdk.java.net/jdk/pull/4477/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4477=00 Issue:

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Joe Darcy
On Fri, 11 Jun 2021 13:09:55 GMT, Jan Lahoda wrote: > [this is an improved version of openjdk/jdk PR: > https://github.com/openjdk/jdk/pull/4428 > ] > > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation

Re: RFR: 8266036: class file for sun.misc.Contended not found

2021-06-10 Thread Joe Darcy
On Wed, 9 Jun 2021 11:05:37 GMT, Jan Lahoda wrote: > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If > javac will try to load them (while discovering annotations for the purpose of >

Integrated: 8267630: Start of release updates for JDK 18

2021-06-10 Thread Joe Darcy
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 This pull request has now been integrated. Changeset: b018c450 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/b018c450e5e4737ccd08ed505fd06cee16c42648 Stats: 5

Re: RFR: 8267630: Start of release updates for JDK 18 [v11]

2021-06-10 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits: - Merge branch 'master' into 8267630 - Update copyright year. - Merge branch 'master' into 8267630 - Me

Re: RFR: 8267630: Start of release updates for JDK 18 [v10]

2021-06-10 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Update copyright year. - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Me

Re: RFR: 8267630: Start of release updates for JDK 18 [v9]

2021-06-09 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267

Re: RFR: 8267630: Start of release updates for JDK 18 [v8]

2021-06-09 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267

Re: RFR: 8267630: Start of release updates for JDK 18 [v7]

2021-06-08 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267

Re: RFR: 8267630: Start of release updates for JDK 18 [v6]

2021-06-08 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

2021-06-07 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revis

Integrated: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Joe Darcy
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > htt

RFR: 8268299: jvms tag produces incorrect URL

2021-06-06 Thread Joe Darcy
The @jls and @jvms taglet share most of their functionality. A JLS URL looks like https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 and a JVMS URL looks like https://docs.oracle.com/javase/specs/jvms/se16/html/**jvms**-4.html#jvms-4.3.2 The current taglet

Re: RFR: 8267630: Start of release updates for JDK 18 [v4]

2021-06-05 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v3]

2021-06-03 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v2]

2021-06-03 Thread Joe Darcy
> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revis

RFR: 8267630: Start of release updates for JDK 18

2021-06-02 Thread Joe Darcy
8267630: Start of release updates for JDK 18 - Commit messages: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into

Re: RFR: 8267630: Start of release updates for JDK 18

2021-06-02 Thread Joe Darcy
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 JDK 18 is right around the corner, time for the usual start-of-release changeset for review. Typical structure for these kinds of changes. I'll update the symbol file information of JDK 17

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Darcy
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

2021-04-17 Thread Joe Darcy
On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. Marked as reviewed by darcy (Reviewer). - PR:

Integrated: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Joe Darcy
On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote: > With recent cleanups, several doclint categories have been cleared across the > JDK and should be enabled in the javadoc build to make sure they stay clean. > > Local docs build completes with this stricter set of checks. This

RFR: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Joe Darcy
With recent cleanups, several doclint categories have been cleared across the JDK and should be enabled in the javadoc build to make sure they stay clean. Local docs build completes with this stricter set of checks. - Commit messages: - 8262893: Enable more doclint checks in

Integrated: 8259512: Update --release 16 symbol information for JDK 16 build 31

2021-01-08 Thread Joe Darcy
On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy wrote: > Using the symbol updating script, update the symbol files for API changes in > JDK 16 build 31. This pull request has now been integrated. Changeset: a6539282 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/a6

RFR: 8259512: Update --release 16 symbol information for JDK 16 build 31

2021-01-08 Thread Joe Darcy
Using the symbol updating script, update the symbol files for API changes in JDK 16 build 31. - Commit messages: - 8259512: Update --release 16 symbol information for JDK 16 build 31 Changes: https://git.openjdk.java.net/jdk/pull/2010/files Webrev:

Integrated: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

2021-01-06 Thread Joe Darcy
On Wed, 6 Jan 2021 02:19:51 GMT, Joe Darcy wrote: > Updating to the symbol files for JDK 16 b30; change generated with the script > > make/scripts/generate-symbol-data.sh > > The change to the java.desktop module looks to be for JDK-8258373. This pull request has now

RFR: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

2021-01-05 Thread Joe Darcy
Updating to the symbol files for JDK 16 b30; change generated with the script make/scripts/generate-symbol-data.sh The change to the java.desktop module looks to be for JDK-8258373. - Commit messages: - 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

RFR: 8257457: Update --release 16 symbol information for JDK 16 build 28

2020-12-12 Thread Joe Darcy
Update symbol information for --release 16 to JDK 16 b28, includes updates for JEP 390. - Commit messages: - 8257457 Changes: https://git.openjdk.java.net/jdk/pull/1754/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1754=00 Issue:

Integrated: 8257450: Start of release updates for JDK 17

2020-12-10 Thread Joe Darcy
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. This pull request has now been integrated. Changeset: 6be1f567 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/6be1f567 Stats: 7607 lines in 77 files changed: 7548 ins; 0 del; 59

Re: RFR: 8257450: Start of release updates for JDK 17 [v8]

2020-12-10 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v7]

2020-12-09 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v6]

2020-12-08 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision: - Get in JEP

Re: RFR: 8257450: Start of release updates for JDK 17 [v5]

2020-12-08 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v4]

2020-12-07 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v3]

2020-12-07 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

2020-12-07 Thread Joe Darcy
On Mon, 7 Dec 2020 20:20:58 GMT, Jesper Wilhelmsson wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contain

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

2020-12-07 Thread Joe Darcy
On Mon, 7 Dec 2020 20:08:59 GMT, Jonathan Gibbons wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains eight

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

2020-12-07 Thread Joe Darcy
On Mon, 7 Dec 2020 16:10:42 GMT, Jan Lahoda wrote: > > > The langtools changes look fine to me. There were additions/changes to jcod > files under `test/hotspot/jtreg/runtime/sealedClasses/` made under > JDK-8246778, so these may need an update. Sorry about that. After a merge, the tests in

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

2020-12-07 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Me

Re: RFR: 8257450: Start of release updates for JDK 17

2020-12-04 Thread Joe Darcy
On Tue, 1 Dec 2020 07:38:13 GMT, David Holmes wrote: >> Start of JDK 17 updates. > > Looks good - 99% sym stuff :) > > Doesn't look like the hotspot deprecated flag test will need updating this > time, as no newly deprecated flags marked for obsoletion in 17. Usual start of release update: *

RFR: 8257450: Start of release updates for JDK 17

2020-12-04 Thread Joe Darcy
Start of JDK 17 updates. - Commit messages: - Update tests. - Merge branch 'master' into JDK-8257450 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450 - JDK-8257450 -

Re: RFR: 8257450: Start of release updates for JDK 17

2020-12-04 Thread Joe Darcy
On Tue, 1 Dec 2020 07:33:25 GMT, David Holmes wrote: >> Start of JDK 17 updates. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 226: > >> 224: REIFIABLE_TYPES_INSTANCEOF(JDK16, >> Fragments.FeatureReifiableTypesInstanceof, DiagKind.PLURAL), >> 225:

Integrated: 8253753 Enable default constructor warning in client modules

2020-11-27 Thread Joe Darcy
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. This pull request has now been integrated. Changeset: 65137ff0 Author: Joe Darc

RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Joe Darcy
With the default constructors warnings in java.desktop and jdk.accessibility now fixed, the warning should be enabled in the build for those modules. - Commit messages: - Merge branch 'JDK-8253753' of https://github.com/jddarcy/jdk into JDK-8253753 - Update build to enable default

Integrated: 8251549: Update docs on building for Git

2020-11-23 Thread Joe Darcy
On Sat, 5 Sep 2020 20:13:18 GMT, Joe Darcy wrote: > 8251549: Update docs on building for Git This pull request has now been integrated. Changeset: 042734cc Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/042734cc Stats: 68 lines in 1 file changed: 12 ins; 37

Re: RFR: 8251549: Update docs on building for Git [v2]

2020-11-23 Thread Joe Darcy
> 8251549: Update docs on building for Git Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update doc/building.md Co-authored-by: Magnus Ihse Bursie - Changes: - all: https://git.openjdk.java.net/jdk/pull/21/fi

Re: RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Joe Darcy
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. Marked as reviewed by darcy (Reviewer).

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-11 Thread Joe Darcy
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8248984: Bump minimum boot jdk to JDK 15

2020-09-23 Thread Joe Darcy
On Wed, 23 Sep 2020 22:32:37 GMT, Mikael Vidstedt wrote: > JDK 15 is now GA. The minimum boot JDK version for mainline/JDK 16 should be > bumped to this version. > > Testing: tier1-5 passed with a slightly earlier version of this change. > Re-running tier1 now for good luck. Marked as

Integrated: 8253034: Update symbol generation to accomodate Git as the SCM

2020-09-15 Thread Joe Darcy
On Mon, 14 Sep 2020 23:41:52 GMT, Joe Darcy wrote: > The symbol generation script assumed Mercurial was being used as the SCM. > This should now be updated to Git. This pull request has now been integrated. Changeset: fc36328d Author: Joe Darcy URL: https://git.openjdk.java.n

Re: RFR: 8253034: Update symbol generation to accomodate Git as the SCM [v2]

2020-09-15 Thread Joe Darcy
> The symbol generation script assumed Mercurial was being used as the SCM. > This should now be updated to Git. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback - Changes: - all:

  1   2   3   >