Build Group Lead resignation

I wish to resign as Build Group Lead. It makes much more sense for someone closer to the OpenJDK build issues to be the lead of this group. I would like to stay a group member and keep up-to-date on the activities, but I am unable to take on any significant role at this time. According to the

Re: build warnings

On Dec 3, 2014, at 3:09 AM, Magnus Ihse Bursie wrote: > On 2014-12-02 22:59, Jonathan Gibbons wrote: >> Build folk, >> >> The build has always generated warnings (sigh!) but right now, the warnings >> look scarier than usual. >> >> In particular, when the build terminates, I get a couple of

Re: Adding hg version check to get_source.sh?

Seems reasonable to me. -kto On Jun 17, 2014, at 2:35 PM, Mike Duigou wrote: > With the upgrade of the hg.openjdk.java.net servers very old mercurial > clients can no longer be used (0.9.5) and there have been persistent reports > of more frequent connection failures. The older your mercurial

Re: When will JDK 9 builds move to requiring the boot JDK be JDK 8?

e7fbdd1dcb/make/GensrcCorba.gmk > > And uses this bootstrap idlj to compile the idl files, so at least that odd > boot jdk dependency is removed. > > //Fredrik > > > > > 2014-04-04 17:57 GMT+02:00 Kelly O'Hair : > As I recall, corba builds do some code g

Re: When will JDK 9 builds move to requiring the boot JDK be JDK 8?

As I recall, corba builds do some code generation with idlj, which is in corba I think, so a boot jdk version of idlj would need to be built and run with the boot jdk, then you could build everything with the new jdk. Or so I recall.. -kto On Apr 3, 2014, at 11:54 PM, Fredrik Öhrström wrote: >

Re: CFV: Nomination of Tim Bell as the new Build Group Lead

Vote: yes --- Tim realizes that this is not a paid gig, right? ;) -kto - “The best argument against democracy is a five-minute conversation with the average voter.” ― Winston Churchill On Apr 2, 2014, at 2:58 AM, Magnus Ihse Bursie wrote: > Since Kelly O'Hair has resigned as Gr

Re: CFV: Nomination of Tim Bell as the new Build Group Lead

Do I get to vote? Am I still a member of the Build Group? ;) -kto On Apr 2, 2014, at 2:58 AM, Magnus Ihse Bursie wrote: > Since Kelly O'Hair has resigned as Group Lead, we need to elect a new Group > Lead. > > I hereby nominate Tim Bell as the new Build Group Lead. With

Notice: Build Group Lead resignation

I am not able to actively work with the OpenJDK community, and therefore at this time, I wish to resign as Build Group Lead. According to the bylaws, any member of the Build Group [1] can now nominate a successor to the role of Group Lead. -kto [1] http://openjdk.java.net/census#build

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

Or maybe tr -d '[:space:]' ??? -kto On Dec 4, 2013, at 3:48 AM, Dave Pointon wrote: > On Wed, 2013-12-04 at 10:45 +0100, Erik Joelsson wrote: >> Hello Mike, >> >> I think sed on some platforms doesn't support the [[:space:]] >> expression. I tried the line on a Solaris machine and it did

Re: CFV: New Build Group Member: Magnus Ihse Bursie

Vote: yes -kto On Dec 3, 2013, at 2:53 AM, Erik Joelsson wrote: > I hereby nominate Magnus Ihse Bursie to Membership in the OpenJDK Build > Group. > > Magnus Ihse Bursie is a Committer to JDK 8 and to the Build Infrastructure > Project. Magnus is a member of the JDK Infrastructure team in St

Re: [7u]: help on jdk/make/common/shared/Defs-windows.gmk

I remember cygwin having some goofy behaviors with upper case, e.g. for Z:/. /cygdrive/Z/ vs. /cygdrive/z/ just a thought... -kto On Nov 20, 2013, at 12:11 PM, Francis ANDRE wrote: > Erik > > >>How are you invoking the build to cause this error? Are you explicitly > >>setting ALT_OUTPUTDIR

Re: Le roi est mort, vive le roi!

On Nov 18, 2013, at 10:49 AM, Kelly O'Hair wrote: > > I found an appropriate tombstone: > > > > -kto > > On Nov 18, 2013, at 10:02 AM, Magnus Ihse Bursie wrote: > >> So, finally it has happened. The old build system is now removed. The patch >&g

Re: Le roi est mort, vive le roi!

I found an appropriate tombstone: -kto On Nov 18, 2013, at 10:02 AM, Magnus Ihse Bursie wrote: > So, finally it has happened. The old build system is now removed. The patch > was just submitted to the tl forest, from where it will move to master in a > few days. > > If you have personal sc

Re: Removal of the old build system, partial review

9, or an 8 Update. > > -Chris. > > On 10/31/2013 04:03 PM, Kelly O'Hair wrote: >> >> On Oct 31, 2013, at 7:49 AM, Alan Bateman wrote: >> >>> On 31/10/2013 14:38, Chris Hegarty wrote: >>>> What are we gaining by removing this in jdk8? Does it mak

Re: Removal of the old build system, partial review

On Oct 31, 2013, at 7:49 AM, Alan Bateman wrote: > On 31/10/2013 14:38, Chris Hegarty wrote: >> What are we gaining by removing this in jdk8? Does it make sense to do it as >> one of the first pushes to 9? > The old build is currently a tax, and a tax that will continue into the 8 > updates unt

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

Nice. I think deleting code should be like hazard pay, double the normal hourly wage, but deleting Makefile lines should be triple wage. :) Looks great to me. Not that I use this makefile much anymore. -kto On Aug 27, 2013, at 4:17 PM, Mike Duigou wrote: > Hello all; > > I have updated the

Re: jdk8 build times

; On 2013-08-09 03:32, Pete Brunet wrote: >>>>>> Haven't rebuilt a release version yet for a true comparison but >>>>>> here are >>>>>> my fastdebug times with anti-virus turned off; about the same as >>>>>> release &

Re: Jarreorder and classlists

You should check with the Hotspot runtime team. I seem to recall this might have some connection to class data sharing (cds) in the VM. I agree that we should toss it if it is not needed. I've always wondered if it was just a complication we did not need anymore. -kto On Aug 19, 2013, at 8:17

Re: jdk8 build times

4. Using a debug jdk as your boot jdk :) Langtools taking 6 minutes is crazy long. Since there is no native code there, #1 would be my first guess. -kto On Aug 5, 2013, at 5:54 PM, Weijun Wang wrote: > From my experiences there are 3 reasons a compile could be slow: > > 1. Anti-Virus program

Re: Solaris/x86 build - dtrace syntax error near "umpiconninfo_t"

Standard Solaris 10 X86 machine setup procedure with the JPRT systems is to run ( cd /usr/lib/dtrace && gzip mpi.d ) as root user. I gave up a long time ago ever expecting a fix for this. -kto On Jul 31, 2013, at 5:52 PM, David Holmes wrote: > Hi Ioi, > > This is an old known issue. Simples

Re: Request for review and approval to fix 8012366 in 7update

How did BUILD_INSTALL ever become true on an OpenJDK build? -kto On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: > All- > > My fix for 8007815 [1] did not handle the case of an OpenJDK build that does > not have the closed source trees. If a user tries to build that far, the > build will fail w

Re: RFR: 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74

On Jun 20, 2013, at 5:27 AM, Erik Joelsson wrote: > > > On 2013-06-20 14:14, David Holmes wrote: >> Hi Erik, >> >> On 20/06/2013 6:07 PM, Erik Joelsson wrote: >>> Simple patch removing unnecessary check for existence of mercurial for >>> getting the hgtips for the release file. This check prev

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

On Jun 17, 2013, at 5:21 PM, Stuart Marks wrote: > Hi Kelly! You still read this stuff here? :-) I read anything that looks entertaining from entertaining people. ;^) -kto

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

I couldn't find a good way to show me rolling my eyes, but I found this: http://www.tumblr.com/tagged/rolling%20eyes%20gif Rule #1 Nobody reads the README Rule #2 When things go wrong, blame the README I of course have no objection to the change, however, I'm not convinced it will help much th

Re: Somewhat wonkier Windows problem

just a build, as if I > were someone outside Oracle playing with Openjdk. I assume my problems are a > subset of the release problem. > > David > > On 2013-05-22, at 6:53 PM, Kelly O'Hair wrote: > >> Windows VS compilers are a pain. Each release has it's

Re: Somewhat wonkier Windows problem

Windows VS compilers are a pain. Each release has it's own unique runtime DLLs, which we must deliver with the JDK, so the build process has to know what that DLL is named, where it is located, and copy it into various places. DLLs created by a newer VS will not like the older VS runtime DLLs.

Re: MacOS build tool selections for JDK8

On May 21, 2013, at 2:18 AM, Erik Joelsson wrote: >> JPRT as far as I know only uses 10.7 systems for builds. The 10.8 systems >> can only be used for testing. > Since we have added the compiler and link args described earlier in this > thread to jdk8 makefiles, I believe we have enabled 10.8 f

Re: Windows configure "issues"

A voice from the past rings out through the forests of repositories, squirting ancient wisdom into the clouds... ;^) Yes, yes, I have indeed gone insane. ;^) The intent with the README-build.html document was as a purely "OpenJDK" document, there should be no "Oracle specific" instructions

Re: AdapterMethodHandle not found

On May 7, 2013, at 1:59 AM, Volker Simonis wrote: > On Tue, May 7, 2013 at 3:10 AM, Pete Brunet wrote: > >> I tried changing my ALT_BOOTDIR from my normal 64 bit 7u21 installation >> to the 7u80 tarball I extracted, but got: >> make[2]: *** No rule to make target >> `../../../build/windows-i586

Re: A couple of questions about the new build system

directly. > > -- > best regards, > Anthony > > On 4/8/2013 20:00, Kelly O'Hair wrote: >> I think it's /showIncludes ??? >> http://msdn.microsoft.com/en-us/library/hdkef6tk%28v=vs.100%29.aspx >> -kto >> On 4/8/13 1:16 AM, "Erik Joelsson" wro

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

Looks ok with me. ;^) -kto On 4/8/13 2:44 AM, "Erik Joelsson" wrote: >Reminder that I would like this reviewed. > >/Erik > >On 2013-03-21 12:49, Erik Joelsson wrote: >> This patch makes it possible to enable sjavac in jprt runs. This is >> achieved by adding -buildenv ENABLE_SJAVAC=true to t

Re: A couple of questions about the new build system

I think it's /showIncludes ??? http://msdn.microsoft.com/en-us/library/hdkef6tk%28v=vs.100%29.aspx -kto On 4/8/13 1:16 AM, "Erik Joelsson" wrote: >I just realized you are probably running on windows and unfortunately >this currently doesn't work there. We use the -M flag for gcc which >outputs

Re: Strange build behavior - can't find basic cygwin utilities

this is problem we have seen before i think the issue was PATH whatever it is someone might want to add to the troubleshooting section of the Readme-builds.html file at the top of the repo Sent from my iPhone On Mar 28, 2013, at 12:50, vladislav karnaukhov wrote: > Hello, > > I'm experie

Re: New build, gobjcopy failure, any clues?

There was a bug in the gobjcopy in Solaris 11.0 that was fixed in 11.1. Check with Dan -kto On Mar 26, 2013, at 7:40 PM, David Holmes wrote: > On 27/03/2013 2:33 AM, David Chase wrote: >> I think I'm doing a vanilla new-build, but obviously I'm not, because it >> fails. >> What should I be lo

Re: Testing OpenJDK under Windows 7 64, problem with Makefile

GNU make 3.81 NOT 3.80, but 3.82 should work too. And I have no idea who wrote up the instructions at: http://java.net/projects/adoptopenjdk/pages/BuildWindows http://java.net/projects/adoptopenjdk/pages/InstallJtreg. The instructions we support are at: http://hg.openjdk.java.net/

Re: 8008977: profiles build broken by Nashorn build changes

It seems to me that using $ in class names when they are NOT Inner Classes is a huge mistake. Mark my words, this will come back to haunt us, multiple times, I guarantee it. -kto On Mar 4, 2013, at 3:20 AM, Erik Joelsson wrote: > The change in ListPathsSafely was needed because in nashorn, the

New official README-builds.html

Please do not 'reply all', send concerns or issues to just the build-dev or build-infra-dev aliases. The very latest README-builds.html file is: http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html This documents the new build makefiles only. As with all documents of this typ

Re: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

On Mar 1, 2013, at 6:44 AM, Alan Bateman wrote: >> It's hard to find something more standard than stddef.h. >> > It's hard to find something as non-standard as Windows. My point was we just > need to double check that this builds okay on Windows, which is does. The only issue I have seen with

Re: Dollar ($) expansion still needs attention

Just FYI... The x+=y is a unique make variable assignment, I think it evaluates the right or the entire variable or something. --- Also, as I recall, very vaguely, at one point in time, some of these Def*.gmk files would get included multiple times in one make process. This caused issues and

Re: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

On Feb 23, 2013, at 12:12 PM, Alan Bateman wrote: > On 23/02/2013 18:06, Martin Buchholz wrote: >> I am actually encountering this in openjdk7 with the old build system. >> I can repro the problem in openjdk8 with the old build system, but not the >> new one. >> >> I don't know if you consider

Re: Review Request: 8008451: Make mac builds on 10.8 work on 10.7

Looks good to me. And thank you for doing the verification. -kto On Feb 20, 2013, at 6:52 AM, Erik Joelsson wrote: > I was wrong, just setting the macros below did not generate 10.7 compatible > bits when built on 10.8. Since I already pushed the old solution (except for > hotspot), I created

Re: recent problems with JFX ant script

There are known conflicts with TMP, TEMP, and TMPDIR with many Windows tools. Having both upper and lowercase names is an additional complication. Worse is that some tools want paths that are pure Windows, like C:\temp, some will accept C:/temp, and some might expect their own path style, like /cy

Re: OpenJDK rebuilding on windows takes a long time

On Feb 14, 2013, at 2:24 AM, Alexander Scherbatiy wrote: > On 2/13/2013 8:45 PM, Kelly O'Hair wrote: >> You are pointing at the fastdebug jdk as your boot jdk, why? >> >> The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else >> will w

Re: Review Request: 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac

These changes look good to me. -kto On Feb 14, 2013, at 8:24 AM, Erik Joelsson wrote: > Here are a series of patches that adds the following to all native compile > lines on macosx: > > -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 > > This is needed to ensure that

Re: build JDK 7 Windows 7: make jdk fails building sounds

es it so magic:). > > Regarding RedHat Cygwin 1.6.9 please see my previous post > (http://mail.openjdk.java.net/pipermail/build-dev/2013-February/007956.html). > > On Wed, Feb 13, 2013 at 6:34 PM, Kelly O'Hair wrote: >> We have been successfully using CYGWIN 1.7.16 for

Re: build JDK 7 Windows 7: make jdk fails building sounds

h installs the current version. > > Randy > > > -Original Message- > From: Kelly O'Hair [mailto:kelly.oh...@oracle.com] > Sent: Wednesday, February 13, 2013 8:01 AM > To: Phil Race > Cc: Randy Nielsen; build-dev@openjdk.java.net > Subject: Re: build JDK 7 Windows 7:

Re: Official Boot JDK [Was: OpenJDK rebuilding on windows takes a long time]

On Feb 13, 2013, at 9:08 AM, Andrew Haley wrote: > On 02/13/2013 04:45 PM, Kelly O'Hair wrote: >> The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else >> will work, although it should, > > Y'know, even I didn't know that. I do now.

Re: OpenJDK rebuilding on windows takes a long time

You are pointing at the fastdebug jdk as your boot jdk, why? The official boot jdk for jdk8 is jdk7u7 we cannot guarantee anything else will work, although it should, when tracking down issues like this, you need to narrow down all the possible differences. I have no idea at this time what the

Re: build JDK 7 Windows 7: make jdk fails building sounds

On Feb 13, 2013, at 8:00 AM, Kelly O'Hair wrote: > FYI.. > > I filed a bug on this, it will be fixed. Apparently builds seemed to work > without DXSDK used, so someone > incorrectly assumed that the DXSDK dependency was no longer needed. A mistake. > > Getting the

Re: build JDK 7 Windows 7: make jdk fails building sounds

e community is that >> it is not publicly available. >> >> Do you have a perspective on how stable-complete the JDK 8 build is or will >> be, especially for Windows? >> >> Randy >> >> -Original Message- >> From: Phil Race [mailto:philip.r.

Re: build JDK 7 Windows 7: make jdk fails building sounds

It is my understanding that this is why we require the use of a specific DirectX SDK. http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#dxsdk -kto On Feb 8, 2013, at 7:07 PM, Randy Nielsen wrote: > "make jdk" fails building JavaX Sounds library in the include file objidl.h.

Re: This simple patch doubles the compile-speed of the hotspot repo on Windows

Got it. Thanks for this. -kto On Feb 4, 2013, at 1:04 AM, Fredrik Öhrström wrote: > Issue filed, on its way in: > http://cr.openjdk.java.net/~ohrstrom/webrev-8007446-add-MP/ > > //Fredrik > > 2013/2/2 Kelly O'Hair : >> Great stuff. Have you filed

Updating jdk8 README files

FYI... I am in the process of updating the OpenJDK8 build readme files. I'm working in the build-infra/jdk8 forest with these files and will update the jdk8/build forest when they near completion. In the meantime, anyone wishing to view the current state can view them through the build-infra/j

Re: RFR: race with nested repos in hgforest.sh

Looks fine to me. -kto On Feb 1, 2013, at 6:40 AM, Chris Hegarty wrote: > [ to build-dev and core-libs-dev, expect reviewer from either, but will > integrate through jdk8/tl ] > > This issue is mainly of interest to Oracle engineers, but it effects the > public hgforest script. > > When hgfo

Re: problem building OpenJDK on Windows 7 in langtools

x27;s much less of an issue than the ant version. -kto On Feb 4, 2013, at 9:21 AM, Kelly O'Hair wrote: > > All paths supplied to the ALT variables and things like ANT_HOME need to be > in the c:/ style paths. > Ignore what the ant scripts echo in error messages, or compiler

Re: problem building OpenJDK on Windows 7 in langtools

All paths supplied to the ALT variables and things like ANT_HOME need to be in the c:/ style paths. Ignore what the ant scripts echo in error messages, or compiler warnings, that's a red herring. So ALT_BOOTDIR in your case needs to be set to C:/OpenJDK/jdk-6u37 and ANT_HOME needs to be C:/Ope

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

Looks ok to me too. -kto On Feb 4, 2013, at 6:06 AM, Erik Joelsson wrote: > CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris > directory for linux. I changed to at least use CLOSED_SRC instead. Verified > on both solaris and linux, open and closed. > > http://cr.o

Re: This simple patch doubles the compile-speed of the hotspot repo on Windows

Great stuff. Have you filed an issue on this? Or shall I? -kto On Feb 1, 2013, at 4:58 AM, Fredrik Öhrström wrote: > ie. use /MP on the cl.exe command line. > > On the build machine (Windows Server 2007, Visual Studio 2010, 32 HT > cores, 64GB ram) configuring with: > > sh configure --enable

Re: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations

Tim, change looks good to me. Let's get this in. Thanks. -kto On Jan 31, 2013, at 1:54 PM, Tim Bell wrote: > On 01/31/13 00:42, David Holmes wrote: >> You mean even though the corba Defs-utils.gmk defines NAWK as awk this isn't >> a problem because it doesn't actually get used? > > Correct. I

Re: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects

I don't use these netbeans projects, but the changes seem fine to me. The copyright on the new files says 2007, I assume they need to say 2013? -kto On Jan 30, 2013, at 12:24 PM, Mike Duigou wrote: > This issue still needs a reviewer. > > Mike > > On Jan 22 2013, at 13:27 , Mike Duigou wrote:

Re: Build failure on windows

On Windows, check your file and directory permissions. -kto On Jan 29, 2013, at 9:25 AM, Sergey Bylokhov wrote: > Hello. > Does anybody know how to fix this error message? > > ## Starting jdk > make[2]: Entering directory > `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' > make[3]: E

Re: New build system problems

On Jan 28, 2013, at 1:02 PM, Martin Buchholz wrote: > > > On Mon, Jan 28, 2013 at 11:58 AM, Kelly O'Hair wrote: >> I would like configure to be executable too, but openjdk has a tradition of >> not allowing executable files in the source repos. > > &

Re: New build system problems

>> I was trying out the shiny new build system. Which is great, and the fact that you provided feedback. Thanks for that. >> >> Problem: configure is not executable - must run bash ./configure >> It's traditional for configure scripts to be executable. >> > I would like configure to be executa

Re: JDK 8 Build Failure

The official boot jdk for jdk8 is jdk7u7. It is unclear what jdk7 update you have. Newer should be fine, and it's quite possible that older ones could work too, but officially, for RE/JPRT builds, we use 7u7. I have never had good luck using the OEL 5 systems, the gcc is too old, but have never

Re: Questionable new-build failure

Please file JBS Issues. And keep in mind every "Solaris 10" system could be different. It depends on which Solaris 10 Update it is, and also potentially if it has all the latest patches or not. We try and use Solaris 10u6 for building, usually with all latest required and recommended patches. T

Re: JDK 8 Build Failure

I would recommend you file a JBS Issue at this time. Don't know when we will be able to track it down. You might try again, with a clean slate, and use make JOBS=2or make JOBS=1 -kto On Jan 25, 2013, at 1:14 AM, dalibor.to...@oracle.com wrote: > I checked out jdk8/jdk8 and gave it a

Re: Encoding problem when building

> On 1/10/2013 1:27 AM, Kelly O'Hair wrote: >> I don't know where this bug has been filed. >> >> I will file one in the new JBS system. >> JDK-8005947 - Windows builds in Chinese environment create generated >> files with Chinese characters >>

Re: Patch : improve common/bin/hgforest.sh python detection

On Jan 17, 2013, at 3:27 AM, Erik Joelsson wrote: >>> >>> PS:- I assume that the make/scripts/hgforest.sh is going away at some point? >> >> Why? What would replace it? >> >> David > common/bin/hgforest.sh was added a while back. Yes, the intention is to replace it, but it's just low on our p

Re: Review Request: 8006520: build-infra: Fix sparkle-framework configure parameter

Looks good. -kto On Jan 17, 2013, at 6:09 AM, Erik Joelsson wrote: > Adding sparkle-framework to bridgeBuild. > > http://cr.openjdk.java.net/~erikj/8006520/webrev.root.01/ > > /Erik

Re: Review Request: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server

Looks ok. -kto On Jan 16, 2013, at 3:12 AM, Erik Joelsson wrote: > Fix for the jre/lib/i386/server/libjsig.diz file which in build-infra > contained the path to the file relative to the file system root instead of > the directory of the file. > > http://cr.openjdk.java.net/~erikj/8006385/webr

Re: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest.

Looks good. -kto On Jan 15, 2013, at 3:13 AM, Erik Joelsson wrote: > This fix adds the missing manifest to sunmscapi.jar. This should fix > javax/crypto/sanity/CheckManifestForRelease.java which is currently failing > for build-infra builds. > > http://cr.openjdk.java.net/~erikj/8006296/webre

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

Ok from me. -kto On Jan 14, 2013, at 5:24 AM, Erik Joelsson wrote: > This didn't quite work as I expected. Found the issue in needing to include > SPEC before Jprt.gmk so that variables from SPEC would be available in > Jprt.gmk at parse time. > > http://cr.openjdk.java.net/~erikj/8006100/web

Re: [8]Review Request: 7162007: Clean up i18n related caches

makefile change is fine, no need to change the new build makefiles at all. -kto On Jan 11, 2013, at 1:18 PM, Naoto Sato wrote: > Hello, > > (To build-dev folks, I am sending this to you as the change includes one > modification in make directory. It is just simply adding a new Java file, so >

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

Looks good. -kto On Jan 11, 2013, at 8:25 AM, Erik Joelsson wrote: > This fixes the bundles target for jprt so that overlay images are bundled up > for solaris 64bit. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ > > Even if several people would like to do away with the overla

Re: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk

Looks good. -kto On Jan 11, 2013, at 1:41 AM, Erik Joelsson wrote: > This small patch fixes a problem with configure, Cygwin and Microsoft SDK > SetEnv.Cmd as reported in this mail: > > http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html > > http://cr.openjdk.java.

Re: Mac problem(?), new build, --with-debug-level=slowdebug

osed forest sh ./configure make all I'm not a trees.py user yet. -kto On Jan 9, 2013, at 2:43 PM, David Chase wrote: > > On 2013-01-09, at 5:26 PM, Kelly O'Hair wrote: > >> Question 1: What specific forest did you get your sources from? >> >> -kto >

Re: Mac problem(?), new build, --with-debug-level=slowdebug

Question 1: What specific forest did you get your sources from? -kto On Jan 9, 2013, at 10:43 AM, David Chase wrote: > Summary: I wanted to debug, I configured thoroughly with slowdebug, but was > not able to debug the result. > > More detailed: > > I configured jdk8tl in common/makefiles, >

Re: Encoding problem when building

ool". I am wondering since it only happens when building > OpenJDK, is it eligible for a Java bug? > In addition, do you have any idea on how to force java programs such as idlj > to use ascii? > > Best regards, > Frank > > On 1/8/2013 3:42 AM, Kelly O'Hair wrot

Re: Review Request: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib

Looks correct. -kto On Jan 9, 2013, at 5:47 AM, Erik Joelsson wrote: > Correcting the symlink to libjli in the macosx jdk bundle. > > http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/ > > > /Erik

Re: Mac build fun

Just for the record, I filed a P4 bug JDK-8005946 - Mac build problems with .DS_Store files so this information about .DS_Store files doesn't get completely lost. Not sure what we can do, but figured I should save the issue. -kto On Jan 9, 2013, at 5:33 AM, David Chase wrote: > > On 2013-01-

Re: Request for Review: Java SE 8 Compact Profiles

On Jan 8, 2013, at 12:02 AM, David Holmes wrote: > I have updated webrevs: > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/ > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ They look ok to me. > > I've addressed the minor suggestions that have been given by Kelly

Re: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation

Looks good. -kto On Jan 8, 2013, at 6:07 AM, Erik Joelsson wrote: > Five classes which in jigsaw will be located in the base module currently > have their native headers generated in a special way (explicitly with javah). > This was because the base module could not be made dependent on the co

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

I need more info on this, what is X_LIBS for, and why remove ALL -R options. I always considered the -R options to be LD options, not library specifications really. The -L and -l options are library specifications, but -R is just a path that gets baked into the .so for runtime access to the libr

Re: Review Request: 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh

Looks fine. -kto On Jan 8, 2013, at 6:21 AM, Erik Joelsson wrote: > When submitting JDK-8005723 to jdk8/build, I missed adding the comparisons of > these files to compare.sh. The implementation was already done in build-infra. > > http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/ > >

Re: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom

Looks fine. -kto On Jan 8, 2013, at 4:56 AM, Erik Joelsson wrote: > The open part of this review. Move handling of --enable-openjdk-only to > before the first custom hook call. > > http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/

Re: Review Request: 8005794: in new infra, how do we change java -version?

Looks fine. -kto On Jan 8, 2013, at 3:03 AM, Erik Joelsson wrote: > Adding a configure parameter --with-user-release-suffix which acts as the > USER_RELEASE_SUFFIX variable used to do. If build number isn't set or is set > to b00, this gets added to the full version string, overriding the defa

Re: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11

So all we need to do is: export MACOSX_DEPLOYMENT_TARGET=10.7 ??? That would be easy. -kto On Jan 7, 2013, at 3:32 PM, David DeHaven wrote: > > Yes, generally added to CFLAGS. Both compilers (clang and gcc) support this > option and will also pick up MACOSX_DEPLOYMENT_TARGET from the enviro

Re: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11

Yeah, that's it -mmacosx-version-min=10.7 it needs to be added to all compile and link lines as I recall. -kto On Jan 7, 2013, at 1:05 PM, David DeHaven wrote: > > -mmacosx-version-min=version ? > > -DrD- > >> In order for the bits created on 10.8 to work on 10.7 (which is what we >> ult

Re: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11

In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was supposedly some kind of compiler option we need to make sure was used on all compiles. I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( -kto O

Re: Encoding problem when building

3.0 -fall -pkgPrefix PortableServer org.omg >>../../../../src/share/classes/org/omg/PortableServer/poa.idl >> >> I checked idlj help but there is no encoding specific option. My >>locale environment vars are listed below >> >>$ locale >>LANG=C &

Re: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11

If someone could document everything that was done to get this working I would appreciate it. We have a bunch of 10.8 macs that we need to figure out how to get them to build the jdk for 10.7 or we have to come up with a better answer. I assume Mac 10.7 support in jdk7u and jdk8 will continue, b

Re: jdk8 Build changes

y. --- Let me know if that answers your questions. -kto > > Cheers > > Steve > > > > On 5 Jan 2013, at 05:07, Kelly O'Hair wrote: > >> Excuse the wide mailing, but it was important to try and reach anyone >> building jdk8. >> >

Re: jdk8 Build changes

On Jan 7, 2013, at 8:33 AM, Tim Bell wrote: > Hi Volker: > >> I always thought that the >> MinGW build would be the default for the >> new build systems but reading your mail this apparently isn't true. >> >> Will the MinGW build just not be the default one or will it not work / not >> be suppo

jdk8 Build changes

Excuse the wide mailing, but it was important to try and reach anyone building jdk8. The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have been changed to use the new build-infra "configure&make" build setup, so it is official, but it still needs to be integrated into the ma

Re: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

Looks ok. -kto On Jan 4, 2013, at 1:21 PM, Erik Joelsson wrote: > Adding support for two more zip files that weren't created in build-infra. > Also adding compare support. > > http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ > > /Erik

Re: Encoding problem when building

I assume someone will file a bug on this? I kind of have my hands full with build-infra right now. -kto On Jan 4, 2013, at 2:02 AM, Alan Bateman wrote: > On 04/01/2013 05:29, Frank Ding wrote: >> Hi Kelly >> I investigated how local specific characters get into generated sources in >> corba m

Re: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra

Looks ok, although I did not do a complete inventory on these package names. The comparisons will have caught any issues. -kto On Jan 4, 2013, at 6:33 AM, Erik Joelsson wrote: > There are a couple of minor changes in build-infra that haven't been merged > to jdk8/build yet. All are small and i

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

kj/8005575/webrev.02/ > > /Erik > > On 2013-01-02 21:55, Kelly O'Hair wrote: >> Looks ok to me. >> >> -kto >> >> On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: >> >>> In build-infra, an attempt at unifying the handling of propertie

Re: Review Request: 8005692: build-infra: Target "all" should do the right thing

Looks ok. -kto P.S. The network and email is REALLY slow today, apologies if you get dups on email, some of my emails seem to be going poof. :^( On Jan 4, 2013, at 4:26 AM, Erik Joelsson wrote: > Small patch for adding overlay-images to the all target on solaris 64-bit > platforms. > > http:

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

Looks ok, and yes David, I know we need to work more on this. -kto On Jan 4, 2013, at 3:14 AM, Erik Joelsson wrote: > This makes build-infra work with pure open builds in jprt. Most of it > contributed by Kelly O'hair. > > http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ > > /Erik

  1   2   3   4   5   6   7   8   9   10   >