Re: RFR: 8253757: Add LLVM-based backend for hsdis

2022-02-18 Thread Ludovic Henry
On Fri, 18 Feb 2022 11:44:04 GMT, Magnus Ihse Bursie wrote: > Third time's a charm! After the two previous closed PRs for this issue, I > think this functionality is finally ready to enter mainline. :) > > This code is at it's core the same as the previous PR. The main C++ hsdis >

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2021-10-15 Thread Ludovic Henry
On Wed, 13 Oct 2021 00:00:22 GMT, Magnus Ihse Bursie wrote: > This patch expands the newly added system for hsdis backends to include LLVM. > > The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, > as published in the never integrated PR >

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2021-10-13 Thread Ludovic Henry
On Wed, 13 Oct 2021 00:00:22 GMT, Magnus Ihse Bursie wrote: > This patch expands the newly added system for hsdis backends to include LLVM. > > The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, > as published in the never integrated PR >

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2021-10-13 Thread Ludovic Henry
On Wed, 13 Oct 2021 00:00:22 GMT, Magnus Ihse Bursie wrote: > This patch expands the newly added system for hsdis backends to include LLVM. > > The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, > as published in the never integrated PR >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]

2021-03-23 Thread Ludovic Henry
On Mon, 22 Mar 2021 12:50:14 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-12-21 Thread Ludovic Henry
On Mon, 21 Dec 2020 16:03:31 GMT, Magnus Ihse Bursie wrote: >> FWIW, I started working on a framework which would add support for >> selectable backends for hsdis. Unfortunately it was not as simple as I >> initially thought, so I had to put it on hold while directing my time to >> working on

Integrated: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-13 Thread Ludovic Henry
On Fri, 9 Oct 2020 15:39:18 GMT, Ludovic Henry wrote: > We made a typo in https://github.com/openjdk/jdk/pull/212 when updating > make/devkit/createWindowsDevkit2017.sh. This pull request has now been integrated. Changeset: 715e24af Author:Ludovic Henry Committer: Tobias Hartman

Re: RFR: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-12 Thread Ludovic Henry
On Fri, 9 Oct 2020 16:09:27 GMT, Erik Joelsson wrote: >> We made a typo in https://github.com/openjdk/jdk/pull/212 when updating >> make/devkit/createWindowsDevkit2017.sh. > > Marked as reviewed by erikj (Reviewer). @TobiHartmann as you reported

RFR: 8254311: Incorrect statements in createWindowsDevkit2017.sh

2020-10-09 Thread Ludovic Henry
8254311: Incorrect statements in createWindowsDevkit2017.sh - Commit messages: - 8254311: Incorrect statements in createWindowsDevkit2017.sh Changes: https://git.openjdk.java.net/jdk/pull/581/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=581=00 Issue:

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-10-08 Thread Ludovic Henry
On Thu, 8 Oct 2020 18:07:59 GMT, Ludovic Henry wrote: >>> 1 question: binutils seems to support Windows AArch64. Did you try recently >>> binutils? If we can use binutils on Windows >>> AArch64, you can fix makefile only. >>> https://sourceware.org/git/?

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-10-08 Thread Ludovic Henry
On Thu, 8 Oct 2020 12:30:13 GMT, Bernhard Urban-Forster wrote: >> IMHO, it's great to have an alternative disassembler. I personally had >> better experience using llvm MC when I decoded >> aarch64 and AVX instructions than BFD. Another argument is that LLVM >> toolchain is supposed to

RE: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v12]

2020-10-02 Thread Ludovic Henry
It’s me who made a mistake. This PR should be associated with JEP 388 as you are rightly pointing out. From: Daniel D. Daugherty Sent: Thursday, October 1, 2020 3:05 PM To: Ludovic Henry ; David Holmes ; David Holmes ; Andrew Haley ; Chris Plummer ; Magnus Ihse Bursie ; build-dev

RE: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v12]

2020-10-01 Thread Ludovic Henry
Hi David, > The JEP is not yet targeted so we have to wait for that formality. But once > that happens I can sponsor for you. Perfect, I didn't know about the need for the JEP to be targeted before the merge. > Also note that the PR references the wrong JEP so can you please edit the >

RE: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v12]

2020-10-01 Thread Ludovic Henry
Hi, As we now have a whole bunch of reviews (thank you all!), we would need a sponsor to get it merged. Thank you :) - PR: https://github.com/openjdk/jdk/pull/212

RE: Preliminary review for new WINENV support

2020-08-24 Thread Ludovic Henry
Hi Magnus, I want to follow up on this work of yours, as we've particular interest in it for the Windows-AArch64 port. Let me know how I could assist you in this effort. Thank you, -- Ludovic -Original Message- From: build-dev On Behalf Of Yasumasa Suenaga Sent: Wednesday, July 8,

Re: OpenJDK extension to AArch64 and Windows

2020-07-07 Thread Ludovic Henry
Auxiliary/Build" $DEVKIT_ROOT/VC/Auxiliary/ mkdir -p $DEVKIT_ROOT/VC/redist +cp -r "$VS_INSTALL_DIR/$REDIST_SUBDIR/arm64" $DEVKIT_ROOT/VC/redist/ cp -r "$VS_INSTALL_DIR/$REDIST_SUBDIR/x64" $DEVKIT_ROOT/VC/redist/ cp -r "$VS_INSTALL_DIR/$REDIST_SUBDIR/x86" $DEVKIT_R

Re: Preliminary review for new WINENV support

2020-07-07 Thread Ludovic Henry
your change, even without adding the targetting for Windows-AArch64. The following diff [2] integrates such support for cross-compilation without adding Windows-AArch64: [2] Diff to add support for cross-compilation commit c23c78e33e57955d3f344383619592f34b84169b Author: Ludovic Henry Date: Tue

Re: OpenJDK extension to AArch64 and Windows

2020-06-29 Thread Ludovic Henry
different components relying on it - and I've to say it wasn't straightforward to understand how all the pieces fit together. I'd be happy to work out with you a better way to do the foundational work of supporting cross-compilation with the Microsoft toolchain, just le me know how you'd like t

Re: OpenJDK extension to AArch64 and Windows

2020-06-24 Thread Ludovic Henry
egister usage since on Windows + Arm64, > register R18 points to TEB [4]. We have discussed this with Andrew Haley and > Andrew Dinn, and they are helping us with a cleaner implementation of the > same. Their constant support and guidance have humbled me. > > I'd also like to recog