On Wed, 7 Apr 2021 16:32:52 GMT, Lutz Schmidt wrote:
> May I please request reviews for this small build fix. It removes a linker
> warning by adding a assembly-time parameter which was previously missing. The
> same parameter is used at c++ compile time.
This pull request has
On Wed, 7 Apr 2021 21:59:15 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comment per request from erikj79
>
> Cool, Lutz, you found it đź‘Ť
Thank you f
On Wed, 7 Apr 2021 19:06:26 GMT, Daniel D. Daugherty wrote:
>> Thumbs up.
>
> Side bar: I don't quite understand the commit history part of this PR.
> It looks like this PR was used for something else before it was used
> for this fix.
@dcubed-ojdk Please just ignore the commit history. For some
On Wed, 7 Apr 2021 18:29:31 GMT, Erik Joelsson wrote:
>> May I please request reviews for this small build fix. It removes a linker
>> warning by adding a assembly-time parameter which was previously missing.
>> The same parameter is used at c++ compile time.
>
> So that's where that warning ca
> May I please request reviews for this small build fix. It removes a linker
> warning by adding a assembly-time parameter which was previously missing. The
> same parameter is used at c++ compile time.
Lutz Schmidt has updated the pull request incrementally with one additional
com
May I please request reviews for this small build fix. It removes a linker
warning by adding a assembly-time parameter which was previously missing. The
same parameter is used at c++ compile time.
-
Commit messages:
- Update Copyright Header
- Merge branch 'JDK-8264848' of github.
dy.
Didn’t Martin give you a review as well?
Sorry, I took a few off-screen (or screen off) hours.
Thanks,
Lutz
From: Aleksey Shipilëv
Reply to: openjdk/jdk
Date: Thursday, 26. November 2020 at 18:48
To: openjdk/jdk
Cc: Lutz Schmidt , Mention
Subject: Re: [openjdk/jdk] 8257181: s390x builds are
On Thu, 26 Nov 2020 15:18:04 GMT, Aleksey Shipilev wrote:
> Sample build log sizes:
>
> PPC64 fastdebug, 200 kilobytes:
>
> https://builds.shipilev.net/openjdk-jdk/build-logs/build-linux-ppc64le-fastdebug.log
>
> S390X fastdebug, 20 megabytes!
>
> https://builds.shipilev.net/openjdk-jdk
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the unre
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the unre
On Fri, 25 Sep 2020 05:46:08 GMT, Kim Barrett wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> No, don't do this. In the original, double is used to obtain the desired
> alignmnent. Changing the element type to short reduces the align
11 matches
Mail list logo
