Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread Mikael Gerdin
Hi, On 2017-06-07 13:05, John Paul Adrian Glaubitz wrote: On Wed, Jun 07, 2017 at 12:05:26PM +0200, Erik Joelsson wrote: Can you check the contents of this file to verify that the object file in question is actually missing: /<>/build-zero/hotspot/variant-zero/libjvm/objs/_BUILD_LIBJVM_objectf

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Mikael Gerdin
the CMakeLists generation is .PHONY-target. /Mikael /Robbin Thanks for doing this! /Robbin Thanks, /Erik On 2017-03-22 15:21, Mikael Gerdin wrote: Hi all, I've finally grown tired of manually setting up a hand crafted Eclipse CDT configuration for the JVM sources and decided

C/C++ IDE support for HotSpot

2017-03-22 Thread Mikael Gerdin
Hi all, I've finally grown tired of manually setting up a hand crafted Eclipse CDT configuration for the JVM sources and decided to share my progress towards improving the overall situation for JVM developers. To achieve better IDE support without having to add project generators for all dif

RFR(XS) 8161915: Linking gtestLauncher may end up linking with non-gtest libjvm

2016-07-20 Thread Mikael Gerdin
Hi all, Please review this small fix to work around a problem where incremental builds of hotspot would fail due to the symbol runUnitTests missing. The cause for the problem is that the unit tests launcher linker command line contains a -L path containing the standard libjvm.so [10] LDFLAGS

Re: Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

2015-12-14 Thread Mikael Gerdin
Hi David, On 2015-12-11 14:21, David Holmes wrote: On 11/12/2015 11:16 PM, Magnus Ihse Bursie wrote: On 2015-12-03 03:11, Roger Riggs wrote: Hi, It would be useful to figure out the number of cpus available when in a container. Some comments have added to: 8140793

Re: RFR(XS): JDK-8114853 variable tracking size limit exceeded in vmStructs.cpp

2015-12-03 Thread Mikael Gerdin
Hi Dmitry, On 2015-12-03 14:53, Dmitry Samersoff wrote: Everybody, I'd followed common opinion and turn off tracking of variable assignment for vmStructs file only. Updated webrev is here: http://cr.openjdk.java.net/~dsamersoff/JDK-8114853/webrev.02/ Looks good to me. /Mikael -Dmitry On

Re: RFR(XS): JDK-8114853 variable tracking size limit exceeded in vmStructs.cpp

2015-11-19 Thread Mikael Gerdin
Hi, On 2015-11-19 12:58, Dmitry Samersoff wrote: Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8114853/webrev.01/ Isn't it possible to set -fno-var-tracking-assignments for just vmstructs.cpp? In my opinion it's really helpful to have as much debug info as possible

Re: Problems with --with-override and gensrc targets

2015-11-04 Thread Mikael Gerdin
Hi Magnus, On 2015-11-03 18:23, Magnus Ihse Bursie wrote: On 2015-11-02 15:41, Mikael Gerdin wrote: Hi build-devs, I was trying to do a fancy setup with multiple different hotspot directories in a single source tree to create some builds for performance measurements. I used the configure

Problems with --with-override and gensrc targets

2015-11-02 Thread Mikael Gerdin
Hi build-devs, I was trying to do a fancy setup with multiple different hotspot directories in a single source tree to create some builds for performance measurements. I used the configure flag --with-override-hotspot=hotspot-foo and when I attempted a "make images" I get the following error:

Re: Re: Solaris jdk9 build problem

2015-06-02 Thread Mikael Gerdin
On 2015-06-02 12:06, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could yo

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-24 Thread Mikael Gerdin
gards, Volker On Thu, Mar 19, 2015 at 2:56 PM, Mikael Gerdin wrote: Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since HotSpot builds with warnings-as-errors this failed the build only when I got to the Solaris build. To catch this issue earlier for me (

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Mikael Gerdin
Oh, and the bug id is 8075511 https://bugs.openjdk.java.net/browse/JDK-8075511 /Mikael On 2015-03-19 14:56, Mikael Gerdin wrote: Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since HotSpot builds with warnings-as-errors this failed the build only

RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Mikael Gerdin
Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since HotSpot builds with warnings-as-errors this failed the build only when I got to the Solaris build. To catch this issue earlier for me (and a lot of others who use Linux as their preferred developmen

Re: RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-25 Thread Mikael Gerdin
> > Thanks, > David > > On 18/09/2014 6:39 PM, Mikael Gerdin wrote: > > Hi all, > > > > As you may know, linking an ELF shared object allows unresolved external > > symbols at link time. This is sometimes problematic for JVM developers > > since the J

RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-18 Thread Mikael Gerdin
Hi all, As you may know, linking an ELF shared object allows unresolved external symbols at link time. This is sometimes problematic for JVM developers since the JVM does not depend on unresolved external symbols and all missing symbols at build time are due to mistakes, usually missing include

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
ush my opinions on this any further. /Mikael Dan P.S. There is a reason the "#pragma redefine_extname" mechanism is preferred to the "#define" mechanism that is discussed in the largefiles.pdf, but that point is not critical to this discussion. On 6/6/13 3:20 AM, Mikael Gerdi

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
ce of code handles some exception I need to fix. It is not what I want to change but rather what I have to change. Please see inline. Thanks. Tao On 6/5/13 9:02 AM, Mikael Gerdin wrote: Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-06 Thread Mikael Gerdin
Dan, On 2013-06-05 18:06, Daniel D. Daugherty wrote: On 6/5/13 10:02 AM, Mikael Gerdin wrote: Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Mikael Gerdin
Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM, Mikael Gerdin wrote: On 2013-06-05 02:21, Daniel D. Daugherty wrote: OK, based on the

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Mikael Gerdin
. Tao On 5/30/13 10:21 AM, Tao Mao wrote: Included runtime dev to see whether they have some idea to handle the compilation choices. For now, it's been verified that the fix is functionally sufficient. Thanks. Tao On 5/29/13 5:27 PM, Tao Mao wrote: Thank you, Mikael. Please see inline.

Re: Somehow I got Nils's mail without attachment. [RFR (M): 8008772: remove gamma launcher]

2013-05-02 Thread Mikael Gerdin
rk. We should update the plugin to help with that. A big thank you to Christian Törnqvist for the proposal! //Nils On 2013-04-23 20:33, Mikael Gerdin wrote: On 2013-04-23 20:28, Christian Thalinger wrote: On Apr 23, 2013, at 11:06 AM, Nils Eliasson wrote: As long as we fix it first and re

Re: RFR (M): 8008772: remove gamma launcher

2013-04-23 Thread Mikael Gerdin
ast try this before you leave? /Mikael -- Chris //Nils On 2013-04-23 12:59, Mikael Gerdin wrote: On 2013-04-23 11:09, Nils Eliasson wrote: The gamma launcher is used to run and debug hotspot from Visual Studio. So removing gamma effectively kills the working environment for a number of p

Re: RFR (M): 8008772: remove gamma launcher

2013-04-23 Thread Mikael Gerdin
On 2013-04-23 11:09, Nils Eliasson wrote: The gamma launcher is used to run and debug hotspot from Visual Studio. So removing gamma effectively kills the working environment for a number of people that use it daily. So I am strongly against removing it. Maybe the visual studio project genera

Re: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME environment variable

2013-04-08 Thread Mikael Gerdin
Christian, On 04/07/2013 06:39 AM, Christian Thalinger wrote: http://cr.openjdk.java.net/~twisti/8011678 Looks good to me. /Mikael 8011678: test/Makefile should pick up JT_HOME environment variable Reviewed-by: The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME. Pi

Re: : JDK8 build fails in hotspot (hsx/hotspot-main/hotspot/rev/a297b0e14605 patch?)

2012-06-15 Thread Mikael Gerdin
Lana, This is indeed an issue with HotSpot and GCC 4.7. It's fixed by http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/a297b0e14605 I'm not sure when this will end up in jdk8 master but I think the change will be in hs24-b14. /Mikael On 2012-06-13 18:51, Lana Steuck wrote: Forwarding Ma