Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-28 Thread Peter Levart
On Wed, 28 Oct 2020 03:46:55 GMT, Stuart Marks wrote: > Some thoughts regarding the parameter type of refersTo. Summary: I think > `refersTo(T)` is fine and that we don't want to change it to > `refersTo(Object)`. > I agree that we don't have a migration problem here that collections had. So

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-24 Thread Peter Levart
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote: >> I just want to note that if you have a `Reference ref` at hand, >> you can not just do: >> Referemce r = (Reference) ref; >> ...since those generic types are not related. You have to do something like: >> >>

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-11 Thread Peter Levart
On 7/11/20 9:31 AM, Peter Levart wrote: - compile the two sets of benchmarks separately with separate output directories and create separate benchmarks.jar files for them Here's my attempt at a patch for separate benchmarks.jar files. The minor complication, as I found out, was what to do

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-11 Thread Peter Levart
bove files and; or - compile the two sets of benchmarks separately with separate output directories and create separate benchmarks.jar files for them I think the 2nd option is a simpler, pragmatic solution. Peter On 7/7/20 10:26 AM, Peter Levart wrote: I suggest adding --enable-preview to JM

Re: cannot find valid Visual Code Studio install

2020-07-10 Thread Peter Levart
Don't know much about build system but the following caught my eye: On 7/10/20 12:04 AM, Ty Young wrote: c1xx: fatal error C1083: Cannot open source file:

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-07 Thread Peter Levart
On 7/7/20 4:26 PM, Peter Levart wrote: I suggest adding --enable-preview to JMH_JVM_ARGS in general now (it doesn't hurt even if classes are not compiled with --enable-preview) and then take time to devise an effective strategy for selectively compiling micro benchmarks with or without

Re: RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

2020-07-07 Thread Peter Levart
I suggest adding --enable-preview to JMH_JVM_ARGS in general now (it doesn't hurt even if classes are not compiled with --enable-preview) and then take time to devise an effective strategy for selectively compiling micro benchmarks with or without --enable-preview. At least so the benchmarks

Re: Change for 8248135: Build microbenchmarks with --enable-preview makes other non-preview JMH benchmarks to fail

2020-07-07 Thread Peter Levart
-dev/2020-June/thread.html#27804 Some great discussion was had, but I’m not sure that a conclusion was reached yet. 8248429 is the same issue, right? -Chris. [1] https://bugs.openjdk.java.net/browse/JDK-8248429 On 7 Jul 2020, at 09:41, Peter Levart wrote: A quick work-around for anyone

Re: Change for 8248135: Build microbenchmarks with --enable-preview makes other non-preview JMH benchmarks to fail

2020-07-07 Thread Peter Levart
), ) $1_JMH_JVM_ARGS += $$(MICRO_VM_OPTIONS) $$(MICRO_JAVA_OPTIONS)    endif ...I can prepare a formal RFR quickly if this is the way to go. Regards, Peter On 7/7/20 10:41 AM, Peter Levart wrote: A quick work-around for anyone wanting to run the microbenchmarks is to pass --enable-preview

Re: Change for 8248135: Build microbenchmarks with --enable-preview makes other non-preview JMH benchmarks to fail

2020-07-07 Thread Peter Levart
A quick work-around for anyone wanting to run the microbenchmarks is to pass --enable-preview explicitly. For example: make test TEST="micro:java.util.stream.ops" MICRO="JAVA_OPTIONS=--enable-preview" Regards, Peter On 7/7/20 10:23 AM, Peter Levart wrote: On 7/

Re: Change for 8248135: Build microbenchmarks with --enable-preview makes other non-preview JMH benchmarks to fail

2020-07-07 Thread Peter Levart
On 7/7/20 10:13 AM, David Holmes wrote: Hi Peter, cc Claes On 7/07/2020 5:59 pm, Peter Levart wrote: Hi, Recently I proposed and pushed a change for [1] which adds --enable-preview option to javac compilation of JMH microbenchmarks in general to enable running a benchmark that uses

Change for 8248135: Build microbenchmarks with --enable-preview makes other non-preview JMH benchmarks to fail

2020-07-07 Thread Peter Levart
Hi, Recently I proposed and pushed a change for [1] which adds --enable-preview option to javac compilation of JMH microbenchmarks in general to enable running a benchmark that uses preview feature (Records). This makes the class files produced marked with version 60.65535. The benchmark

Re: RFR: 8247532, 8248135: Records deserialization is slow + Build microbenchmarks with --enable-preview

2020-06-23 Thread Peter Levart
On 6/23/20 2:47 PM, Chris Hegarty wrote: On 23 Jun 2020, at 10:46, Chris Hegarty wrote: On 23 Jun 2020, at 10:17, Peter Levart wrote: ... http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.08/ Good stuff. Reviewed. I am going to take this latest change and run

Re: RFR: 8247532, 8248135: Records deserialization is slow + Build microbenchmarks with --enable-preview

2020-06-23 Thread Peter Levart
Thanks, Magnus. Peter On 6/23/20 11:27 AM, Magnus Ihse Bursie wrote: On 2020-06-23 11:17, Peter Levart wrote: Including build-dev since this patch is adding new issue 8248135: https://bugs.openjdk.java.net/browse/JDK-8248135 So here's new webrev with a patch for building benchmarks

Re: RFR: 8247532, 8248135: Records deserialization is slow + Build microbenchmarks with --enable-preview

2020-06-23 Thread Peter Levart
/ Regards, Peter On 6/23/20 10:23 AM, Claes Redestad wrote: On 2020-06-23 10:06, Claes Redestad wrote: Hi, On 2020-06-23 09:49, Peter Levart wrote: Hi Chris, Claes, Ok then, here's with benchmark included: http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.07/ I

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Peter Levart
Hi Mandy, On 04/03/2017 11:50 PM, Mandy Chung wrote: JDK 8 JDK 9 - - OS_NAMELinux linux SunOS solaris Darwin macos Windows windows OS_ARCH

Re: Modular Run-Time Images build fails with JDK8u25 as bootstrap JDK

2014-12-07 Thread Peter Levart
against classes in the boot JDK, which cause the build to mix in old class files from the boot JDK. Obviously if you do a fresh build, everything ought to be out of date, regardless of which boot JDK is in use. s'marks On 12/6/14 11:20 AM, Peter Levart wrote: Hi, I thought I might inform you