Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-14 Thread Yi Yang
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote: >> Found various typos of expected: `exepected`, `exept`, `epectedly`, >> `expeced`, `Unexpeted`, etc. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8284853: Fi

Re: RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Yi Yang
On Sat, 28 Nov 2020 23:14:35 GMT, Emmanuel Bourg wrote: > The copyright headers are generated at build time, and the year inserted in > the template depends on the current date. This means the headers are not > reproducible if the project is built a year later. The year in the headers > could

Withdrawn: 8263028: Windows build fails due to several treat-warning-as-errors

2021-04-02 Thread Yi Yang
On Sun, 21 Mar 2021 04:22:42 GMT, Yi Yang wrote: > cl.exe(19.28.29334) can not build JDK on windows_x64 because it treats many > warnings as errors thus prohibiting further compilation. (See detailed > failure logs on JBS) > > 1. methodMatcher.cpp > > cl.exe can not han

Re: RFR: 8263028: Windows build fails due to several treat-warning-as-errors

2021-04-02 Thread Yi Yang
On Mon, 29 Mar 2021 14:42:00 GMT, Yi Yang wrote: >> I searched the net once more for setting the locale, and this time I found >> some creative workarounds on superuser. The suggestion is to create a >> *secondary* user account, and set US English as locale for that account

Re: RFR: 8263028: Windows build fails due to several treat-warning-as-errors

2021-03-29 Thread Yi Yang
On Mon, 29 Mar 2021 09:56:09 GMT, Magnus Ihse Bursie wrote: >> @kelthuzadx Hi Yang, >> >> Setting locale to US English used to be documented as a build requirement. >> When the "new" build-infra system was introduced several years ago, we >> thought that all locale-dependent issues were solved