Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-28 Thread Zhengyu Gu
On Fri, 28 Jan 2022 09:38:14 GMT, Christian Hagedorn wrote: > > > That's interesting. Is this implementation still around somewhere? I'm > > > glad that some of the mentioned things are not a problem anymore. > > > > > > Not I know. IIRC, it was based on DWARF 2. > > Okay, thanks. > > > > >

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-27 Thread Zhengyu Gu
On Thu, 27 Jan 2022 08:38:02 GMT, Christian Hagedorn wrote: > > Build changes look good. > > Thanks Erik! > > > Personally, I am in favor of this project. Actually, I were experimenting > > it with libdwarf. > > I would like to add some historical background on this topic, just for > > consi

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-26 Thread Zhengyu Gu
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000

Re: RFR: JDK-8280583: Always build NMT [v3]

2022-01-26 Thread Zhengyu Gu
On Wed, 26 Jan 2022 08:36:44 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >> th

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v2]

2020-11-02 Thread Zhengyu Gu
On Mon, 2 Nov 2020 15:58:15 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >> ta

Re: [8u] RFR: 8252975: [8u] JDK-8252395 breaks the build for --with-native-debug-symbols=internal

2020-09-09 Thread Zhengyu Gu
Verified, it fixed build. Looks good to me. Thanks for the quick fix. -Zhengyu On 9/9/20 2:16 PM, Severin Gehwolf wrote: Hi, Please review this 8u (jdk8u/jdk8u-dev tree) fix for JDK-8252395 that I've pushed today. Thanks for Zhengyu Gu for noticing it. The pushed fix added the java.debu

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-11-26 Thread Zhengyu Gu
Hi Kim, - taskqueue.hpp has some small adjustments to enable subclassing Why this change instead of JDK-8204947? As the description from that RFE says: "The ShenandoahTaskTerminator from the Shenandoah project is a much better implementation of a task terminator.” We were busy on pre

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-12 Thread Zhengyu Gu
Probably should also backport the followup RFE: https://bugs.openjdk.java.net/browse/JDK-8206183 Thanks, -Zhengyu On 09/11/2018 10:58 PM, David Holmes wrote: Or to be a little less obscure, this is a known issue and you should look into backporting: https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared

2018-06-15 Thread Zhengyu Gu
Hi, Whatever the name you come up, could you please also update stringDedup.inline.hpp to use the same names? Thomas Schatzl pointed out the inconsistent, I made change to use S and Q, but apparently, I messed up in final patch. Otherwise, looks good to me too. -Zhengyu On 06/15/2018 06

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Zhengyu Gu
Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to al

Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-09-30 Thread Zhengyu Gu
Hi All, Could you please help with code review? After that, I can help to push to jdk8. Thanks, -Zhengyu On 9/19/2011 2:43 AM, Sean Chou wrote: Thanks to Gu and Neil. 2011/9/16 Zhengyu Gu <mailto:[email protected]>> Okay, once review is completed, I would help you t

Re: Add version information to jvmti demos.

2011-09-15 Thread Zhengyu Gu
Okay, once review is completed, I would help you to push to jdk8. Thanks, -Zhengyu On 9/15/2011 2:51 PM, Neil Richards wrote: On Thu, 2011-09-15 at 12:14 -0400, Zhengyu Gu wrote: No progress been made. Any reason should be resolved right away? Thanks, -Zhengyu On 9/15/2011 2:50 AM, Sean

Re: Add version information to jvmti demos.

2011-09-15 Thread Zhengyu Gu
No progress been made. Any reason should be resolved right away? Thanks, -Zhengyu On 9/15/2011 2:50 AM, Sean Chou wrote: Hi, About this bug, is there any progressing ? 2011/6/8 Zhengyu Gu mailto:[email protected]>> No, I did not make any progress on 6988099, as it was de

Re: Add version information to jvmti demos.

2011-06-08 Thread Zhengyu Gu
No, I did not make any progress on 6988099, as it was deferred to JDK8. With Dan's comment, looks good to me. Thanks, -Zhengyu On 6/7/2011 12:10 PM, Daniel D. Daugherty wrote: Adding Zhengyu since he is the RE on 6988099 and I'm not sure if he is on the serviceability-dev alias... Zhengyu, I