Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option

2020-01-19 Thread Andrew John Hughes
On 27/09/2019 16:48, Severin Gehwolf wrote: > Hi, > > Could I please get a review of this 8u build change backport which adds > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain > assembler only flags for some builds. For example "-Wa,--generate- > missing-build-notes=yes"

Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option

2020-01-17 Thread Martin Buchholz
LGTM On Fri, Jan 17, 2020 at 2:59 AM Severin Gehwolf wrote: > Hi, > > Could I get a second review from an JDK 8u Reviewer, please? > > Thanks, > Severin > > On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > > On 2019-09-27 17:48, Severin Gehwolf wrote: > > > Hi, > > > > > > Could I

Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option

2020-01-17 Thread Severin Gehwolf
Hi, Could I get a second review from an JDK 8u Reviewer, please? Thanks, Severin On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > On 2019-09-27 17:48, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this 8u build change backport which > > adds > > --with-extr

Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option

2019-09-30 Thread Severin Gehwolf
On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > On 2019-09-27 17:48, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this 8u build change backport which adds > > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain > > assembler only flags fo

Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option

2019-09-30 Thread Magnus Ihse Bursie
On 2019-09-27 17:48, Severin Gehwolf wrote: Hi, Could I please get a review of this 8u build change backport which adds --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain assembler only flags for some builds. For example "-Wa,--generate- missing-build-notes=yes", to assembly

[8u] RFR: 8227397: Add --with-extra-asflags configure option

2019-09-27 Thread Severin Gehwolf
Hi, Could I please get a review of this 8u build change backport which adds --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain assembler only flags for some builds. For example "-Wa,--generate- missing-build-notes=yes", to assembly files only. As the build system is different