Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread David Holmes
On 15/01/2015 6:23 AM, David DeHaven wrote: Can someone from hotspot-dev please look at the hotspot changes? Looks okay to me. Thanks, David H. -DrD- Hello, This looks good to me. Thanks for the detailed table! /Erik On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argu

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread David DeHaven
Can someone from hotspot-dev please look at the hotspot changes? -DrD- > Hello, > > This looks good to me. Thanks for the detailed table! > > /Erik > > On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argument is optional, you should also be able to build with Xcode

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread Erik Joelsson
Hello, This looks good to me. Thanks for the detailed table! /Erik On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argument is optional, you should also be able to build with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I leave MAS managed Xcode (curr

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-13 Thread David DeHaven
>> The --with-xcode-path argument is optional, you should also be able to build >> with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I >> leave MAS managed Xcode (currently 6) active as I'm constantly bouncing >> between projects and it's a hassle to have to remember to

Building openjdk8 - was Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Toby Thain
On 12/01/15 10:28 AM, David DeHaven wrote: It won't build at all with Xcode 5, there is no gcc compiler and the clang changes were never backported to jdk8u. Yes. I believe those who have done this on Mavericks (including me) are using the apple-gcc4.2 binaries (e.g. the one that brew can i

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
> The --with-xcode-path argument is optional, you should also be able to build > with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I > leave MAS managed Xcode (currently 6) active as I'm constantly bouncing > between projects and it's a hassle to have to remember to res

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Erik Joelsson
I'm happy with that answer. Thanks! /Erik On 2015-01-12 17:25, David DeHaven wrote: Or rather, the point of this exercise is to eliminate the hacks to get it to build with Xcode 5 (I'm not sure if anyone was truly successful with that). It's far better to just build with Xcode 4.6.3, and with

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
Or rather, the point of this exercise is to eliminate the hacks to get it to build with Xcode 5 (I'm not sure if anyone was truly successful with that). It's far better to just build with Xcode 4.6.3, and with these changes you don't even need to pre-sanitize your Xcode environment. A proper b

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
It won't build at all with Xcode 5, there is no gcc compiler and the clang changes were never backported to jdk8u. -DrD- > Hello, > > These changes look ok to me. > > With these changes, configure will unconditionally fail if trying to use > XCode 5. I know we don't officially support using

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Erik Joelsson
Hello, These changes look ok to me. With these changes, configure will unconditionally fail if trying to use XCode 5. I know we don't officially support using XCode 5 for JDK 8, but aren't people working around it with some patches? How hard would it be to make it at least build? /Erik On

[8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-09 Thread David DeHaven
Please review the open source changes for 8043340. The goal here is to get jdk8u to build on Mac OS X 10.9+ systems where Xcode 5+ and Xcode 4 are co-installed, a configuration which is becoming more and more commonplace as more developers are focusing on JDK 9 now (which needs Xcode 5 installe