Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-10 Thread Vladimir Kozlov
Thank you, Erik Vladimir On 12/9/16 11:42 PM, Erik Joelsson wrote: This looks ok to me. /Erik On 2016-12-09 10:13, Vladimir Kozlov wrote: Thank you, Magnus, for review. I updated webrevs with merge from latest jdk9/hs which now has Jigsaw update. http://cr.openjdk.java.net/~kvn/8166417.v2

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Erik Joelsson
This looks ok to me. /Erik On 2016-12-09 10:13, Vladimir Kozlov wrote: Thank you, Magnus, for review. I updated webrevs with merge from latest jdk9/hs which now has Jigsaw update. http://cr.openjdk.java.net/~kvn/8166417.v2/top.webrev/ http://cr.openjdk.java.net/~kvn/8166417.v2/jdk.webrev/

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Vladimir Kozlov
Thank you, Mandy Vladimir On 12/9/16 11:00 AM, Mandy Chung wrote: On Dec 9, 2016, at 10:40 AM, Vladimir Kozlov wrote: It is very hard to drop the last comma from makefile code. I don't know how to do that. Please, don't fix this in tool and allow such output. Otherwise I will have to ret

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Mandy Chung
> On Dec 9, 2016, at 10:40 AM, Vladimir Kozlov > wrote: > > > It is very hard to drop the last comma from makefile code. I don't know how > to do that. Please, don't fix this in tool and allow such output. > > Otherwise I will have to return back to produces multiple `provides` of the > sam

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Vladimir Kozlov
On 12/9/16 8:40 AM, Mandy Chung wrote: On Dec 8, 2016, at 11:07 PM, Vladimir Kozlov wrote: The new syntax for provides is to have one `provides` clause of the same SPI with comma-separated implementation classes (see [1] for reference) Previous loop in this makefile also produces multiple

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Mandy Chung
> On Dec 8, 2016, at 11:07 PM, Vladimir Kozlov > wrote: > >> >> The new syntax for provides is to have one `provides` clause of the same SPI >> with comma-separated implementation classes (see [1] for reference) > > Previous loop in this makefile also produces multiple `provides` of the same

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Mandy Chung
> On Dec 9, 2016, at 12:25 AM, Doug Simon wrote: > > The reason we use VM.savedProps is that initialization of JVMCI and Graal is > lazy (to avoid impacting VM startup) and can take place after application > code has been executed. As such, we want to avoid the possibility of > tampering with

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Vladimir Kozlov
Thank you, Magnus, for review. I updated webrevs with merge from latest jdk9/hs which now has Jigsaw update. http://cr.openjdk.java.net/~kvn/8166417.v2/top.webrev/ http://cr.openjdk.java.net/~kvn/8166417.v2/jdk.webrev/ http://cr.openjdk.java.net/~kvn/8166417.v2/hotspot.webrev/ Removed hotspot

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-09 Thread Doug Simon
> On 9 Dec 2016, at 08:07, Vladimir Kozlov wrote: > > Thank you, Mandy > > On 12/8/16 7:46 PM, Mandy Chung wrote: >> >>> On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov >>> wrote: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8166417 >>> >>> It is part of JEP 295: Ahead-of-Time Compilation

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Vladimir Kozlov
Thank you, Mandy On 12/8/16 7:46 PM, Mandy Chung wrote: On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8166417 It is part of JEP 295: Ahead-of-Time Compilation https://bugs.openjdk.java.net/browse/JDK-8166089 http://cr.openjdk.java.net/~kvn/8166

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Mandy Chung
> On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8166417 > > It is part of JEP 295: Ahead-of-Time Compilation > https://bugs.openjdk.java.net/browse/JDK-8166089 > > http://cr.openjdk.java.net/~kvn/8166417/top.webrev/ > http://cr.openjdk.java.

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Vladimir Kozlov
Thank you, Erik It was accident - I forgot to replace ENABLE_AOT with INCLUDE_GRAAL. But it is very good accident :) It showed that Tools.gmk is not needed - nice. Removed and verified that combined AOT+Graal code is still built as before. Thanks, Vladimir On 12/8/16 2:12 AM, Erik Joelsson

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Doug Simon
> On 8 Dec 2016, at 13:50, Magnus Ihse Bursie > wrote: > > On 2016-12-07 23:10, Vladimir Kozlov wrote: >> https://bugs.openjdk.java.net/browse/JDK-8166417 >> >> It is part of JEP 295: Ahead-of-Time Compilation >> https://bugs.openjdk.java.net/browse/JDK-8166089 >> >> http://cr.openjdk.java.ne

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Magnus Ihse Bursie
On 2016-12-07 23:10, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8166417 It is part of JEP 295: Ahead-of-Time Compilation https://bugs.openjdk.java.net/browse/JDK-8166089 http://cr.openjdk.java.net/~kvn/8166417/top.webrev/ http://cr.openjdk.java.net/~kvn/8166417/jdk.webrev/

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-08 Thread Erik Joelsson
Hello, The file hotspot/make/Tools.gmk is dead code at this point and should be removed. Also stop including it from Gensrc-jdk.vm.compiler.gmk. Otherwise it looks ok to me. /Erik On 2016-12-07 23:10, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8166417 It is part of JEP

Re: [9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-07 Thread Igor Veresov
Perfect. :) Reviewed. igor > On Dec 7, 2016, at 2:10 PM, Vladimir Kozlov > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8166417 > > It is part of JEP 295: Ahead-of-Time Compilation > https://bugs.openjdk.java.net/browse/JDK-8166089 > > http://cr.openjdk.java.net/~kvn/8166417/top.webre

[9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

2016-12-07 Thread Vladimir Kozlov
https://bugs.openjdk.java.net/browse/JDK-8166417 It is part of JEP 295: Ahead-of-Time Compilation https://bugs.openjdk.java.net/browse/JDK-8166089 http://cr.openjdk.java.net/~kvn/8166417/top.webrev/ http://cr.openjdk.java.net/~kvn/8166417/jdk.webrev/ http://cr.openjdk.java.net/~kvn/8166417/hotsp