On 2015-03-25 15:44, Pete Brunet wrote:
On 3/25/15 3:01 AM, Erik Joelsson wrote:
Hello Peter,
The new source layout and Lib-jdk.accessibility.gmk look much better.
Thanks!
Regarding the .def files, I was mistaken and missed that they were
referenced in the LDFLAGS, they were indeed used in th
On 3/25/2015 10:58 AM, Pete Brunet wrote:
Thanks Phil,
On 3/25/15 11:26 AM, Phil Race wrote:
AWTEventMonitor.java has a bunch of deprecated methods.
If you don't have time now (I expect you don't) then it can be
revisited later. Open sourcing is different than binary compatibility.
These were
Thanks Phil,
On 3/25/15 11:26 AM, Phil Race wrote:
> AWTEventMonitor.java has a bunch of deprecated methods.
> If you don't have time now (I expect you don't) then it can be
> revisited later. Open sourcing is different than binary compatibility.
These were deprecated via CCC 8007499.
>
> The chan
AWTEventMonitor.java has a bunch of deprecated methods.
If you don't have time now (I expect you don't) then it can be
revisited later. Open sourcing is different than binary compatibility.
The change jdk/make/copy/Copy-java.gmk suggests that accessbridge
is the only reason the closed version of
On 3/24/2015 2:36 PM, Pete Brunet wrote:
Here's the latest patch:
http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/
The modules.xml change looks fine.
Mandy
Hi Sergey, Which methods are you referring to? -Pete
On 3/25/15 10:16 AM, Sergey Bylokhov wrote:
> The fix looks fine.
> But it is interesting, do we have an option to remove all deprecated
> methods during this opening? or can we do it later? or we cannot?
>
> 25.03.15 17:44, Pete Brunet wrote:
The fix looks fine.
But it is interesting, do we have an option to remove all deprecated
methods during this opening? or can we do it later? or we cannot?
25.03.15 17:44, Pete Brunet wrote:
On 3/25/15 3:01 AM, Erik Joelsson wrote:
Hello Peter,
The new source layout and Lib-jdk.accessibility
On 3/25/15 3:01 AM, Erik Joelsson wrote:
> Hello Peter,
>
> The new source layout and Lib-jdk.accessibility.gmk look much better.
> Thanks!
>
> Regarding the .def files, I was mistaken and missed that they were
> referenced in the LDFLAGS, they were indeed used in the build so no
> reason to remo
On 3/24/15 3:23 PM, Pete Brunet wrote:
> Hi Sergey, That's pretty much the case. I just went through the code
> and found these differences:
> - merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which
> was recently pushed.
That should have been jawtaccessbridge.dll (not jawt.dll)
Hello Peter,
The new source layout and Lib-jdk.accessibility.gmk look much better.
Thanks!
Regarding the .def files, I was mistaken and missed that they were
referenced in the LDFLAGS, they were indeed used in the build so no
reason to remove them.
/Erik
On 2015-03-24 22:36, Pete Brunet w
Here's the latest patch:
http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/
The changes are:
- restructured the native libraries from one directory to several
directories on a per DLL/EXE basis
- that impacted jdk/make/lib/Lib-jdk.accessibility.gmk
- removed the source for the Ferret and
Hi Sergey, That's pretty much the case. I just went through the code
and found these differences:
- merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which
was recently pushed.
- removed some dead code
- cleaned up up comments/documentation
- cleaned up some code indentation issues
Hi,Pete.
Do I understand correctly that the code itself were not changed except
files location?
21.03.15 7:33, Pete Brunet wrote:
Please review the following patch which will add the code of the Java
Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK.
This code is used by
Actually, I just noticed that we are indeed setting -def: to the linker.
Please leave the .def files in the patch.
/Erik
On 2015-03-24 15:55, Erik Joelsson wrote:
On 2015-03-24 14:08, Magnus Ihse Bursie wrote:
JavaAccessBridge.DEF is pretty empty. I'll see if the build will work
without
On 2015-03-24 14:08, Magnus Ihse Bursie wrote:
JavaAccessBridge.DEF is pretty empty. I'll see if the build will work
without it.
WinAccessBridge.DEF seems like it might be needed. What do you think?
Is it accessed by the compiler? Unless it is given as input to the
compiler or linker co
On 2015-03-23 18:31, Pete Brunet wrote:
Hi Erik,
I tried the restructuring about 2 weeks ago and the build failed trying
to find an h file in the common directory. I used two directories on
the SRC := setting for SetupNativeCompilation but the build failed not
finding an h file located in the s
Hi Erik,
I tried the restructuring about 2 weeks ago and the build failed trying
to find an h file in the common directory. I used two directories on
the SRC := setting for SetupNativeCompilation but the build failed not
finding an h file located in the second (common) directory.
On 3/23/15 5:06
Hello Pete,
In general this looks good. However, to better fit with our intended
source code file layout, I would prefer if the source was organized by
the names of the libraries being built, and this would be a good time to
get it done properly. Something like this:
jdk.accessibility/window
Please review the following patch which will add the code of the Java
Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK.
This code is used by Assistive Technology such as screen readers and
screen magnifiers used by those who are blind or have low vision. AT
use the JAB nati
19 matches
Mail list logo
