Kelly O'Hair wrote:
>
> Seems ok to me, just a few observations:
>
> Do we need this:
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Djavac.debug=true
> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
> endif
>
> to be
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Dj
Kelly O'Hair wrote:
>
> Seems ok to me, just a few observations:
>
> Do we need this:
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Djavac.debug=true
> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
> endif
>
> to be
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Dj
Seems ok to me, just a few observations:
Do we need this:
ifeq ($(DEBUG_CLASSFILES), true)
ANT_OPTIONS += -Djavac.debug=true
ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
endif
to be
ifeq ($(DEBUG_CLASSFILES), true)
ANT_OPTIONS += -Djavac.debug=true
ANT_OPTIONS += -Djavac.debugl
This is my first stab at moving patches from IcedTea into OpenJDK.
Rather than creating a single overriding variable that enables debuginfo
everywhere I've used two, one for native files and one for class files.
Setting DEBUG_CLASSFILES=true in the toplevel forces all classes to be built
with full