Re: Bug 100028 - Debug information is incomplete or missing

2009-03-31 Thread Andrew Haley
Kelly O'Hair wrote: > > Seems ok to me, just a few observations: > > Do we need this: > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > endif > > to be > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Dj

Re: Bug 100028 - Debug information is incomplete or missing

2009-03-30 Thread Andrew Haley
Kelly O'Hair wrote: > > Seems ok to me, just a few observations: > > Do we need this: > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > endif > > to be > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Dj

Re: Bug 100028 - Debug information is incomplete or missing

2009-03-27 Thread Kelly O'Hair
Seems ok to me, just a few observations: Do we need this: ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars endif to be ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debugl

Bug 100028 - Debug information is incomplete or missing

2009-03-26 Thread Andrew Haley
This is my first stab at moving patches from IcedTea into OpenJDK. Rather than creating a single overriding variable that enables debuginfo everywhere I've used two, one for native files and one for class files. Setting DEBUG_CLASSFILES=true in the toplevel forces all classes to be built with full